Re: [PR] DependencyScopeManager [maven]

2024-04-13 Thread via GitHub


cstamas closed pull request #1400: DependencyScopeManager
URL: https://github.com/apache/maven/pull/1400


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] DependencyScopeManager [maven]

2024-02-06 Thread via GitHub


gnodet commented on PR #1400:
URL: https://github.com/apache/maven/pull/1400#issuecomment-1931035092

   While I totally get the idea to refactor those bits in order to have a 
single source for scopes, this seems overly complicated and I don't see why the 
original enum is not sufficient.  The manager adds an additional layer for no 
benefit, as it does not provide any value over the enum definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] DependencyScopeManager [maven]

2024-02-06 Thread via GitHub


cstamas opened a new pull request, #1400:
URL: https://github.com/apache/maven/pull/1400

   This is WIP
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org