Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub


cstamas commented on code in PR #1297:
URL: https://github.com/apache/maven/pull/1297#discussion_r1383907491


##
api/maven-api-model/src/main/mdo/maven.mdo:
##
@@ -387,7 +388,7 @@
   
   
 
-  4.0.0/4.1.0
+  4.0.0/4.0.99

Review Comment:
   Sadly, modello "version range" predates (AFAIK, someone may correct me) 
Maven ranges, and has totally different  syntax... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub


kwin commented on code in PR #1297:
URL: https://github.com/apache/maven/pull/1297#discussion_r1383904826


##
api/maven-api-model/src/main/mdo/maven.mdo:
##
@@ -387,7 +388,7 @@
   
   
 
-  4.0.0/4.1.0
+  4.0.0/4.0.99

Review Comment:
   Ah, sorry. I get it now. I thought this element was for documentation 
purposes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub


gnodet commented on code in PR #1297:
URL: https://github.com/apache/maven/pull/1297#discussion_r1383873531


##
api/maven-api-model/src/main/mdo/maven.mdo:
##
@@ -387,7 +388,7 @@
   
   
 
-  4.0.0/4.1.0
+  4.0.0/4.0.99

Review Comment:
   This is closed ranged version notation.  That's defined by modello...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub


kwin commented on code in PR #1297:
URL: https://github.com/apache/maven/pull/1297#discussion_r1383859037


##
api/maven-api-model/src/main/mdo/maven.mdo:
##
@@ -387,7 +388,7 @@
   
   
 
-  4.0.0/4.1.0
+  4.0.0/4.0.99

Review Comment:
   @gnodet What is this supposed to mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub


gnodet merged PR #1297:
URL: https://github.com/apache/maven/pull/1297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org