[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359728#comment-359728 ] Michael Osipov commented on DOXIASITETOOLS-88: -- Subtasks are only possible within one project. I have linked to MSITE-453. > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359727#comment-359727 ] Herve Boutemy commented on DOXIASITETOOLS-88: - ok, good idea > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359714#comment-359714 ] Michael Osipov edited comment on DOXIASITETOOLS-88 at 12/26/14 1:48 PM: MSITE-453 has not moved for years. Regardless of that I would move this ticket as a subticket of MSITE-453. Without having knowledge about the skin, I wouldn't transform anything. was (Author: michael-o): MSITE-453 has not moved for years. If so, I would move this ticket as a subticket of MSITE-453. Without having knowledge about the skin, I wouldn't transform anything. > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359714#comment-359714 ] Michael Osipov commented on DOXIASITETOOLS-88: -- MSITE-453 has not moved for years. If so, I would move this ticket as a subticket of MSITE-453. Without having knowledge about the skin, I wouldn't transform anything. > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359690#comment-359690 ] Herve Boutemy commented on DOXIASITETOOLS-88: - bq. The question is, do files in the skin have the same encoding as siteOutputEncoding? I think you nailed the most important problem, more important than newlines it would require a skins descriptor inside the packaged skin, to document the encoding used by the skin then extensions to filter newlines could be added to the skin descriptor too we already had MSITE-453 about creating a skin packaging adding a skin descriptor would complete the overall picture and would give us a place to document how to create a skin, because this is not well documented AFAIK > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[
https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359686#comment-359686
]
Michael Osipov commented on DOXIASITETOOLS-88:
--
Well, SCM is special because you can set up normalization already there. I have
found the spot. It is
[{{ScmPublishPublishScmMojo#copyAndNormalizeNewlines}}|http://maven.apache.org/plugins/maven-scm-publish-plugin/xref/org/apache/maven/plugins/scmpublish/ScmPublishPublishScmMojo.html#L195].
We could easily copy the methods and reuse them. The question is, do files in
the skin have the same encoding as siteOutputEncoding? Are
{{src/site/resources}} copied appropriately? The former could break stuff.
> normalize newlines of text resources copied from skin
> -
>
> Key: DOXIASITETOOLS-88
> URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Reporter: Herve Boutemy
>Priority: Minor
>
> text resources from skin (*.css, *.js, ...) are copied in binary form
> but since the skin jar is done on one machine and reused on multiple other
> ones, not necessarily same platform, these files can have newlines
> inconsistent with actual platform
> Notice: I don't know if this is a severe problem, as severe as
> DOXIASITETOOLS-87, where inconsistency happened inside text files
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIASITETOOLS-88: Issue Type: Improvement (was: Bug) > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359677#comment-359677 ] Herve Boutemy commented on DOXIASITETOOLS-88: - no problem to change "bug" to "improvement" bq. Do you really think we need to improve this although no one has complained yet? for sure, I discovered the multiple newline issues when working on maven-scm-publish-plugin: see http://maven.apache.org/plugins/maven-scm-publish-plugin/publish-scm-mojo.html#extraNormalizeExtensions I have no strong feeling about doing this improvement now or later when it causes more harm > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Bug > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[
https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359657#comment-359657
]
Michael Osipov commented on DOXIASITETOOLS-88:
--
OK, this is a consistency improvement, not a bug, imho. We are talking about
{{DefaultSiteRenderer#copyResources}}. First of all, we need a line ending
normalizer and second what extensions are safe for normalization? That would
require another parameter in the site plugin. Do you really think we need to
improve this although no one has complained yet?
> normalize newlines of text resources copied from skin
> -
>
> Key: DOXIASITETOOLS-88
> URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Site renderer
>Reporter: Herve Boutemy
>Priority: Minor
>
> text resources from skin (*.css, *.js, ...) are copied in binary form
> but since the skin jar is done on one machine and reused on multiple other
> ones, not necessarily same platform, these files can have newlines
> inconsistent with actual platform
> Notice: I don't know if this is a severe problem, as severe as
> DOXIASITETOOLS-87, where inconsistency happened inside text files
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359616#comment-359616 ] Herve Boutemy commented on DOXIASITETOOLS-88: - bq. we aren't talking about fixing mixed line breaks but nomalization to the currently used platform, right? exactly: DOXIASITETOOLS-87 was about fixing mixed line endings your expanded description of what is expected is exactly what I summarised in the issue description, even if in real world, I don't expect a skin to have different line endings for each files the issue is just that a Unix end-user using a skin built on Windows will get Windows line endings for files taken from the skin and the opposite: a Windows end-user using a skin built on Unix will get Unix line-endingsg for files taken from the skin > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Bug > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359613#comment-359613 ] Michael Osipov commented on DOXIASITETOOLS-88: -- Me, human. Let's clarify one thing first: we aren't talking about fixing mixed line breaks but nomalization to the currently used platform, right? First of all, a dev is obliged to set up line break normalization with his SCM, both is possible with Git and Subversion. Second, if a dev uses Notepad, he should really stop coding right now. So this is our situation you would like to improve: 0. Current platform is Unix 1. skin.css with Windows EOL => Unix EOL 2. skin.js with Unix EOL => leave as-is The opposite would be true if the site is generated on Windows, right? > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Bug > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[
https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359608#comment-359608
]
Herve Boutemy commented on DOXIASITETOOLS-88:
-
it depends on what you call "fine", "you" being either a human (with his
personal ideas on this) or a tool
for example, {{git}} finds it fine, but IIRC, {{svn}} complains
and an end-user could complain when he's on Unix and finds Windows EOLs, or
when he's on Windows and his Notepad doesn't understand Unix newlines
> normalize newlines of text resources copied from skin
> -
>
> Key: DOXIASITETOOLS-88
> URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Site renderer
>Reporter: Herve Boutemy
>Priority: Minor
>
> text resources from skin (*.css, *.js, ...) are copied in binary form
> but since the skin jar is done on one machine and reused on multiple other
> ones, not necessarily same platform, these files can have newlines
> inconsistent with actual platform
> Notice: I don't know if this is a severe problem, as severe as
> DOXIASITETOOLS-87, where inconsistency happened inside text files
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
[ https://jira.codehaus.org/browse/DOXIASITETOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359531#comment-359531 ] Michael Osipov commented on DOXIASITETOOLS-88: -- Why is that a problem? As long as the line endings are consistent within the file, that should be fine, shouldn't it? > normalize newlines of text resources copied from skin > - > > Key: DOXIASITETOOLS-88 > URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 > Project: Maven Doxia Sitetools > Issue Type: Bug > Components: Site renderer >Reporter: Herve Boutemy >Priority: Minor > > text resources from skin (*.css, *.js, ...) are copied in binary form > but since the skin jar is done on one machine and reused on multiple other > ones, not necessarily same platform, these files can have newlines > inconsistent with actual platform > Notice: I don't know if this is a severe problem, as severe as > DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (DOXIASITETOOLS-88) normalize newlines of text resources copied from skin
Herve Boutemy created DOXIASITETOOLS-88: --- Summary: normalize newlines of text resources copied from skin Key: DOXIASITETOOLS-88 URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-88 Project: Maven Doxia Sitetools Issue Type: Bug Components: Site renderer Reporter: Herve Boutemy Priority: Minor text resources from skin (*.css, *.js, ...) are copied in binary form but since the skin jar is done on one machine and reused on multiple other ones, not necessarily same platform, these files can have newlines inconsistent with actual platform Notice: I don't know if this is a severe problem, as severe as DOXIASITETOOLS-87, where inconsistency happened inside text files -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
