[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328954#comment-328954 ] Amichai Rothman commented on MCHECKSTYLE-186: - So no sourceDirectory... interesting. Thanks! > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328950#comment-328950 ] Dipti Desai commented on MCHECKSTYLE-186: - {code} org.apache.maven.plugins maven-checkstyle-plugin 2.10 verify check **\/*.xml,**\/*.java **/target/**/*,**/test/**/* checkstyle/kepler-checkstyle-config.xml ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml {code} > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328949#comment-328949 ] Amichai Rothman commented on MCHECKSTYLE-186: - @Dipti, and the checkstyle plugin configuration (in the pom)? > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328928#comment-328928 ] Dipti Desai commented on MCHECKSTYLE-186: - This is what I am currently using in my checkstyle-config.xml Hope this helps. {code} {code} > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328900#comment-328900 ] Amichai Rothman commented on MCHECKSTYLE-186: - @Dipti, would you be able to share your working configuration? I've been struggling with this for hours as well, with various forms of includes/sourceDirectory/fileExtensions. Eventually I peeked at the source for DefaultCheckstyleExecutor.java, from which it appears that using the checkstyle-aggregate goal pretty much ignores the configured sourceDirectory. I switched to using the checkstyle goal and it finally picked up the xml files (under resources) and found the violations there. I'm not entirely sure how the sourceDirectory was desgined to function in aggregate, I'd assumed that I can configure it once in the parent (aggregator) and it would apply to the child modules and then aggregate the result, but the code seems to just take the standard build source directory for each child module, and ignoring the configured sourceDirectory when adding the files to process. If someone can confirm that this is indeed a bug, I'd be happy to open a separate issue for it. If the current behavior is by design, it would be useful to mention this in the documentation, seeing that it may not be intuitive for everyone. In addition, as logic and comments in the code say, it would be nice if the currently half-hacked resources directory treatment would be made generic: ideally, there would be a separate configuration for the sourcesDirectory, testSourcesDirectory and resourcesDirectory, and each one would have its own includes clause as well - for maximum configurability. > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dipti Desai closed MCHECKSTYLE-186. --- Resolution: Not A Bug > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=323906#comment-323906 ] Dipti Desai commented on MCHECKSTYLE-186: - This has been resolved. You may close this. Thanks for all your help. I am not sure what exactly fixed the problem but I poked around a bit in the maven checkstyle code and got the exact default expression for includes and excludes and modified and used that in my POMs. Also, upgraded to 2.10. > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322344#comment-322344 ] Dipti Desai commented on MCHECKSTYLE-186: - @Dennis, have you had a chance to look into my query above? > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320572#comment-320572 ] Dipti Desai commented on MCHECKSTYLE-186: - Thanks for your help. I am still facing issues with it. I am not sure what I could be doing wrong here. {code} org.apache.maven.plugins maven-checkstyle-plugin 2.9.1 **/*.xml,**/*.java ${project.basedir} checkstyle/kepler-checkstyle-config.xml ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml {code} In the tag, I tried ${project.basedir} as well as ${project.parent.basedir} to make it look through all possible files but the XMLs are still not being flagged for containing tabs. Do you see something that I might be missing? Could you please help? > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320340#comment-320340 ] Dennis Lundberg commented on MCHECKSTYLE-186: - How have you configured ? I'm guessing you haven't. Where are your xml-files? Are they in the ${project.build.sourceDirectory} directory? I'm guessing no. If not, then you need to configure the as well. > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320335#comment-320335 ] Dipti Desai commented on MCHECKSTYLE-186: - I did try this {code}**/*.xml,**/*.java{code} with and without the {code}{code} but the xml files are not getting flagged. Any idea what might be going wrong? > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319908#comment-319908 ] Dennis Lundberg commented on MCHECKSTYLE-186: - Hi, With the default configuration maven-checkstyle-plugin will only check java files. If you want it to check xml files you need to configure the plugin to do so. Please use the "includes" configuration parameter. > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319889#comment-319889 ] Dipti Desai commented on MCHECKSTYLE-186: - Thanks for your reply. I went through the linked issue and the revisions mentioned there. I may be missing something out here but I didn't really find anything specific that could validate my xml files. Could you please elaborate a little on what could fix this issue? > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MCHECKSTYLE-186: --- Description: The FileTabCharacter check doesnt seem to work. Below is my config: {code:xml} .. .. .. .. .. .. {code} I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations. Some additional info - my plugin config looks like this: {code:xml} org.apache.maven.plugins maven-checkstyle-plugin 2.9.1 verify check checkstyle/kepler-checkstyle-config.xml ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml {code} was: The FileTabCharacter check doesnt seem to work. Below is my config: .. .. .. .. .. .. I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations. Some additional info - my plugin config looks like this: org.apache.maven.plugins maven-checkstyle-plugin 2.9.1 verify check checkstyle/kepler-checkstyle-config.xml ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > FileTabCharacter check not working > -- > > Key: MCHECKSTYLE-186 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Bug >Reporter: Dipti Desai >Priority: Minor > > The FileTabCharacter check doesnt seem to work. Below is my config: > {code:xml} > > .. > .. > > > > > > .. > .. > > .. > .. > > > {code} > I have my xml files - pom.xml and checkstyle config xml containing tabs but > none of them are flagged as violations. > Some additional info - my plugin config looks like this: > {code:xml} > > org.apache.maven.plugins > maven-checkstyle-plugin > 2.9.1 > > > verify > > check > > > > > > checkstyle/kepler-checkstyle-config.xml > > ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml > > > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Dipti Desai created MCHECKSTYLE-186: --- Summary: FileTabCharacter check not working Key: MCHECKSTYLE-186 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186 Project: Maven 2.x Checkstyle Plugin Issue Type: Bug Reporter: Dipti Desai Priority: Minor The FileTabCharacter check doesnt seem to work. Below is my config: .. .. .. .. .. .. I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations. Some additional info - my plugin config looks like this: org.apache.maven.plugins maven-checkstyle-plugin 2.9.1 verify check checkstyle/kepler-checkstyle-config.xml ${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira