[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[
https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MCHECKSTYLE-252:
Fix Version/s: (was: 2.14)
Version 2.13 includes non-source files in checks
Key: MCHECKSTYLE-252
URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252
Project: Maven Checkstyle Plugin
Issue Type: Bug
Components: checkstyle:checkstyle
Affects Versions: 2.13
Reporter: Michael Heuer
Attachments: mcheckstyle-252.tar.gz
Updating maven-checkstyle-plugin to version 2.13 and running
{noformat}$ mvn site{noformat}
now includes non-source files in its checks, e.g.
{noformat}COPYING
COPYING.LESSER
target/generated-classes/cobertura/cobertura.properties{noformat}
While it is rather amusing to have checkstyle complain that COPYING (the text
of the GNU General Public License) doesn't include a license header, it seems
that the default source root or one of the other properties new to version
2.13 does not have an appropriate default value. The target directory should
also be excluded by default.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[
https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361341#comment-361341
]
Dennis Lundberg commented on MCHECKSTYLE-252:
-
I've had a look at the attached project and here are my findings on it.
{noformat}
COPYING
COPYING.LESSER
{noformat}
These are included by Checkstyle because they are defined as resources in the
POM.
{code:xml}
resources
resource
directory${basedir}/src/main/resources/directory
filteringfalse/filtering
/resource
resource
targetPathMETA-INF/targetPath
filteringfalse/filtering
directory${basedir}/directory
includes
includeCOPYING/include
includeCOPYING.LESSER/include
/includes
/resource
/resources
{code}
This is because of the fix for MCHECKSTYLE-70. A work-around for your problem
is available at
http://jira.codehaus.org/browse/MCHECKSTYLE-70?focusedCommentId=353837page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-353837
{noformat}
target/generated-classes/cobertura/cobertura.properties
{noformat}
This file I'm not sure why it is included, but I suspect that Cobertura has
something to to with it, beacause it alters the classpath of the project.
To summarize, Maven Checkstyle Plugin 2.13 does not include non-source files in
the check, but it does include more sources than version 2.12.
Version 2.13 includes non-source files in checks
Key: MCHECKSTYLE-252
URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252
Project: Maven Checkstyle Plugin
Issue Type: Bug
Components: checkstyle:checkstyle
Affects Versions: 2.13
Reporter: Michael Heuer
Fix For: 2.14
Attachments: mcheckstyle-252.tar.gz
Updating maven-checkstyle-plugin to version 2.13 and running
{noformat}$ mvn site{noformat}
now includes non-source files in its checks, e.g.
{noformat}COPYING
COPYING.LESSER
target/generated-classes/cobertura/cobertura.properties{noformat}
While it is rather amusing to have checkstyle complain that COPYING (the text
of the GNU General Public License) doesn't include a license header, it seems
that the default source root or one of the other properties new to version
2.13 does not have an appropriate default value. The target directory should
also be excluded by default.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[
https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MCHECKSTYLE-252:
--
Description:
Updating maven-checkstyle-plugin to version 2.13 and running
{noformat}$ mvn site{noformat}
now includes non-source files in its checks, e.g.
{noformat}COPYING
COPYING.LESSER
target/generated-classes/cobertura/cobertura.properties{noformat}
While it is rather amusing to have checkstyle complain that COPYING (the text
of the GNU General Public License) doesn't include a license header, it seems
that the default source root or one of the other properties new to version 2.13
does not have an appropriate default value. The target directory should also
be excluded by default.
was:
Updating maven-checkstyle-plugin to version 2.13 and running
$ mvn site
now includes non-source files in its checks, e.g.
COPYING
COPYING.LESSER
target/generated-classes/cobertura/cobertura.properties
While it is rather amusing to have checkstyle complain that COPYING (the text
of the GNU General Public License) doesn't include a license header, it seems
that the default source root or one of the other properties new to version 2.13
does not have an appropriate default value. The target directory should also
be excluded by default.
Version 2.13 includes non-source files in checks
Key: MCHECKSTYLE-252
URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252
Project: Maven Checkstyle Plugin
Issue Type: Bug
Components: checkstyle:checkstyle
Affects Versions: 2.13
Reporter: Michael Heuer
Fix For: 2.14
Attachments: mcheckstyle-252.tar.gz
Updating maven-checkstyle-plugin to version 2.13 and running
{noformat}$ mvn site{noformat}
now includes non-source files in its checks, e.g.
{noformat}COPYING
COPYING.LESSER
target/generated-classes/cobertura/cobertura.properties{noformat}
While it is rather amusing to have checkstyle complain that COPYING (the text
of the GNU General Public License) doesn't include a license header, it seems
that the default source root or one of the other properties new to version
2.13 does not have an appropriate default value. The target directory should
also be excluded by default.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[
https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361015#comment-361015
]
Herve Boutemy commented on MCHECKSTYLE-252:
---
@brentryan see MCHECKSTYLE-70
Version 2.13 includes non-source files in checks
Key: MCHECKSTYLE-252
URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252
Project: Maven Checkstyle Plugin
Issue Type: Bug
Components: checkstyle:checkstyle
Affects Versions: 2.13
Reporter: Michael Heuer
Fix For: 2.14
Attachments: mcheckstyle-252.tar.gz
Updating maven-checkstyle-plugin to version 2.13 and running
{noformat}$ mvn site{noformat}
now includes non-source files in its checks, e.g.
{noformat}COPYING
COPYING.LESSER
target/generated-classes/cobertura/cobertura.properties{noformat}
While it is rather amusing to have checkstyle complain that COPYING (the text
of the GNU General Public License) doesn't include a license header, it seems
that the default source root or one of the other properties new to version
2.13 does not have an appropriate default value. The target directory should
also be excluded by default.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=360968#comment-360968 ] Brent Ryan commented on MCHECKSTYLE-252: I want to add that this also seems to have caused checkstyle to include target/generated-sources and there doesn't appear to be anyway to exclude it. This is pretty huge because it means we can't use checkstyle at all for Java8 projects. Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Components: checkstyle:checkstyle Affects Versions: 2.13 Reporter: Michael Heuer Fix For: 2.14 Attachments: mcheckstyle-252.tar.gz Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MCHECKSTYLE-252: -- Fix Version/s: 2.14 Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Components: checkstyle:checkstyle Affects Versions: 2.13 Reporter: Michael Heuer Fix For: 2.14 Attachments: mcheckstyle-252.tar.gz Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MCHECKSTYLE-252: -- Component/s: checkstyle:checkstyle Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Components: checkstyle:checkstyle Affects Versions: 2.13 Reporter: Michael Heuer Fix For: 2.14 Attachments: mcheckstyle-252.tar.gz Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=354371#comment-354371 ] Dennis Lundberg commented on MCHECKSTYLE-252: - Hi Michael, What does your configuration look like? Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.13 Reporter: Michael Heuer Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=354372#comment-354372 ] Michael Heuer commented on MCHECKSTYLE-252: --- I first noticed it here https://svn.code.sf.net/p/dishevelled/code/trunk/worm-plot-cytoscape3-app/ with parent pom here https://svn.code.sf.net/p/dishevelled/code/trunk/parent/ I don't imagine it would be too difficult to come up with an empty test case; I'll see if I can do that this afternoon. Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.13 Reporter: Michael Heuer Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Heuer updated MCHECKSTYLE-252: -- Attachment: mcheckstyle-252.tar.gz Test case extracted from code on dishevelled.org. Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.13 Reporter: Michael Heuer Attachments: mcheckstyle-252.tar.gz Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
Michael Heuer created MCHECKSTYLE-252: - Summary: Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.13 Reporter: Michael Heuer Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=354322#comment-354322 ] Michael Heuer commented on MCHECKSTYLE-252: --- Looks like the relevant change is this commit http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.13/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?r1=1618904r2=1618905; Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.13 Reporter: Michael Heuer Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-252) Version 2.13 includes non-source files in checks
[ https://jira.codehaus.org/browse/MCHECKSTYLE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=354322#comment-354322 ] Michael Heuer edited comment on MCHECKSTYLE-252 at 10/13/14 10:19 PM: -- Looks like the relevant change may be this commit http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.13/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?r1=1618904r2=1618905; and similar in the reporting classes. was (Author: heuermh): Looks like the relevant change is this commit http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.13/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?r1=1618904r2=1618905; Version 2.13 includes non-source files in checks Key: MCHECKSTYLE-252 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-252 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.13 Reporter: Michael Heuer Updating maven-checkstyle-plugin to version 2.13 and running $ mvn site now includes non-source files in its checks, e.g. COPYING COPYING.LESSER target/generated-classes/cobertura/cobertura.properties While it is rather amusing to have checkstyle complain that COPYING (the text of the GNU General Public License) doesn't include a license header, it seems that the default source root or one of the other properties new to version 2.13 does not have an appropriate default value. The target directory should also be excluded by default. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
