[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=343081#comment-343081 ] Robert Scholte commented on MRELEASE-431: - http://svn.apache.org/repos/asf/maven/release/trunk/maven-release-policy/src/main/java/org/apache/maven/shared/release/policy/version/ is my start for the implementation. On the dev-list is an active thread about what a VersionPolicy should contain and what not. Any feedback is appreciated. Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: Backlog Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch, MRELEASE-431.patch, MRELEASE-431-v2.patch, MRELEASE-431-v3.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Margulies updated MRELEASE-431: -- Fix Version/s: (was: 2.5) Backlog Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: Backlog Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch, MRELEASE-431.patch, MRELEASE-431-v2.patch, MRELEASE-431-v3.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=332878#comment-332878
]
Robert Scholte commented on MRELEASE-431:
-
It looks like we don't now yet if the arguments are complete. I think we can
expect more arguments. For that reason I'd like to introduce the
{{VersionPolicyRequest}} a simple pojo. This way the signatures of the manager
will always stay the same, we just add fields to this requestobject if we want.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Assignee: Robert Scholte
Fix For: 2.5
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch,
MRELEASE-431.patch, MRELEASE-431-v2.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=332812#comment-332812
]
Robert Scholte commented on MRELEASE-431:
-
[~simonetripodi] asked me to give some feedback. I have some other stuff which
need to be released first.
I still have to decide if we should introduce a separate project for the
versionPolicyManager or include it as a module of the Maven Release project.
Another thing on my mind: should the API support methods to make it a major,
minor or bugversion increase, or leave that up to the implementation ( which
should be verify easy with the {{implementation=}} trick)?
Since we're talking about an API which will stay forever, we need the time to
make the right decisions.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Assignee: Robert Scholte
Fix For: 2.5
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch,
MRELEASE-431.patch, MRELEASE-431-v2.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=332400#comment-332400
]
Robert Munteanu commented on MRELEASE-431:
--
[~rscholte] - I'm not sure what you mean. I was able to test the newly-supplied
odd/even release scheme by:
1. Installing my local copy of the plugin
2. Adding the following to the pom file
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-release-plugin/artifactId
configuration
versionPolicyManager
implementation=org.apache.maven.shared.release.phase.OddEvenVersionPolicyManager/
/configuration
/plugin
{code}
3. Running {{mvn
org.apache.maven.plugins:maven-release-plugin:2.4.2-SNAPSHOT:prepare}}
I've used the expanded g:a:v:goal syntax to avoid declaring snapshot
dependencies on the pom.xml . And for me it works as expected, and matches your
comment #5 about using Plexus configuration.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Assignee: Robert Scholte
Fix For: 2.5
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch,
MRELEASE-431.patch, MRELEASE-431-v2.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=332122#comment-332122
]
Robert Scholte commented on MRELEASE-431:
-
[~rombert], what's still missing is how this is set from the Maven Plugin and
how the chosen implementation is selected.
{code}
/**
* @plexus.requirement
role=org.apache.maven.shared.release.phase.VersionPolicyManager
*/
private MapString, VersionPolicyManager managers;
{code}
With this piece of code, Plexus will collect all available implementations of
{{org.apache.maven.shared.release.phase.VersionPolicyManager}} on the classpath
and will use its hint as the key for this map.
By passing the role-hint of the Manager, you can pick up the preferred
implementation.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Assignee: Robert Scholte
Fix For: 2.5
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch,
MRELEASE-431.patch, MRELEASE-431-v2.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=330241#comment-330241 ] Robert Munteanu commented on MRELEASE-431: -- [~rfscholte] - I _think_ I finally understood what you aimed to get with Plexus configuration. Please see the [^MRELEASE-431-v2.patch], which configures the versionPolicyManager as you asked. You can also see the[diff on github|https://github.com/rombert/release/compare/6de575dd76224c690bfd88375eac88f49ba6d319...HEAD] Let me know if there are any changes you would like applied, as I'm interested in getting this in a release. Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: 2.5 Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch, MRELEASE-431.patch, MRELEASE-431-v2.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated MRELEASE-431: - Attachment: MRELEASE-431-v2.patch Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: 2.5 Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch, MRELEASE-431.patch, MRELEASE-431-v2.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=330241#comment-330241 ] Robert Munteanu edited comment on MRELEASE-431 at 8/7/13 9:13 AM: -- [~rfscholte] - I _think_ I finally understood what you aimed to get with Plexus configuration. Please see the [^MRELEASE-431-v2.patch], which configures the versionPolicyManager as you asked. You can also see the [diff on github|https://github.com/rombert/release/compare/6de575dd76224c690bfd88375eac88f49ba6d319...HEAD] Let me know if there are any changes you would like applied, as I'm interested in getting this in a release. was (Author: rombert): [~rfscholte] - I _think_ I finally understood what you aimed to get with Plexus configuration. Please see the [^MRELEASE-431-v2.patch], which configures the versionPolicyManager as you asked. You can also see the[diff on github|https://github.com/rombert/release/compare/6de575dd76224c690bfd88375eac88f49ba6d319...HEAD] Let me know if there are any changes you would like applied, as I'm interested in getting this in a release. Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: 2.5 Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch, MRELEASE-431.patch, MRELEASE-431-v2.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated MRELEASE-431: - Attachment: MRELEASE-431.patch I've updated the code to make the VersionPolicyManager a plexus component, and it's now injected by plexus into the MapVersionsPhase. However, I don't know where I can override the implementation using Plexus configuration as you suggested, so any hints are appreciated. Besides the updated [^MRELEASE-431.patch], you can also view the [diff on github|https://github.com/rombert/release/compare/6de575dd76224c690bfd88375eac88f49ba6d319...HEAD] Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: 2.5 Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch, MRELEASE-431.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=328897#comment-328897
]
Ziga Gregoric commented on MRELEASE-431:
While trying to stick to http://semver.org for a 'pre-release' as in
{{1.0.0-alpha.1}}, maven would increase it to {{1.0.1-alpha.1}} instead of
{{1.0.0-alpha.2}}.
Since {{1.0.0-alpha1}} is increased to {{1.0.0-alpha2}}, I was hoping we can
have default versioning policy accept notation for 'pre-release' with a dot as
delimiter after alpha/beta/milestone.
MRELEASE-797 is marked as a duplicate, therefore please excuse a non maven
committer if this belongs to a new issue. Thank you.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven 2.x Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MRELEASE-431: Fix Version/s: 2.5 Assignee: Robert Scholte Let's try to fix this for 2.5 Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven 2.x Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Assignee: Robert Scholte Fix For: 2.5 Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated MRELEASE-431: - Attachment: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven 2.x Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=326938#comment-326938 ] Robert Munteanu commented on MRELEASE-431: -- I've attached a patch which adds a 'versionPolicy' property to the plugin. Possible values are 'default' - which is what the plugin does today - and 'odd-even', which ensures that snapshot dependencies are always odd and release versions are always even. You can also review the [commit on github|https://github.com/rombert/release/commit/35e42901868d5c18289e6687bbecdd78cddbf03e] as well. I tried to keep changes minimal and self-contained and also added tests as well as I could. I'm open to iterating on this so please let me know what you think. Thanks! Robert Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven 2.x Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=326943#comment-326943
]
Robert Scholte commented on MRELEASE-431:
-
There are a lot of issues related to version policies. I could try to collect
all wishes, but I'm afraid that I'll forget a few and that in the near future
developers invent more exotic ways of version policies.
To prevent this, we should define a {{VersionPolicyManager}} interface
(probably in the separated {{api}}-project), so everyone can code his own
version. It'll be just a matter of injecting your preferred implementation.
I'm not sure if I should introduce a {{release-api}} project for this or start
a new shared component. With the latter we could also reuse it for the
versions-maven-plugin.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven 2.x Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=326956#comment-326956 ] Robert Munteanu commented on MRELEASE-431: -- Right, so I'll create a VersionPolicyManager interface, and I can look it up based on the configured versionPolicy parameter. What I'm not sure is how to actually provide and look up implementations for this interface, since I'm not familiar with Maven component wiring. Where can I find the docs or a working example? And for now I can add a release-api project to the release reactor, and you can decide whether to move it to a shared component later, since it would be more difficult for me, not being a Maven committer. WDYT? Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven 2.x Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Attachments: 0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[
https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=326957#comment-326957
]
Robert Scholte commented on MRELEASE-431:
-
There are at least two options:
- through Plexus Components ( example is [Maven Compiler
Plugin|http://maven.apache.org/plugins/maven-compiler-plugin/xref/org/apache/maven/plugin/compiler/AbstractCompilerMojo.html#420]
where you can choose a compiler by its id. Implementations are marked as a
Component and can be chosen by the hint.
- through Plexus Configuration. I couldn't find a good example, but it should
be something like this:
{code:xml}
configuration
versionPolicyManager
implementation=com.acme.custom.MyVersionPolicyManager
/versionPolicyManager
/configuration
{code}
The advantage of the latter is that it is very straightforward if you want to
use additional fields/setters on your VersionPolicyManager. For that reason
this would be my choice right now.
Configuration of policy for calculating next (release) version
--
Key: MRELEASE-431
URL: https://jira.codehaus.org/browse/MRELEASE-431
Project: Maven 2.x Release Plugin
Issue Type: New Feature
Components: prepare
Affects Versions: 2.0-beta-8
Reporter: Carsten Ziegeler
Attachments:
0001-MRELEASE-431-Configuration-of-policy-for-calculating.patch
Currently, when preparing the release, the version to release is always the
next version which usually is the current version without the snapshot
extension.
There are quiet a lot projects (Apache Felix, Sling and others) following an
even release numbering policy. So while the current development version is
odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4.
It would be nice if this could be made configuration through some
configuration property like
versionPolicynext-even/versionPolicy (with possible values being: next
(default, as-is), next-even, next-odd
I briefly scanned through the code and it seems that adding support for this
requires changes in both, the release-manager and the release-plugin.
If this feature gets accepted and if someone could give me some minor hints
how/where to add this I could come up with a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-431) Configuration of policy for calculating next (release) version
[ https://jira.codehaus.org/browse/MRELEASE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=323329#comment-323329 ] Andrei Pozolotin commented on MRELEASE-431: --- maven should implement semantic versioning in the core http://www.osgi.org/wiki/uploads/Links/SemanticVersioning.pdf some plugins which are doing this: https://github.com/apache/aries/tree/trunk/versioning https://github.com/jeluard/semantic-versioning Configuration of policy for calculating next (release) version -- Key: MRELEASE-431 URL: https://jira.codehaus.org/browse/MRELEASE-431 Project: Maven 2.x Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 2.0-beta-8 Reporter: Carsten Ziegeler Currently, when preparing the release, the version to release is always the next version which usually is the current version without the snapshot extension. There are quiet a lot projects (Apache Felix, Sling and others) following an even release numbering policy. So while the current development version is odd (like 1.2.3-SNAPSHOT), the next released version will be 1.2.4. It would be nice if this could be made configuration through some configuration property like versionPolicynext-even/versionPolicy (with possible values being: next (default, as-is), next-even, next-odd I briefly scanned through the code and it seems that adding support for this requires changes in both, the release-manager and the release-plugin. If this feature gets accepted and if someone could give me some minor hints how/where to add this I could come up with a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
