[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MRELEASE-798: Labels: github-pullrequest (was: ) > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > Labels: github-pullrequest > Attachments: maven-release-2.4.1-additionalCommitted.patch > > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334338#comment-334338 ] Robert Scholte commented on MRELEASE-798: - Since it's a workaround I'm not going to accept the pullrequest, because these Maven plugins must stay backwards compatible. There's no such thing as a temporary workaround, but users are free to use your fork of course. I haven't collected all the requirements, but I think your idea is indeed a good start. Very clever to think of the rollback as well. > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > Attachments: maven-release-2.4.1-additionalCommitted.patch > > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334275#comment-334275 ] Emilio Jose Mena Cebrian commented on MRELEASE-798: --- I know it, but it's a workaround until your solution is available. I had to implement it for my company and i thought it might help Thorsten Hoeger A better solution might be to have a extension point to modify files and add them to the commit as you said. So a "ModifyFilesForDevelopmentPhase" runs every extension to modify files and "register" changes to a "ChangedFilesManager" That ChangedFilesManager might save previous version of modified files in case you have to restore them (e.g.: a rollback) So RewritePomsFor*Phase classes might be a implementation of this extension and ScmCommit*Phase classes might commit only files registered in "ChangedFilesManager" and not only poms. What do you think about it? > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > Attachments: maven-release-2.4.1-additionalCommitted.patch > > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[
https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334267#comment-334267
]
Robert Scholte commented on MRELEASE-798:
-
See one of my previous comments: the solution should *not* be something like
{{additionalCommitFiles}}, but some sort of extension where you can manipulate
files. {{changelog}} is a good example, still looking for more.
> Commit additional files with release plugin
> ---
>
> Key: MRELEASE-798
> URL: https://jira.codehaus.org/browse/MRELEASE-798
> Project: Maven Release Plugin
> Issue Type: Improvement
> Components: prepare, scm
>Affects Versions: 2.3.2
>Reporter: Thorsten Hoeger
> Attachments: maven-release-2.4.1-additionalCommitted.patch
>
>
> Hi,
> is there any possibility to have the release-plugin commit additional files
> which were
> generated/modified in the preparationGoals.
> Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks
> in this
> situation.
> If it is not possible at the moment, is there any chance to get this in the
> future. Maybe
> there could be a parameter additionalCommitFiles with a list of files to
> commit along with
> pom.xml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334264#comment-334264 ] Emilio Jose Mena Cebrian commented on MRELEASE-798: --- Added a pull request @ GitHub > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > Attachments: maven-release-2.4.1-additionalCommitted.patch > > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334249#comment-334249 ] Emilio Jose Mena Cebrian edited comment on MRELEASE-798 at 10/16/13 9:47 AM: - I've done a patch to version 2.4.1 to implement that using a property additionalCommittedIncludeList I've attached the patch file. I can generate a patch for the trunk if it's necessary was (Author: emenaceb): I've done a patch to version 2.4.1 to implement that using a property additionalCommittedIncludeList I've attached the patch file. > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > Attachments: maven-release-2.4.1-additionalCommitted.patch > > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emilio Jose Mena Cebrian updated MRELEASE-798: -- Attachment: maven-release-2.4.1-additionalCommitted.patch Patch to add files to commit additional files using a file filter > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > Attachments: maven-release-2.4.1-additionalCommitted.patch > > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334249#comment-334249 ] Emilio Jose Mena Cebrian commented on MRELEASE-798: --- I've done a patch to version 2.4.1 to implement that using a property additionalCommittedIncludeList I've attached the patch file. > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317561#comment-317561 ] Robert Scholte commented on MRELEASE-798: - Not yet > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven 2.x Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317537#comment-317537 ] Thorsten Hoeger commented on MRELEASE-798: -- Hi, is there any progress planned? > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven 2.x Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[
https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316102#comment-316102
]
Robert Scholte commented on MRELEASE-798:
-
Ok, so it's related to MRELEASE-51, but I don't think I'll implement it as
{{additionalCommitFiles}}. One idea I have is to add some kind of extension,
which the {{release-plugin}} will call with specific release properties. That
could return a set of files which should be added to the release.
> Commit additional files with release plugin
> ---
>
> Key: MRELEASE-798
> URL: https://jira.codehaus.org/browse/MRELEASE-798
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Components: prepare, scm
>Affects Versions: 2.3.2
>Reporter: Thorsten Hoeger
>
> Hi,
> is there any possibility to have the release-plugin commit additional files
> which were
> generated/modified in the preparationGoals.
> Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks
> in this
> situation.
> If it is not possible at the moment, is there any chance to get this in the
> future. Maybe
> there could be a parameter additionalCommitFiles with a list of files to
> commit along with
> pom.xml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316059#comment-316059 ] Thorsten Hoeger commented on MRELEASE-798: -- In my current use case, I generate the changelog in the preparationGoals section. Now it would be nice if this changelog file would be commited to scm. > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven 2.x Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[
https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315966#comment-315966
]
Robert Scholte commented on MRELEASE-798:
-
What do you mean with "generated/modified"? Do you have concrete examples?
Somehow I expect some impact, but that should be exposed when running the
{{release:perform}}.
Providing patches increases the chance to get issues resolved, especially if
they contain tests.
> Commit additional files with release plugin
> ---
>
> Key: MRELEASE-798
> URL: https://jira.codehaus.org/browse/MRELEASE-798
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Components: prepare, scm
>Affects Versions: 2.3.2
>Reporter: Thorsten Hoeger
>
> Hi,
> is there any possibility to have the release-plugin commit additional files
> which were
> generated/modified in the preparationGoals.
> Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks
> in this
> situation.
> If it is not possible at the moment, is there any chance to get this in the
> future. Maybe
> there could be a parameter additionalCommitFiles with a list of files to
> commit along with
> pom.xml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
[ https://jira.codehaus.org/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315905#comment-315905 ] Thorsten Hoeger commented on MRELEASE-798: -- As 2.4 was announced I want to ask again if this will be implemented in the future. > Commit additional files with release plugin > --- > > Key: MRELEASE-798 > URL: https://jira.codehaus.org/browse/MRELEASE-798 > Project: Maven 2.x Release Plugin > Issue Type: Improvement > Components: prepare, scm >Affects Versions: 2.3.2 >Reporter: Thorsten Hoeger > > Hi, > is there any possibility to have the release-plugin commit additional files > which were > generated/modified in the preparationGoals. > Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks > in this > situation. > If it is not possible at the moment, is there any chance to get this in the > future. Maybe > there could be a parameter additionalCommitFiles with a list of files to > commit along with > pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-798) Commit additional files with release plugin
Thorsten Hoeger created MRELEASE-798: Summary: Commit additional files with release plugin Key: MRELEASE-798 URL: https://jira.codehaus.org/browse/MRELEASE-798 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare, scm Affects Versions: 2.3.2 Reporter: Thorsten Hoeger Hi, is there any possibility to have the release-plugin commit additional files which were generated/modified in the preparationGoals. Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks in this situation. If it is not possible at the moment, is there any chance to get this in the future. Maybe there could be a parameter additionalCommitFiles with a list of files to commit along with pom.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
