[jira] (MSHADE-167) [PATCH] When individual classes are renamed, they are not debuggable

2014-04-25 Thread John Casey (JIRA) 

 [ 
https://jira.codehaus.org/browse/MSHADE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Casey closed MSHADE-167.
-

   Resolution: Fixed
Fix Version/s: 2.3
 Assignee: John Casey

Applied with small modifications to new unit test code to adjust to ASM 5 apis.

 [PATCH] When individual classes are renamed, they are not debuggable
 

 Key: MSHADE-167
 URL: https://jira.codehaus.org/browse/MSHADE-167
 Project: Maven Shade Plugin
  Issue Type: Improvement
Affects Versions: 2.2
Reporter: Matt Benson
Assignee: John Casey
 Fix For: 2.3

 Attachments: shade-srcfile.patch.txt


 One can rename a given class using, e.g.:
 {code}
 relocation
   patterncom.example.foo./pattern
   shadedPatterncom.uber._foo.__/shadedPattern
 /relocation
 {code}
 Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
 {{com.uber.\_foo.\_\_Bar}} and this is fine. If the source jar is generated, 
 the {{.java}} file will be moved accordingly. The proposed patch changes the 
 source information in the relocated class to use the new basename of the Java 
 source file, making it possible to debug again. My Apache ICLA is on file, 
 rights are granted, and a test of the functionality is included.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

[jira] (MSHADE-167) [PATCH] When individual classes are renamed, they are not debuggable

2014-04-04 Thread Matt Benson (JIRA) 

 [ 
https://jira.codehaus.org/browse/MSHADE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson updated MSHADE-167:
---

Description: 
you are correct, George, in thatOne can rename a given class using, e.g.:
{code}
relocation
  patterncom.example.foo./pattern
  shadedPatterncom.uber._foo.__/shadedPattern
/relocation
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
{{com.uber.\_foo.\_\_Bar}} and this is fine. If the source jar is generated, 
the {{.java}} file will be moved accordingly. The proposed patch changes the 
source information in the relocated class to use the new basename of the Java 
source file, making it possible to debug again. My Apache ICLA is on file, 
rights are granted, and a test of the functionality is included. 

  was:
One can rename a given class using, e.g.:
{code}
relocation
  patterncom.example.foo./pattern
  shadedPatterncom.uber._foo.__/shadedPattern
/relocation
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
{{com.uber._foo.__Bar}} and this is fine. If the source jar is generated, the 
{{.java}} file will be moved accordingly. The proposed patch changes the source 
information in the relocated class to use the new basename of the Java source 
file, making it possible to debug again. My Apache ICLA is on file, rights are 
granted, and a test of the functionality is included. 


 [PATCH] When individual classes are renamed, they are not debuggable
 

 Key: MSHADE-167
 URL: https://jira.codehaus.org/browse/MSHADE-167
 Project: Maven Shade Plugin
  Issue Type: Improvement
Affects Versions: 2.2
Reporter: Matt Benson
 Attachments: shade-srcfile.patch.txt


 you are correct, George, in thatOne can rename a given class using, e.g.:
 {code}
 relocation
   patterncom.example.foo./pattern
   shadedPatterncom.uber._foo.__/shadedPattern
 /relocation
 {code}
 Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
 {{com.uber.\_foo.\_\_Bar}} and this is fine. If the source jar is generated, 
 the {{.java}} file will be moved accordingly. The proposed patch changes the 
 source information in the relocated class to use the new basename of the Java 
 source file, making it possible to debug again. My Apache ICLA is on file, 
 rights are granted, and a test of the functionality is included. 



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

[jira] (MSHADE-167) [PATCH] When individual classes are renamed, they are not debuggable

2014-04-04 Thread Matt Benson (JIRA) 

 [ 
https://jira.codehaus.org/browse/MSHADE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson updated MSHADE-167:
---

Description: 
One can rename a given class using, e.g.:
{code}
relocation
  patterncom.example.foo./pattern
  shadedPatterncom.uber._foo.__/shadedPattern
/relocation
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
{{com.uber.\_foo.\_\_Bar}} and this is fine. If the source jar is generated, 
the {{.java}} file will be moved accordingly. The proposed patch changes the 
source information in the relocated class to use the new basename of the Java 
source file, making it possible to debug again. My Apache ICLA is on file, 
rights are granted, and a test of the functionality is included.

  was:
you are correct, George, in thatOne can rename a given class using, e.g.:
{code}
relocation
  patterncom.example.foo./pattern
  shadedPatterncom.uber._foo.__/shadedPattern
/relocation
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
{{com.uber.\_foo.\_\_Bar}} and this is fine. If the source jar is generated, 
the {{.java}} file will be moved accordingly. The proposed patch changes the 
source information in the relocated class to use the new basename of the Java 
source file, making it possible to debug again. My Apache ICLA is on file, 
rights are granted, and a test of the functionality is included. 


 [PATCH] When individual classes are renamed, they are not debuggable
 

 Key: MSHADE-167
 URL: https://jira.codehaus.org/browse/MSHADE-167
 Project: Maven Shade Plugin
  Issue Type: Improvement
Affects Versions: 2.2
Reporter: Matt Benson
 Attachments: shade-srcfile.patch.txt


 One can rename a given class using, e.g.:
 {code}
 relocation
   patterncom.example.foo./pattern
   shadedPatterncom.uber._foo.__/shadedPattern
 /relocation
 {code}
 Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
 {{com.uber.\_foo.\_\_Bar}} and this is fine. If the source jar is generated, 
 the {{.java}} file will be moved accordingly. The proposed patch changes the 
 source information in the relocated class to use the new basename of the Java 
 source file, making it possible to debug again. My Apache ICLA is on file, 
 rights are granted, and a test of the functionality is included.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

[jira] (MSHADE-167) [PATCH] When individual classes are renamed, they are not debuggable

2014-04-02 Thread Matt Benson (JIRA) 
Matt Benson created MSHADE-167:
--

 Summary: [PATCH] When individual classes are renamed, they are not 
debuggable
 Key: MSHADE-167
 URL: https://jira.codehaus.org/browse/MSHADE-167
 Project: Maven Shade Plugin
  Issue Type: Improvement
Affects Versions: 2.2
Reporter: Matt Benson
 Attachments: shade-srcfile.patch.txt

One can rename a given class using, e.g.:
{code}
relocation
  patterncom.example.foo./pattern
  shadedPatterncom.uber._foo.__/shadedPattern
/relocation
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to 
{{com.uber._foo.__Bar}} and this is fine. If the source jar is generated, the 
{{.java}} file will be moved accordingly. The proposed patch changes the source 
information in the relocated class to use the new basename of the Java source 
file, making it possible to debug again. My Apache ICLA is on file, rights are 
granted, and a test of the functionality is included. 



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)