[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Tibor Digana (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1024:
---

Priority: Minor  (was: Major)

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
>Priority: Minor
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Tibor Digana (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=366018#comment-366018
 ] 

Tibor Digana commented on SUREFIRE-1024:


For me this is minor, but you can have a look in our code in GitHub and fix it 
in PR.
Other way you may open PR pointing to the error line and we will evaluate 
complexity for this fix.
If it's simple, the fix can be done in the release 2.19.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=366007#comment-366007
 ] 

Sebastian Paul commented on SUREFIRE-1024:
--

For the usual unit and integration tests, you are absolutely right. But in my 
concrete case, the test is not in my ownership. That special test run applies 
aspects with load time weaving, in order to gather data for further analysis. 
Maybe the use case is too special for Surefire, but the dependenciesToScan 
option is there. And in my opinion, verify should not claim that no tests ran, 
when integration-test actually did run tests.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Tibor Digana (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=366002#comment-366002
 ] 

Tibor Digana commented on SUREFIRE-1024:


ok, but then it's wrong modularity design, because you should test the project, 
test the project, and build the site in current project. Not to run tests of P1 
in P2 and generate site of P1 in P2.
That's not the goal of Maven.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365998#comment-365998
 ] 

Sebastian Paul commented on SUREFIRE-1024:
--

I am using the POM packaging, because I just want to run tests from an existing 
JAR, and generate a site for the results. The project itself should not compile 
anything, so the JAR packaging seems not appropriate.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Tibor Digana (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365997#comment-365997
 ] 

Tibor Digana commented on SUREFIRE-1024:


But that's expected actually because the POM packaging does not expect any 
sources. I would say that's the basics of the Maven itself.
Notice that POM packaging is an aggregator project which has  to 
execute children, or declaration dependencyManagement without modules section 
like BOM files use to be - without any source of course.
Any thoughts?

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-02 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365994#comment-365994
 ] 

Sebastian Paul commented on SUREFIRE-1024:
--

Tibor, I was able to reproduce the problem with your provided project, after I 
changed packaging to *POM*.

{code}
[INFO] Scanning for projects...
[INFO]
[INFO] 
[INFO] Building pokus 1.0-SNAPSHOT
[INFO] 
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ pokus ---
[INFO] Deleting D:\Dev\sc\workspace\surefire-1024-works-for-me\project\target
[INFO]
[INFO] --- maven-failsafe-plugin:2.18.1:integration-test (integration-test) @ 
pokus ---
[INFO] Failsafe report directory: 
D:\Dev\sc\workspace\surefire-1024-works-for-me\project\target\failsafe-reports

---
 T E S T S
---
Running a1.A1IT
class a1.A1IT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.01 sec - in 
a1.A1IT

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[WARNING] File encoding has not been set, using platform encoding Cp1252, i.e. 
build is platform dependent! The
 provided by the POM property ${project.reporting.outputEncoding}.
[INFO]
[INFO] --- maven-failsafe-plugin:2.18.1:verify (verify) @ pokus ---
[INFO] No tests to run.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 11.960 s
[INFO] Finished at: 2015-04-02T10:45:24+02:00
[INFO] Final Memory: 8M/155M
[INFO] 
{code}

Verify claims, there were no tests to run.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-01 Thread Tibor Digana (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365975#comment-365975
 ] 

Tibor Digana commented on SUREFIRE-1024:


@Sebastian
I have attached a ZIP which still is not able to reproduce this issue. There is 
a project and .m2/repository.
Run mvn verify or mvn install on your side.
I am using failsafe 2.18.1. Isn't your version different?

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-01 Thread Tibor Digana (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1024:
---

Attachment: surefire-1024-works-for-me.zip

a test with 2.18.1 which is not able to reproduce this issue

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: surefire-1024-works-for-me.zip, 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-01 Thread Tibor Digana (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365965#comment-365965
 ] 

Tibor Digana commented on SUREFIRE-1024:


@Sebastian
The class AbstractSurefireMojo.java handles the executions differently from 
defaul execution.
You may have a look in GitHub https://github.com/apache/maven-surefire and fix 
it in new pull request.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-01 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365931#comment-365931
 ] 

Sebastian Paul edited comment on SUREFIRE-1024 at 4/1/15 2:51 AM:
--

I have that problem with JUnit, i.e. it is independent from the provider.
At a first sight, I see a similarity between my POM and and that one in the 
description above: 
integration-test and verify are in separate executions
In Tibors POM, they are in one single execution.
I can imagine that this is the cause.
My build depends on separate executions, as I need to bind the goals to 
different phases than the default,


was (Author: sebpaul):
I have that problem with JUnit, i.e. it is independent from the provider.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-04-01 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365931#comment-365931
 ] 

Sebastian Paul commented on SUREFIRE-1024:
--

I have that problem with JUnit, i.e. it is independent from the provider.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-03-31 Thread Tibor Digana (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365922#comment-365922
 ] 

Tibor Digana commented on SUREFIRE-1024:


Works For Me with JUnit.
Shouldn't be the same for TestNG?

{code}
  

  junit
  junit
  4.12
  test


  g
  a1
  1.0


  g
  a2
  1.0

  

  

  
maven-failsafe-plugin
2.18.1

  
it

  integration-test
  verify

  


  all
  true
  
g:a1
  

  

  
{code}

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-03-31 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365894#comment-365894
 ] 

Sebastian Paul edited comment on SUREFIRE-1024 at 3/31/15 3:12 AM:
---

For the impatient, simply unpack the tests as workaround:

{code:xml|title=pom.xml}



org.apache.maven.plugins
maven-dependency-plugin
2.10


unpack-tests

unpack-dependencies



tests-jar

**/IT*.class,**/*IT.class,**/*ITCase.class

${project.build.testOutputDirectory}




{code}


was (Author: sebpaul):
For the unpatient, simply unpack the tests as workaround:

{code:xml|title=pom.xml}



org.apache.maven.plugins
maven-dependency-plugin
2.10


unpack-tests

unpack-dependencies



tests-jar

**/IT*.class,**/*IT.class,**/*ITCase.class

${project.build.testOutputDirectory}




{code}

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-03-31 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365894#comment-365894
 ] 

Sebastian Paul edited comment on SUREFIRE-1024 at 3/31/15 3:11 AM:
---

For the unpatient, simply unpack the tests as workaround:

{code:xml|title=pom.xml}



org.apache.maven.plugins
maven-dependency-plugin
2.10


unpack-tests

unpack-dependencies



tests-jar

**/IT*.class,**/*IT.class,**/*ITCase.class

${project.build.testOutputDirectory}




{code}


was (Author: sebpaul):
For the unpatient, simply unpack the tests as workaround:

{code:title=pom.xml}



org.apache.maven.plugins
maven-dependency-plugin
2.10


unpack-tests

unpack-dependencies



tests-jar

**/IT*.class,**/*IT.class,**/*ITCase.class

${project.build.testOutputDirectory}




{code}

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2015-03-31 Thread Sebastian Paul (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=365894#comment-365894
 ] 

Sebastian Paul commented on SUREFIRE-1024:
--

For the unpatient, simply unpack the tests as workaround:

{code:title=pom.xml}



org.apache.maven.plugins
maven-dependency-plugin
2.10


unpack-tests

unpack-dependencies



tests-jar

**/IT*.class,**/*IT.class,**/*ITCase.class

${project.build.testOutputDirectory}




{code}

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2014-09-25 Thread Andreas Gudian (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Gudian updated SUREFIRE-1024:
-

Fix Version/s: (was: 2.18)
   3.0

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 3.0
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2014-03-08 Thread Andreas Gudian (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=342605#comment-342605
 ] 

Andreas Gudian commented on SUREFIRE-1024:
--

Sorry, I have to push that one back one version, as I didn't have time to dig 
into your patch, yet.

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 2.18
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2014-03-08 Thread Andreas Gudian (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Gudian updated SUREFIRE-1024:
-

Fix Version/s: (was: 2.17)
   2.18

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 2.18
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2013-08-31 Thread Andreas Gudian (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Gudian updated SUREFIRE-1024:
-

Fix Version/s: 2.17

> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.16
>Reporter: Dmitry Kholodilov
> Fix For: 2.17
>
> Attachments: 
> verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch
>
>
> Consider Maven project with packaging=pom that executes tests from some 
> external jar:
> {code:xml}
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> test
> pom
> 
> 
> test
> tests-jar
> 1.0
> tests
> 
> 
> org.testng
> testng
> 6.8
> 
> 
> 
> 
> 
> maven-failsafe-plugin
> 2.17-SNAPSHOT
> 
> 
> test:tests-jar
> 
> 
> 
> 
> integration-test
> integration-test
> 
> integration-test
> 
> 
> 
> verify
> verify
> 
> verify
> 
> 
> 
> 
> 
> 
> 
> {code}
> (real use case is execution of prebuilt end-to-end tests of some system after 
> its deployment)
> When we run `mvn clean verify` on such project, failsafe plugin's "verify" 
> goal reports the following:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
> [INFO] No tests to run.
> {noformat}
> Consequently, even if there are test failures, build success is reported.
> The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
> parameter. So, the fix is easy - check its existence along with 
> "testClassesDirectory" existence, the same way as implemented in 
> AbstractSurefireMojo.
> The patch in attachment includes integration test that checks for build 
> failure when there is failed test from dependency jar.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2013-08-26 Thread Dmitry Kholodilov (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Kholodilov updated SUREFIRE-1024:


Description: 
Consider Maven project with packaging=pom that executes tests from some 
external jar:

{code:xml}
http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
test
test
pom


test
tests-jar
1.0
tests


org.testng
testng
6.8






maven-failsafe-plugin
2.17-SNAPSHOT


test:tests-jar




integration-test
integration-test

integration-test



verify
verify

verify







{code}
(real use case is execution of prebuilt end-to-end tests of some system after 
its deployment)

When we run `mvn clean verify` on such project, failsafe plugin's "verify" goal 
reports the following:
{noformat}
[INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
[INFO] No tests to run.
{noformat}
Consequently, even if there are test failures, build success is reported.

The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
parameter. So, the fix is easy - check its existence along with 
"testClassesDirectory" existence, the same way as implemented in 
AbstractSurefireMojo.

The patch in attachment includes integration test that checks for build failure 
when there is failed test from dependency jar.


  was:
Consider Maven project with packaging=pom that executes tests from some 
external jar:

{code:xml}
http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
test
test
pom


test
tests-jar
1.0
tests


org.testng
testng
6.8






maven-failsafe-plugin
2.17-SNAPSHOT


test:tests-jar




integration-test
integration-test

integration-test



verify
verify

verify







{code}
(real use case is execution of prebuilt end-to-end tests of some system after 
its deployment)

When we run `mvn clean verify` on such project, failsafe plugin's "verify" goal 
reports the following:
{noformat}
[INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
[INFO] No tests to run.
{noformat}
Consequently, even if there are test failures, build success is reported.

The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
parameter. So, the fix is easy - check its existence along with 
"testClassesDirectory" existence, the same way as implemented in 
AbstractSurefireMojo.

The patch in attachment includes integration test, that checks for build 
failure when there is failed test in dependency jar.



> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versio

[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2013-08-26 Thread Dmitry Kholodilov (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Kholodilov updated SUREFIRE-1024:


Description: 
Consider Maven project with packaging=pom that executes tests from some 
external jar:

{code:xml}
http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
test
test
pom


test
tests-jar
1.0
tests


org.testng
testng
6.8






maven-failsafe-plugin
2.17-SNAPSHOT


test:tests-jar




integration-test
integration-test

integration-test



verify
verify

verify







{code}
(real use case is execution of prebuilt end-to-end tests of some system after 
its deployment)

When we run `mvn clean verify` on such project, failsafe plugin's "verify" goal 
reports the following:
{noformat}
[INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
[INFO] No tests to run.
{noformat}
Consequently, even if there are test failures, build success is reported.

The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
parameter. So, the fix is easy - check its existence along with 
"testClassesDirectory" existence, the same way as implemented in 
AbstractSurefireMojo.

The patch in attachment includes integration test, that checks for build 
failure when there is failed test in dependency jar.


  was:
Consider Maven project with packaging=pom that executes tests from some 
external jar:

{code:xml}
http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
test
test
pom


test
tests-jar
1.0
tests


org.testng
testng
6.8






maven-failsafe-plugin
2.17-SNAPSHOT


test:tests-jar




integration-test
integration-test

integration-test



verify
verify

verify







{code}e
(real use case is execution of prebuilt end-to-end tests of some system after 
its deployment)

When we run `mvn clean verify` on such project, failsafe plugin's "verify" goal 
reports the following:
{noformat}
[INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
[INFO] No tests to run.
{noformat}
Consequently, even if there are test failures, build success is reported.

The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
parameter. So, the fix is easy - check its existence along with 
"testClassesDirectory" existence, the same way as implemented in 
AbstractSurefireMojo.

The patch in attachment includes integration test, that checks for build 
failure when there is failed test in dependency jar.



> "verify" goal ignores "dependenciesToScan" parameter when checking tests 
> existence
> --
>
> Key: SUREFIRE-1024
> URL: https://jira.codehaus.org/browse/SUREFIRE-1024
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versio

[jira] (SUREFIRE-1024) "verify" goal ignores "dependenciesToScan" parameter when checking tests existence

2013-08-26 Thread Dmitry Kholodilov (JIRA)
Dmitry Kholodilov created SUREFIRE-1024:
---

 Summary: "verify" goal ignores "dependenciesToScan" parameter when 
checking tests existence
 Key: SUREFIRE-1024
 URL: https://jira.codehaus.org/browse/SUREFIRE-1024
 Project: Maven Surefire
  Issue Type: Bug
  Components: Maven Failsafe Plugin
Affects Versions: 2.16
Reporter: Dmitry Kholodilov
 Attachments: 
verify_goal_ignores_dependenciesToScan_parameter_when_checking_tests_existence.patch

Consider Maven project with packaging=pom that executes tests from some 
external jar:

{code:xml}
http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
test
test
test
pom


test
tests-jar
1.0
tests


org.testng
testng
6.8






maven-failsafe-plugin
2.17-SNAPSHOT


test:tests-jar




integration-test
integration-test

integration-test



verify
verify

verify







{code}e
(real use case is execution of prebuilt end-to-end tests of some system after 
its deployment)

When we run `mvn clean verify` on such project, failsafe plugin's "verify" goal 
reports the following:
{noformat}
[INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ test ---
[INFO] No tests to run.
{noformat}
Consequently, even if there are test failures, build success is reported.

The reason of such behavior is that VerifyMojo ignores "dependenciesToScan" 
parameter. So, the fix is easy - check its existence along with 
"testClassesDirectory" existence, the same way as implemented in 
AbstractSurefireMojo.

The patch in attachment includes integration test, that checks for build 
failure when there is failed test in dependency jar.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira