[jira] (SUREFIRE-883) Cannot run tests in parallel

2012-07-05 Thread Steve Stogner (JIRA)
Steve Stogner created SUREFIRE-883:
--

 Summary: Cannot run tests in parallel
 Key: SUREFIRE-883
 URL: https://jira.codehaus.org/browse/SUREFIRE-883
 Project: Maven Surefire
  Issue Type: Bug
  Components: Junit 4.7+ (parallel) support
Affects Versions: 2.12
Reporter: Steve Stogner
Priority: Minor


Revision 1228960 seems to break parallel tests.
See ConfigurableParallelComputer.java.
before: Call to super.getRunner returns a ParentRunner that 
ConfigurableParallelComputer.getRunner passes directly to parallelize
after: Call to super.getRunner returns a ParentRunner, but 
ConfigurableParallelComputer.getRunner wraps that ParentRunner in a 
ClassDemarcatingRunner which it then passes to parallelize
problem: Parallelize calls setScheduler (and therefore parallelizes the tests) 
only for ParentRunners.  Since the ParentRunner of interest is wrapped inside 
the ClassDemarcatingRunner, which is not a ParentRunner, parallelize does not 
call setScheduler.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (SUREFIRE-883) Cannot run tests in parallel

2012-07-06 Thread Kristian Rosenvold (JIRA)

[ 
https://jira.codehaus.org/browse/SUREFIRE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=302926#comment-302926
 ] 

Kristian Rosenvold commented on SUREFIRE-883:
-

Just some notes:

Using surefire-integration-tests/src/test/resources/parallel-runtime (added in 
r1358285)

mvn -o -Dsurefire.version=2.11 -DthreadCount=4 -Dparallel=methods test


2.11 gives runtime ~19sec, 2.12 gives 1min 04 secs

Switching to "classes" gives runtime of ~24.26 with both 2.11 and 2.12. So it 
seems "methods" was broken with this change.


> Cannot run tests in parallel
> 
>
> Key: SUREFIRE-883
> URL: https://jira.codehaus.org/browse/SUREFIRE-883
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.12
>Reporter: Steve Stogner
>Priority: Minor
>
> Revision 1228960 seems to break parallel tests.
> See ConfigurableParallelComputer.java.
> before: Call to super.getRunner returns a ParentRunner that 
> ConfigurableParallelComputer.getRunner passes directly to parallelize
> after: Call to super.getRunner returns a ParentRunner, but 
> ConfigurableParallelComputer.getRunner wraps that ParentRunner in a 
> ClassDemarcatingRunner which it then passes to parallelize
> problem: Parallelize calls setScheduler (and therefore parallelizes the 
> tests) only for ParentRunners.  Since the ParentRunner of interest is wrapped 
> inside the ClassDemarcatingRunner, which is not a ParentRunner, parallelize 
> does not call setScheduler.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] (SUREFIRE-883) Cannot run tests in parallel

2012-07-08 Thread Kristian Rosenvold (JIRA)

 [ 
https://jira.codehaus.org/browse/SUREFIRE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kristian Rosenvold closed SUREFIRE-883.
---

   Resolution: Fixed
Fix Version/s: 2.13
 Assignee: Kristian Rosenvold

Removed the ClassDemarcatingRunner when running parallel=methods in r1358826

> Cannot run tests in parallel
> 
>
> Key: SUREFIRE-883
> URL: https://jira.codehaus.org/browse/SUREFIRE-883
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Junit 4.7+ (parallel) support
>Affects Versions: 2.12
>Reporter: Steve Stogner
>Assignee: Kristian Rosenvold
>Priority: Minor
> Fix For: 2.13
>
>
> Revision 1228960 seems to break parallel tests.
> See ConfigurableParallelComputer.java.
> before: Call to super.getRunner returns a ParentRunner that 
> ConfigurableParallelComputer.getRunner passes directly to parallelize
> after: Call to super.getRunner returns a ParentRunner, but 
> ConfigurableParallelComputer.getRunner wraps that ParentRunner in a 
> ClassDemarcatingRunner which it then passes to parallelize
> problem: Parallelize calls setScheduler (and therefore parallelizes the 
> tests) only for ParentRunners.  Since the ParentRunner of interest is wrapped 
> inside the ClassDemarcatingRunner, which is not a ParentRunner, parallelize 
> does not call setScheduler.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira