[
https://issues.apache.org/jira/browse/MSHADE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MSHADE-313.
---------------------------------
Resolution: Fixed
Assignee: Robert Scholte
Fix Version/s: 3.2.2
Fixed in
[8278c9f28d94f8af6d98655b3db7bd295b9785aa|https://gitbox.apache.org/repos/asf?p=maven-shade-plugin.git;a=commit;h=8278c9f28d94f8af6d98655b3db7bd295b9785aa]
Thanks for the patch!
> Minimize jar should respect implementations under /META-INF/services/
> ---------------------------------------------------------------------
>
> Key: MSHADE-313
> URL: https://issues.apache.org/jira/browse/MSHADE-313
> Project: Maven Shade Plugin
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Markus Karg
> Assignee: Robert Scholte
> Priority: Major
> Fix For: 3.2.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The maven shade plugin already does a great job in minimizing JAR size. For
> the majority of applications this is exactly what is needed.
> On the other hand there are some application areas where the algorithm is too
> agressive. One particular and rather frequently found case is the services
> API: ServiceLoader will ceise to work for minimized JARs since it is the
> prototype of the biggest "minimize-JAR-antipattern": String-to-class
> conversion.
> To make <minimizeJar> usable in such scenarios, there should be a set of
> options to enable the usual suspetcs (like ServiceLoader) to be detected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
