[ https://issues.apache.org/jira/browse/MSHARED-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Heinz Marbaise closed MSHARED-655. --------------------------------------- Resolution: Fixed Assignee: Karl Heinz Marbaise Done in * https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=0d689e8a324b9b6c9f45d8e474cb4c5c573ee0f7 * https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=588b19dfd6f9985a7ce0a9ab27cf53304c6e4fb5 * https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=3cf02b285ab334b7ed86bda94fe005b0813cf144 * https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=cfc1b72fc846cbcc956f3be97f7842aa315f001a > ArtifactInstaller check for integrity of parameters null, empty collection, > being a directory > --------------------------------------------------------------------------------------------- > > Key: MSHARED-655 > URL: https://issues.apache.org/jira/browse/MSHARED-655 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer > Affects Versions: maven-artifact-transfer-0.9.1 > Reporter: Karl Heinz Marbaise > Assignee: Karl Heinz Marbaise > Priority: Minor > Fix For: maven-artifact-transfer-1.0.0 > > > Currently the interface {{ArtifactInstaller}} contains the two methods: > {code:java} > public interface ArtifactInstaller > { > void install( ProjectBuildingRequest request, Collection<Artifact> > mavenArtifacts ); > void install( ProjectBuildingRequest request, File localRepository, > Collection<Artifact> mavenArtifacts ); > } > {code} > We should make sure that {{ProjectBuildRequest}} can't be null. Furthermore > the {{mavenArtifacts}} should also being checked for {{null}}. We need to > think if an {{empty}} collection is allowed or not? (I think it should not > being allowed?) > Apart from that the {{localRepository}} should be checked for {{null}} and it > should be checked for being a directory if it is not {{null}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)