[jira] [Closed] (SUREFIRE-1445) Properties from configuration POM are not passed to Provider on JDK 9
[
https://issues-test.apache.org/jira/browse/SUREFIRE-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1445.
--
Resolution: Fixed
[https://github.com/apache/maven-surefire/commit/302094ef2a7103d1a72b798443995a7d2b3b6702]
> Properties from configuration POM are not passed to Provider on JDK 9
> -
>
> Key: SUREFIRE-1445
> URL: https://issues-test.apache.org/jira/browse/SUREFIRE-1445
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.19.1, 2.20, 2.20.1
> Environment: JDK 9
>Reporter: Marc Philipp
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 2.21.0.Jigsaw
>
>
> Given the POM below, the {{JUnitPlatformProvider}} can read {{"excludeTags"}}
> = {{"slow"}} from {{ProviderParameters.getProviderProperties()}} when it runs
> on JDK 8 but not on JDK 9.
> The reason is that the constructor of {{SurefireProperties}} relies on an
> implementation detail of the class it extends, namely that {{putAll()}} will
> call {{put()}} for each entry. However, while {{Properties}} does that on JDK
> 8, it doesn't on JDK 9.
> Here's a link to the line in {{SurefireProperties}}:
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L62
> {code:xml}
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> junit5
> tagging
> 1.0-SNAPSHOT
>
>
>
> maven-surefire-plugin
> 2.19.1
>
>
> slow
>
>
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.0.2
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.0.2
>
>
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> 5.0.2
> test
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.0#76001)
[jira] [Closed] (SUREFIRE-1445) Properties from configuration POM are not passed to Provider on JDK 9
[
https://issues.apache.org/jira/browse/SUREFIRE-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1445.
--
Resolution: Fixed
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=302094ef2a7103d1a72b798443995a7d2b3b6702
> Properties from configuration POM are not passed to Provider on JDK 9
> -
>
> Key: SUREFIRE-1445
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1445
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.19.1, 2.20, 2.20.1
> Environment: JDK 9
>Reporter: Marc Philipp
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 2.21.0.Jigsaw
>
>
> Given the POM below, the {{JUnitPlatformProvider}} can read {{"excludeTags"}}
> = {{"slow"}} from {{ProviderParameters.getProviderProperties()}} when it runs
> on JDK 8 but not on JDK 9.
> The reason is that the constructor of {{SurefireProperties}} relies on an
> implementation detail of the class it extends, namely that {{putAll()}} will
> call {{put()}} for each entry. However, while {{Properties}} does that on JDK
> 8, it doesn't on JDK 9.
> Here's a link to the line in {{SurefireProperties}}:
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L62
> {code:xml}
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> junit5
> tagging
> 1.0-SNAPSHOT
>
>
>
> maven-surefire-plugin
> 2.19.1
>
>
> slow
>
>
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.0.2
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.0.2
>
>
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> 5.0.2
> test
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
