[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[
https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252616#comment-17252616
]
Marat Abrarov edited comment on MEAR-166 at 12/21/20, 4:53 AM:
---
FYI [~rfscholte], [~elharo], [~hboutemy] and [~afloom],
I suspect that this new feature depends on (would be easier to start work after
completion of) MEAR-292 and MEAR-294.
Refer to
[MEAR-166|https://github.com/apache/maven-ear-plugin/compare/master...mabrarov:MEAR-166]
branch of mabrarov/maven-ear-plugin repository for initial implementation
(adoption of [^MEAR-166-patch.diff]) which lacks (at the time of creation of
this comment):
# tests
# documentation for the new property of EAR module - {{classPathItem}} - which
controls if EAR module should be added into the {{Class-Path}} entry of
MANIFEST.mf of other modules (in case {{skipClassPathModification}} is
{{false}}, i.e. has default value).
was (Author: abrarovm):
FYI, [~rfscholte], [~elharo] and [~hboutemy].
I suspect that this new feature depends on (would be easier to start work after
completion of) MEAR-292 and MEAR-294.
Refer to
[MEAR-166|https://github.com/apache/maven-ear-plugin/compare/master...mabrarov:MEAR-166]
branch of mabrarov/maven-ear-plugin repository for initial implementation
(adoption of [^MEAR-166-patch.diff]) which lacks (at the time of creation of
this comment):
# tests
# documentation for the new property of EAR module - {{classPathItem}} - which
controls if EAR module should be added into the {{Class-Path}} entry of
MANIFEST.mf of other modules (in case {{skipClassPathModification}} is
{{false}}, i.e. has default value).
> 'skinnyWar' doesn't work well with dependencies of type 'ejb'
> -
>
> Key: MEAR-166
> URL: https://issues.apache.org/jira/browse/MEAR-166
> Project: Maven EAR Plugin
> Issue Type: New Feature
>Affects Versions: 2.8, 2.9
> Environment: many different environments I've verified this on
>Reporter: Michal Michalski
>Priority: Minor
> Labels: contributers-welcome
> Fix For: more-investigation
>
> Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff
>
>
> It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it
> does leave 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies
> exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic
> trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's
> dependencies should go to EAR's lib.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[
https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252616#comment-17252616
]
Marat Abrarov edited comment on MEAR-166 at 12/21/20, 4:52 AM:
---
FYI, [~rfscholte], [~elharo] and [~hboutemy].
I suspect that this new feature depends on (would be easier to start work after
completion of) MEAR-292 and MEAR-294.
Refer to
[MEAR-166|https://github.com/apache/maven-ear-plugin/compare/master...mabrarov:MEAR-166]
branch of mabrarov/maven-ear-plugin repository for initial implementation
(adoption of [^MEAR-166-patch.diff]) which lacks (at the time of creation of
this comment):
# tests
# documentation for the new property of EAR module - {{classPathItem}} - which
controls if EAR module should be added into the {{Class-Path}} entry of
MANIFEST.mf of other modules (in case {{skipClassPathModification}} is
{{false}}, i.e. has default value).
was (Author: abrarovm):
I suspect that this new feature depends on (would be easier to start work after
completion of) MEAR-292 and MEAR-294.
Refer to
[MEAR-166|https://github.com/apache/maven-ear-plugin/compare/master...mabrarov:MEAR-166]
branch of mabrarov/maven-ear-plugin repository for initial implementation
(adoption of [^MEAR-166-patch.diff]) which lacks (at the time of creation of
this comment):
# tests
# documentation for the new property of EAR module - {{classPathItem}} - which
controls if EAR module should be added into the {{Class-Path}} entry of
MANIFEST.mf of other modules (in case {{skipClassPathModification}} is
{{false}}, i.e. has default value)
> 'skinnyWar' doesn't work well with dependencies of type 'ejb'
> -
>
> Key: MEAR-166
> URL: https://issues.apache.org/jira/browse/MEAR-166
> Project: Maven EAR Plugin
> Issue Type: New Feature
>Affects Versions: 2.8, 2.9
> Environment: many different environments I've verified this on
>Reporter: Michal Michalski
>Priority: Minor
> Labels: contributers-welcome
> Fix For: more-investigation
>
> Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff
>
>
> It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it
> does leave 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies
> exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic
> trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's
> dependencies should go to EAR's lib.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[
https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212564#comment-17212564
]
Marat Abrarov edited comment on MEAR-166 at 10/12/20, 6:15 PM:
---
[~afloom], could you please provide a minimal maven project to reproduce your
use case? It looks like you don't follow
[https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html]
(refer to "the painful part"). I use [this
trick|https://github.com/mabrarov/maven-ear-plugin/blob/ea215eef8ea4cf429a793c29a15b6d48b7fe095c/src/test/resources/projects/project-092/ear/pom.xml#L40]
with {{pom}} to include all dependencies of EAR modules (of
{{eartest:war-sample-two:war}}) into EAR.
was (Author: abrarovm):
[~afloom], could you please provide a minimal maven project to reproduce your
use case? It looks like you don't follow
https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html
(refer to "the painful part").
> 'skinnyWar' doesn't work well with dependencies of type 'ejb'
> -
>
> Key: MEAR-166
> URL: https://issues.apache.org/jira/browse/MEAR-166
> Project: Maven Ear Plugin
> Issue Type: New Feature
>Affects Versions: 2.8, 2.9
> Environment: many different environments I've verified this on
>Reporter: Michal Michalski
>Priority: Minor
> Labels: contributers-welcome
> Fix For: more-investigation
>
> Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff
>
>
> It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it
> does leave 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies
> exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic
> trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's
> dependencies should go to EAR's lib.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[ https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212564#comment-17212564 ] Marat Abrarov edited comment on MEAR-166 at 10/12/20, 6:12 PM: --- [~afloom], could you please provide a minimal maven project to reproduce your use case? It looks like you don't follow https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html (refer to "the painful part"). was (Author: abrarovm): [~afloom], could you please provide a minimal maven project to reproduce your use case? > 'skinnyWar' doesn't work well with dependencies of type 'ejb' > - > > Key: MEAR-166 > URL: https://issues.apache.org/jira/browse/MEAR-166 > Project: Maven Ear Plugin > Issue Type: New Feature >Affects Versions: 2.8, 2.9 > Environment: many different environments I've verified this on >Reporter: Michal Michalski >Priority: Minor > Labels: contributers-welcome > Fix For: more-investigation > > Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff > > > It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it > does leave 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies > exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic > trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's > dependencies should go to EAR's lib. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[ https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141654#comment-15141654 ] Sven Diedrichsen edited comment on MEAR-166 at 2/10/16 8:57 PM: Created simple patch of 2.10.1 which creates EARs with removing EJB modules from WARs lib folders. was (Author: sdiedrichsen): Created simple patch which creates EARs with removing EJB modules from WARs lib folders. > 'skinnyWar' doesn't work well with dependencies of type 'ejb' > - > > Key: MEAR-166 > URL: https://issues.apache.org/jira/browse/MEAR-166 > Project: Maven Ear Plugin > Issue Type: New Feature >Affects Versions: 2.8, 2.9 > Environment: many different environments I've verified this on >Reporter: Michal Michalski >Priority: Minor > Labels: contributers-welcome > Fix For: more-investigation > > Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff > > > It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it > does left 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies > exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic > trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's > dependencies should go to EAR's lib. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[ https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141654#comment-15141654 ] Sven Diedrichsen edited comment on MEAR-166 at 2/10/16 8:59 PM: Created simple patch of 2.10.1 which creates EARs with removing EJB modules from WARs lib folders. Hope this is sufficient to do the job. It does the job for me. was (Author: sdiedrichsen): Created simple patch of 2.10.1 which creates EARs with removing EJB modules from WARs lib folders. > 'skinnyWar' doesn't work well with dependencies of type 'ejb' > - > > Key: MEAR-166 > URL: https://issues.apache.org/jira/browse/MEAR-166 > Project: Maven Ear Plugin > Issue Type: New Feature >Affects Versions: 2.8, 2.9 > Environment: many different environments I've verified this on >Reporter: Michal Michalski >Priority: Minor > Labels: contributers-welcome > Fix For: more-investigation > > Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff > > > It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it > does left 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies > exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic > trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's > dependencies should go to EAR's lib. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MEAR-166) 'skinnyWar' doesn't work well with dependencies of type 'ejb'
[ https://issues.apache.org/jira/browse/MEAR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141654#comment-15141654 ] Sven Diedrichsen edited comment on MEAR-166 at 2/10/16 9:00 PM: Created simple patch of 2.10.1 which creates EARs with removing EJB modules from WARs lib folders. Hope this is sufficient to do the job. It does the job for me. Can I in any way help to get this into the next release? was (Author: sdiedrichsen): Created simple patch of 2.10.1 which creates EARs with removing EJB modules from WARs lib folders. Hope this is sufficient to do the job. It does the job for me. > 'skinnyWar' doesn't work well with dependencies of type 'ejb' > - > > Key: MEAR-166 > URL: https://issues.apache.org/jira/browse/MEAR-166 > Project: Maven Ear Plugin > Issue Type: New Feature >Affects Versions: 2.8, 2.9 > Environment: many different environments I've verified this on >Reporter: Michal Michalski >Priority: Minor > Labels: contributers-welcome > Fix For: more-investigation > > Attachments: EAR without EJB dependencies.patch, MEAR-166-patch.diff > > > It seems that 'skinnyWar' works OK with dependencies of type 'jar', but it > does left 'ejb' dependencies in WEB-INF/lib. Finally, these dependencies > exist both in EAR's lib dir and WEB-INF/lib within WAR, when using classic > trick with both 'war'-type and 'pom'-type dependency to WAR, so all WAR's > dependencies should go to EAR's lib. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
