[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380735#comment-17380735
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:52 PM:
--

[~David Hayes] - That is right. The sysprop helps in detecting the file that 
has malformed encoding.

[~michael-o] - I am very sorry to say that this issue has reoccurred. Everyone 
is referring to this and the comments are continuing. Do you think this issue 
can be reopened or do you want me to open a new issue altogether?


was (Author: nv):
[~David Hayes] - That is right. The sysprop helps in detecting the file that 
has malformed encoding.

[~michael-o] - I am very sorry to say that this issue has reoccurred. Everyone 
is referring to this and the comments are continuing. Do you think this issue 
can be reopened or do you want me open a new issue altogether?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: gdmr.txt, gdmr.txt, image-2021-06-05-10-00-08-542.png, 
> screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:51 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; The diff after the modification is ...++

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
index e31f0969..2dcc0a88 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
@@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );
 
 Properties props = new Properties();
\- props.load( stream );
+
+ if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) {
+ try {
+ props.load(stream);
+ } catch (Throwable t) {
+ System.out.println("\nfile: " + file + "\n");
+ System.exit(1);
+ }
+ } else {
+ props.load(stream);
+ }
 
 return props;
 }

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; The diff after the modification is ...++

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
index e31f0969..2dcc0a88 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
@@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );
 
 Properties props = new Properties();
- props.load( stream );
+
+ if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) {
+ try {
+ props.load(stream);
+ } catch (Throwable t) {
+ System.out.println("\nfile: " + file + "\n");
+ System.exit(1);
+ }
+ } else {
+ props.load(stream);
+ }
 
 return props;
 }

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: gdmr.txt, gdmr.txt, image-2021-06-05-10-00-08-542.png, 
> screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:50 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; The diff after the modification is ...++

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
index e31f0969..2dcc0a88 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
@@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );
 
 Properties props = new Properties();
- props.load( stream );
+
+ if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) {
+ try {
+ props.load(stream);
+ } catch (Throwable t) {
+ System.out.println("\nfile: " + file + "\n");
+ System.exit(1);
+ }
+ } else {
+ props.load(stream);
+ }
 
 return props;
 }

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; The diff after the modification is in 
+attached+ file

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: gdmr.txt, gdmr.txt, image-2021-06-05-10-00-08-542.png, 
> screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380735#comment-17380735
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:46 PM:
--

[~David Hayes] - That is right. The sysprop helps in detecting the file that 
has malformed encoding.

[~michael-o] - I am very sorry to say that this issue has reoccurred. Everyone 
is referring to this and the comments are continuing. Do you think this issue 
can be reopened or do you want me open a new issue altogether?


was (Author: nv):
[~David Hayes] - That is right. The sysprop helps in detecting the file that 
has malformed encoding.

[~michael-o] - I am very sorry to say that the has reoccurred. Do you think 
this issue can be reopened or do you want me open a new issue altogether?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: gdmr.txt, gdmr.txt, image-2021-06-05-10-00-08-542.png, 
> screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:41 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; The diff after the modification is in 
+attached+ file

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

 
{quote}diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
{ +   try {
+ props.load(stream); 
+   }
+ catch (Throwable t) {
+ System.out.println("\\nfile: " + file + "\\n");

+ }
+ } else {
+   props.load(stream);

+ }
return props;
 }

 
{quote}
. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: gdmr.txt, image-2021-06-05-10-00-08-542.png, 
> screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:37 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

 
{quote}diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
{ +   try {
+ props.load(stream); 
+   }
+ catch (Throwable t) {
+ System.out.println("\\nfile: " + file + "\\n");

+ }
+ } else {
+   props.load(stream);

+ }
return props;
 }

 
{quote}
. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

 
{quote}diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

\- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
{ +   try { 

+ props.load(stream); 

+   } catch (Throwable t) {

+ System.out.println("\nfile: " + file + "\n");

+ System.exit(1);

+   }
 + } else {

+   props.load(stream);

+ }

return props;
 }

 
{quote}
. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: image-2021-06-05-10-00-08-542.png, screenshot-1.png, 
> with-global-sync-context.txt, without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:32 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

 
{quote}diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

\- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
{ +   try { 

+ props.load(stream); 

+   } catch (Throwable t) {

+ System.out.println("\nfile: " + file + "\n");

+ System.exit(1);

+   }
 + } else {

+   props.load(stream);

+ }

return props;
 }

 
{quote}
. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

 
{quote}diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
\{ + try { + props.load(stream); + }

catch (Throwable t) \{ + System.out.println("\nfile: " + file + "\n"); + 
System.exit(1); + }
 + } else \{ + props.load(stream); + }

return props;
 }

 
{quote}
. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: image-2021-06-05-10-00-08-542.png, screenshot-1.png, 
> with-global-sync-context.txt, without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:28 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

 
{quote}diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
\{ + try { + props.load(stream); + }

catch (Throwable t) \{ + System.out.println("\nfile: " + file + "\n"); + 
System.exit(1); + }
 + } else \{ + props.load(stream); + }

return props;
 }

 
{quote}
. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

```

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

\- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
\{ + try \{ + props.load(stream); + }

catch (Throwable t) \{ + System.out.println("\nfile: " + file + "\n"); + 
System.exit(1); + }
 + } else \{ + props.load(stream); + }

return props;
 }

```

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: image-2021-06-05-10-00-08-542.png, screenshot-1.png, 
> with-global-sync-context.txt, without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:25 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

```

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

\- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) 
\{ + try \{ + props.load(stream); + }

catch (Throwable t) \{ + System.out.println("\nfile: " + file + "\n"); + 
System.exit(1); + }
 + } else \{ + props.load(stream); + }

return props;
 }

```

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

.cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

```

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) {
 + try \{ + props.load(stream); + } catch (Throwable t) \{ + 
System.out.println("\nfile: " + file + "\n"); + System.exit(1); + }
 + } else \{ + props.load(stream); + }

return props;
 }

```

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: image-2021-06-05-10-00-08-542.png, screenshot-1.png, 
> with-global-sync-context.txt, without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-07-14 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380721#comment-17380721
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 7/14/21, 4:24 PM:
--

Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

.cd maven-resolver

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

```

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 index e31f0969..2dcc0a88 100644
 — 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 +++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 @@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );

Properties props = new Properties();

- props.load( stream );
 +
 + if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) {
 + try \{ + props.load(stream); + } catch (Throwable t) \{ + 
System.out.println("\nfile: " + file + "\n"); + System.exit(1); + }
 + } else \{ + props.load(stream); + }

return props;
 }

```

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 


was (Author: nv):
Here's the latest workaround that I have resorted to ... steps ...

. git clone [https://github.com/apache/maven-resolver.git]

. git checkout 1.6.x

. Modify TrackingFileManager.java ; Here's the diff after the modification ...

```

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
index e31f0969..2dcc0a88 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
@@ -53,7 +53,17 @@ class TrackingFileManager
 stream = new FileInputStream( file );
 
 Properties props = new Properties();
- props.load( stream );
+
+ if (System.getProperty("spot_file_with_malformed_encoding").equals("true")) {
+ try {
+ props.load(stream);
+ } catch (Throwable t) {
+ System.out.println("\nfile: " + file + "\n");
+ System.exit(1);
+ }
+ } else {
+ props.load(stream);
+ }
 
 return props;
 }

```

. Do Maven Build

. Copy maven-resolver-impl/target/maven-resolver-impl-1.6.4-SNAPSHOT.jar to 
MAVEN_HOME/lib

. Remove MAVEN_HOME/lib/maven-resolver-impl-1.6.2.jar

 

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: image-2021-06-05-10-00-08-542.png, screenshot-1.png, 
> with-global-sync-context.txt, without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-06-05 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357913#comment-17357913
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 6/5/21, 5:00 PM:
-

{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with this in the properties 
section of my settings.xml{color}

{color:#403294}!image-2021-06-05-10-00-08-542.png!{color}

{color:#403294}. I overcame the issue by +not+ using above in the properties 
section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}


was (Author: nv):
{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with 
'characterEncoding=utf8' in the properties section of my 
settings.xml{color}

{color:#403294}. I overcame the issue by +not+ using "=utf8" 
in the properties section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: image-2021-06-05-10-00-08-542.png, screenshot-1.png, 
> with-global-sync-context.txt, without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-06-05 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357913#comment-17357913
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 6/5/21, 4:58 PM:
-

{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with 
'characterEncoding=utf8' in the properties section of my 
settings.xml{color}

{color:#403294}. I overcame the issue by +not+ using "=utf8" 
in the properties section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}


was (Author: nv):
{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with 
"characterEncoding=utf8" in the properties section of my 
settings.xml{color}

{color:#403294}. I overcame the issue by +not+ using 
"characterEncoding=utf8" in the properties section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-06-05 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357913#comment-17357913
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 6/5/21, 4:57 PM:
-

{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with 
"characterEncoding=utf8" in the properties section of my 
settings.xml{color}

{color:#403294}. I overcame the issue by +not+ using 
"characterEncoding=utf8" in the properties section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}


was (Author: nv):
{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with "&" in the properties 
section of my settings.xml{color}

{color:#403294}. I overcame the issue by not using "&" in the properties 
section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-06-05 Thread Naga Vijayapuram (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357913#comment-17357913
 ] 

Naga Vijayapuram edited comment on MRESOLVER-153 at 6/5/21, 4:45 PM:
-

{color:#403294}. Tried with Apache Maven 3.8.1+ (all the way up to Apache Maven 
4.0.x-SNAPSHOT) on Mac OS X 10.15.7 with Java 1.8.0_292{color}

{color:#403294}. And encountered similar issue with "&" in the properties 
section of my settings.xml{color}

{color:#403294}. I overcame the issue by not using "&" in the properties 
section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}


was (Author: nv):
{color:#403294}. Tried with 3.8.1+ (all the way up to 4.0.x-SNAPSHOT){color}

{color:#403294}. I encountered similar issue with "" in the properties 
section of my settings.xml{color}

{color:#403294}. I overcame the issue by not using "" in the properties 
section of settings.xml{color}

{color:#403294}. So, what I did is just a workaround{color}

{color:#403294}. Looking forward to a fix{color}

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353695#comment-17353695
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 5/29/21, 9:21 AM:


Your JDK is still two years old. Maven 3.8.1 does not contain this fix. I see 
no issue here. Build from branch and retest.


was (Author: michael-o):
Your JDK is still two years old. Maven 3.8.1 does not contain this fix. I see 
no issue here. Bild from branch and retest.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.6.3, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than 
> Linux or Windows ones. After some investigations we saw that as part of 
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has 
> been removed 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-29 Thread Jonathan Gafner (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353690#comment-17353690
 ] 

Jonathan Gafner edited comment on MRESOLVER-153 at 5/29/21, 8:12 AM:
-

[~michael-o] updated. Still happen

```

Picked up JAVA_TOOL_OPTIONS: 
Dmaven.ext.class.path="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/pipeline-maven-spy.jar"
 
Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531"
 Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: 
/home/builder/jenkins2/tools/hudson.tasks.Maven_MavenInstallation/maven-3.8.1/apache-maven-3.8.1
 Java version: 1.8.0_222, vendor: Azul Systems, Inc., runtime: 
/home/builder/jenkins2/tools/hudson.model.JDK/azul-jdk-zulu-8.40.0.25-8u222-b10/zulu8.40.0.25-ca-jdk8.0.222-linux_x64/jre
 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"4.14.35-1818.1.6.el7uek.x86_64", arch: "amd64", family: "unix" [INFO] 
[jenkins-event-spy] Generate 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log.tmp
 ... [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... 
[INFO] [INFO]  < com.organization.testing:tests-suite-runner  > [INFO] Building 
tests-suite-runner 4 [INFO] [ pom ][INFO] [INFO] BUILD FAILURE [INFO] [INFO] 
Total time: 1.295 s [INFO] Finished at: 2021-05-29T07:42:24Z [INFO]  [INFO] 
[jenkins-event-spy] Generated 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log
 [ERROR] Malformed \u encoding. java.lang.IllegalArgumentException: 
Malformed \u encoding. at java.util.Properties.loadConvert 
(Properties.java:574) at java.util.Properties.load0 (Properties.java:390) at 
java.util.Properties.load (Properties.java:341) at 
org.eclipse.aether.internal.impl.TrackingFileManager.read 
(TrackingFileManager.java:56) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
(DefaultUpdateCheckManager.java:511) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
(DefaultUpdateCheckManager.java:250) at 
org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
(DefaultMetadataResolver.java:302) at 
org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
(DefaultMetadataResolver.java:181) at 
org.apache.maven.repository.internal.DefaultVersionRangeResolver.getVersions 
(DefaultVersionRangeResolver.java:198)
 ```


was (Author: jgafner):
[~michael-o] updated. Still happen

```

Picked up JAVA_TOOL_OPTIONS: 
Dmaven.ext.class.path="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/pipeline-maven-spy.jar"
 
Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531"
 Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: 
/home/builder/jenkins2/tools/hudson.tasks.Maven_MavenInstallation/maven-3.8.1/apache-maven-3.8.1
 Java version: 1.8.0_222, vendor: Azul Systems, Inc., runtime: 
/home/builder/jenkins2/tools/hudson.model.JDK/azul-jdk-zulu-8.40.0.25-8u222-b10/zulu8.40.0.25-ca-jdk8.0.222-linux_x64/jre
 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"4.14.35-1818.1.6.el7uek.x86_64", arch: "amd64", family: "unix" [INFO] 
[jenkins-event-spy] Generate 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log.tmp
 ... [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... 
[INFO] [INFO] -< com.organization.testing:tests-suite-runner 
>--- [INFO] Building tests-suite-runner 4 [INFO] 
---[ pom ] [INFO] 
 [INFO] 
BUILD FAILURE [INFO] 
 [INFO] 
Total time: 1.295 s [INFO] Finished at: 2021-05-29T07:42:24Z [INFO] 
 [INFO] 
[jenkins-event-spy] Generated 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log
 [ERROR] Malformed \u encoding. java.lang.IllegalArgumentException: 
Malformed \u encoding. at java.util.Properties.loadConvert 
(Properties.java:574) at java.util.Properties.load0 (Properties.java:390) at 
java.util.Properties.load (Properties.java:341) at 
org.eclipse.aether.internal.impl.TrackingFileManager.read 
(TrackingFileManager.java:56) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-29 Thread Jonathan Gafner (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353690#comment-17353690
 ] 

Jonathan Gafner edited comment on MRESOLVER-153 at 5/29/21, 8:11 AM:
-

[~michael-o] updated. Still happen

```

Picked up JAVA_TOOL_OPTIONS: 
Dmaven.ext.class.path="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/pipeline-maven-spy.jar"
 
Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531"
 Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: 
/home/builder/jenkins2/tools/hudson.tasks.Maven_MavenInstallation/maven-3.8.1/apache-maven-3.8.1
 Java version: 1.8.0_222, vendor: Azul Systems, Inc., runtime: 
/home/builder/jenkins2/tools/hudson.model.JDK/azul-jdk-zulu-8.40.0.25-8u222-b10/zulu8.40.0.25-ca-jdk8.0.222-linux_x64/jre
 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"4.14.35-1818.1.6.el7uek.x86_64", arch: "amd64", family: "unix" [INFO] 
[jenkins-event-spy] Generate 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log.tmp
 ... [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... 
[INFO] [INFO] -< com.organization.testing:tests-suite-runner 
>--- [INFO] Building tests-suite-runner 4 [INFO] 
---[ pom ] [INFO] 
 [INFO] 
BUILD FAILURE [INFO] 
 [INFO] 
Total time: 1.295 s [INFO] Finished at: 2021-05-29T07:42:24Z [INFO] 
 [INFO] 
[jenkins-event-spy] Generated 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log
 [ERROR] Malformed \u encoding. java.lang.IllegalArgumentException: 
Malformed \u encoding. at java.util.Properties.loadConvert 
(Properties.java:574) at java.util.Properties.load0 (Properties.java:390) at 
java.util.Properties.load (Properties.java:341) at 
org.eclipse.aether.internal.impl.TrackingFileManager.read 
(TrackingFileManager.java:56) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
(DefaultUpdateCheckManager.java:511) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
(DefaultUpdateCheckManager.java:250) at 
org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
(DefaultMetadataResolver.java:302) at 
org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
(DefaultMetadataResolver.java:181) at 
org.apache.maven.repository.internal.DefaultVersionRangeResolver.getVersions 
(DefaultVersionRangeResolver.java:198)
 ```


was (Author: jgafner):
[~michael-o] updated. Still happen

```

Picked up JAVA_TOOL_OPTIONS: 
Dmaven.ext.class.path="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/pipeline-maven-spy.jar"
 
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531"
 Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: 
/home/builder/jenkins2/tools/hudson.tasks.Maven_MavenInstallation/maven-3.8.1/apache-maven-3.8.1
 Java version: 1.8.0_222, vendor: Azul Systems, Inc., runtime: 
/home/builder/jenkins2/tools/hudson.model.JDK/azul-jdk-zulu-8.40.0.25-8u222-b10/zulu8.40.0.25-ca-jdk8.0.222-linux_x64/jre
 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"4.14.35-1818.1.6.el7uek.x86_64", arch: "amd64", family: "unix" [INFO] 
[jenkins-event-spy] Generate 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log.tmp
 ... [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... 
[INFO] [INFO] -< com.organization.testing:tests-suite-runner 
> [INFO] Building tests-suite-runner 4 [INFO] 
[ pom ]- [INFO] 
 [INFO] 
BUILD FAILURE [INFO] 
 [INFO] 
Total time: 1.295 s [INFO] Finished at: 2021-05-29T07:42:24Z [INFO] 
 [INFO] 
[jenkins-event-spy] Generated 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log
 [ERROR] Malformed \u encoding. java.lang.IllegalArgumentException: 
Malformed \u encoding. at java.util.Properties.loadConvert 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-29 Thread Jonathan Gafner (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353690#comment-17353690
 ] 

Jonathan Gafner edited comment on MRESOLVER-153 at 5/29/21, 8:10 AM:
-

[~michael-o] updated. Still happen

```

Picked up JAVA_TOOL_OPTIONS: 
Dmaven.ext.class.path="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/pipeline-maven-spy.jar"
 
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531"
 Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: 
/home/builder/jenkins2/tools/hudson.tasks.Maven_MavenInstallation/maven-3.8.1/apache-maven-3.8.1
 Java version: 1.8.0_222, vendor: Azul Systems, Inc., runtime: 
/home/builder/jenkins2/tools/hudson.model.JDK/azul-jdk-zulu-8.40.0.25-8u222-b10/zulu8.40.0.25-ca-jdk8.0.222-linux_x64/jre
 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"4.14.35-1818.1.6.el7uek.x86_64", arch: "amd64", family: "unix" [INFO] 
[jenkins-event-spy] Generate 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log.tmp
 ... [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... 
[INFO] [INFO] -< com.organization.testing:tests-suite-runner 
> [INFO] Building tests-suite-runner 4 [INFO] 
[ pom ]- [INFO] 
 [INFO] 
BUILD FAILURE [INFO] 
 [INFO] 
Total time: 1.295 s [INFO] Finished at: 2021-05-29T07:42:24Z [INFO] 
 [INFO] 
[jenkins-event-spy] Generated 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log
 [ERROR] Malformed \u encoding. java.lang.IllegalArgumentException: 
Malformed \u encoding. at java.util.Properties.loadConvert 
(Properties.java:574) at java.util.Properties.load0 (Properties.java:390) at 
java.util.Properties.load (Properties.java:341) at 
org.eclipse.aether.internal.impl.TrackingFileManager.read 
(TrackingFileManager.java:56) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
(DefaultUpdateCheckManager.java:511) at 
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
(DefaultUpdateCheckManager.java:250) at 
org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
(DefaultMetadataResolver.java:302) at 
org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
(DefaultMetadataResolver.java:181) at 
org.apache.maven.repository.internal.DefaultVersionRangeResolver.getVersions 
(DefaultVersionRangeResolver.java:198)
 ```


was (Author: jgafner):
[~michael-o] updated. Still happen

```

Picked up JAVA_TOOL_OPTIONS: 
-Dmaven.ext.class.path="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/pipeline-maven-spy.jar"
 
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531"
 Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: 
/home/builder/jenkins2/tools/hudson.tasks.Maven_MavenInstallation/maven-3.8.1/apache-maven-3.8.1
 Java version: 1.8.0_222, vendor: Azul Systems, Inc., runtime: 
/home/builder/jenkins2/tools/hudson.model.JDK/azul-jdk-zulu-8.40.0.25-8u222-b10/zulu8.40.0.25-ca-jdk8.0.222-linux_x64/jre
 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"4.14.35-1818.1.6.el7uek.x86_64", arch: "amd64", family: "unix" [INFO] 
[jenkins-event-spy] Generate 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log.tmp
 ... [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... 
[INFO] [INFO] -< com.organization.testing:tests-suite-runner 
>- [INFO] Building tests-suite-runner 4 [INFO] 
[ pom ]- [INFO] 
 [INFO] 
BUILD FAILURE [INFO] 
 [INFO] 
Total time: 1.295 s [INFO] Finished at: 2021-05-29T07:42:24Z [INFO] 
 [INFO] 
[jenkins-event-spy] Generated 
/home/builder/jenkins2/workspace/test@4/tests-suite-runner@tmp/withMaven37bd3531/maven-spy-20210529-074222-7507020269431673965256.log
 [ERROR] Malformed \u encoding. java.lang.IllegalArgumentException: 
Malformed \u encoding. at java.util.Properties.loadConvert 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338776#comment-17338776
 ] 

Tamás Cservenák edited comment on MRESOLVER-153 at 5/4/21, 6:35 AM:


Coolio. We hope this will go out with Maven 4.0 (probably alpha1)?


was (Author: cstamas):
Coolio

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than 
> Linux or Windows ones. After some investigations we saw that as part of 
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has 
> been removed on the {{TrackingFileManager}} 
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to 
> concurrent writes on the {{resolver-status.properties}} file in our 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338776#comment-17338776
 ] 

Tamás Cservenák edited comment on MRESOLVER-153 at 5/4/21, 6:35 AM:


Coolio. We hope this will go out with Maven 4.0 (probably alpha1)? Until then 
we need to release resolver 1.7.0 that is matter of weeks I hope ([~michael-o]?)


was (Author: cstamas):
Coolio. We hope this will go out with Maven 4.0 (probably alpha1)?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than 
> Linux or Windows ones. After some investigations we saw that as part of 
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has 
> been removed on the 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-05-02 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332767#comment-17332767
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 5/2/21, 9:30 AM:
---

So, first of all, I made a mistake. My analysis for removing the 
synchronization was not good enough. I need to apologize for that. The purpose 
of the change was to remove synchronization because it is done on the outside 
({{SyncContext}}) already and analyzing the hierarchy from above it truly is 
except one small case: 
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download) 
{{maven-metadata.xml}} from all known repositories for the *same* 
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no 
race conditions possible), *but* some management data is written to 
{{resolver-status.properties}} next (same level) to these metadata. Since 
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel 
multiple threads write to the same file concurrently. The {{SyncContext}} does 
not apply here and it causes the race condition you see. The read fails because 
the previous writes have corrupted the file.
There are several entry points for 
{{DefaultMetadataResolver.resolveMetadata()}}.  I can reproduce the issue with 
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.

While we need to discuss a proper solution, I consider this behavior ugly 
because it completely breaks our sync idea.

I think there are two options:
* Add named sync into {{ResolveTask}}
* Inline code of {{ResolveTask}}, use {{RepositoryConnector}} directly, and 
record stuff in serial to avoid race conditions.

Looking at {{ResolveTask}} is runs off a parallel executor which hands off to a 
parallel executor again. I don't think that there is huge gain in that.

Please comment.


was (Author: michael-o):
So, first of all, I made a mistake. My analysis for removing the 
synchronization was not good enough. I need to apologize for that. The purpose 
of the change was to remove synchronization because it is done on the outside 
({{SyncContext}}) already and analyzing the hierarchy from above it truly is 
except one small case: 
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download) 
{{maven-metadata.xml}} from all known repositories for the *same* 
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no 
race conditions possible), *but* some management data is written to 
{{resolver-status.properties}} next (same level) to these metadata. Since 
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel 
multiple threads write to the same file concurrently. The {{SyncContext}} does 
not apply here and it causes the race condition you see. The read fails because 
the previous writes have corrupted the file.
There are several entry points for 
{{DefaultMetadataResolver.resolveMetadata()}}.  I can reproduce the issue with 
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.

While we need to discuss a proper solution, I consider this behavior ugly 
because it completely breaks our sync idea.

I think there are two options:
* Add named sync into {{ResolverTask}}
* Inline code of {{ResolverTask}}, use {{RepositoryConnector}} directly, and 
record stuff in serial to avoid race conditions.

Looking at {{ResolverTask}} is runs off a parallel executor which hands off to 
a parallel executor again. I don't think that there is huge gain in that.

Please comment.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332968#comment-17332968
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/27/21, 6:19 AM:


[~Brand], just looked at the files. Thanks, although they only contain the 
reads and not the writes the issue is understood.

[~cstamas], since the {{ResolverTask}} approach was broken eversince and does 
not fit in our new approach even more I would do propose the following:
1. Short term: set the thread count by default to {{1}} in 1.6.x and 1.7.0
2. Investigate proper synchronization for this code spot w/o imposing double 
sync on other callers of the {{TrackingFileManager}}.

Acceptable? (I prefer stability over performance)


was (Author: michael-o):
[~Brand], just looked at the files. Thanks, although they only contain the 
reads and not the writes the issue is understood.

[~cstamas], since the {{ResolverTask}} approach was broken eversince and does 
not fit in our new approach even more I would do propose the following:
1. Short term: set the thread count by default to {{1}} in 1.6.x and 1.7.0
2. Investigate proper synchronization for this code spot w/o imposing double 
sync on other callers of the {{TrackingFileManager}}.

Acceptable?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332968#comment-17332968
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/27/21, 6:16 AM:


[~Brand], just looked at the files. Thanks, although they only contain the 
reads and not the writes the issue is understood.

[~cstamas], since the {{ResolverTask}} approach was broken eversince and does 
not fit in our new approach even more I would do propose the following:
1. Short term: set the thread count by default to {{1}} in 1.6.x and 1.7.0
2. Investigate proper synchronization for this code spot w/o imposing double 
sync on other callers of the {{TrackingFileManager}}.

Acceptable?


was (Author: michael-o):
[~Brand], just looked at the files. Thanks, although they only contain the 
reads and not the writes the issue is understood.

[~cstamas], since the {{ResolverTask}} approach was broken eversince and does 
not fit in our new approach even more I would do propose the following:
1. Short term: set the thread count by default to 1 in 1.6.x and 1.7.0
2. Investigate proper synchronization for this code spot w/o imposing double 
sync on other callers of the {{TrackingFileManager}}.

Acceptable?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-26 Thread Guy Brand (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332937#comment-17332937
 ] 

Guy Brand edited comment on MRESOLVER-153 at 4/27/21, 5:31 AM:
---

I've executed the tests and extracted two that failed with the above error. One 
is with the {{-Daether.syncContext.impl=global}} system property set and one 
without.

Just read the above comments and nice that you could find the root cause. I 
hope with these logs you can verify it. Do you need anything else from me?

 

[^with-global-sync-context.txt] [^without-global-sync-context.txt]


was (Author: brand):
I've executed the tests and extracted two that failed with the above error. One 
is with the {{-Daether.syncContext.impl=global}} system property set and one 
without.

Just read the above comments and nice that you could find the root cause. I 
hope with these logs you can verify it. Do you need anything else from me?

 

[^with-global-sync-context.txt] [^without-global-sync-context.txt]

[^with-global-sync-context.txt]

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt, 
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-26 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332767#comment-17332767
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 10:00 PM:
-

So, first of all, I made a mistake. My analysis for removing the 
synchronization was not good enough. I need to apologize for that. The purpose 
of the change was to remove synchronization because it is done on the outside 
({{SyncContext}}) already and analyzing the hierarchy from above it truly is 
except one small case: 
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download) 
{{maven-metadata.xml}} from all known repositories for the *same* 
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no 
race conditions possible), *but* some management data is written to 
{{resolver-status.properties}} next (same level) to these metadata. Since 
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel 
multiple threads write to the same file concurrently. The {{SyncContext}} does 
not apply here and it causes the race condition you see. The read fails because 
the previous writes have corrupted the file.
There are several entry points for 
{{DefaultMetadataResolver.resolveMetadata()}}.  I can reproduce the issue with 
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.

While we need to discuss a proper solution, I consider this behavior ugly 
because it completely breaks our sync idea.

I think there are two options:
* Add named sync into {{ResolverTask}}
* Inline code of {{ResolverTask}}, use {{RepositoryConnector}} directly, and 
record stuff in serial to avoid race conditions.

Looking at {{ResolverTask}} is runs off a parallel executor which hands off to 
a parallel executor again. I don't think that there is huge gain in that.

Please comment.


was (Author: michael-o):
So, first of all, I made a mistake. My analysis for removing the 
synchronization was not good enough. I need to apologize for that. The purpose 
of the change was to remove synchronization because it is done on the outside 
({{SyncContext}}) already and analyzing the hierarchy from above it truly is 
except one small case: 
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download) 
{{maven-metadata.xml}} from all known repositories for the *same* 
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no 
race conditions possible), *but* some management data is written to 
{{resolver-status.properties}} next (same level) to these metadata. Since 
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel 
multiple threads write to the same file concurrently. The {{SyncContext}} does 
not apply here and it causes the race condition you see. The read fails because 
the previous writes have corrupted the file.
There are several entry points for 
{{DefaultMetadataResolver.resolveMetadata()}}.  I can reproduce the issue with 
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.

While we need to discuss a proper solution, I consider this behavior ugly 
because it completely breaks our sync idea.

I think there are two options:
* Add named sync into {{ResolverTask}}
* Inline code of {{ResolverTask}}, use {{RepositoryConnector}} directly, and 
record stuff in serial to avoid race conditions.

Looking at {{ResolverTask}} is runs off an parallel executor which hands off to 
a parallel executor again. I don't think that there is huge gain in that.

Please comment.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-26 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332712#comment-17332712
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 8:09 PM:


Here is the call hierarchy:
{noformat}
o.e.a.internal.impl.TrackingFileManager.read(File):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.readRepos(File): 
"_remote.repositories" sibling of {artifactFilePath}
|-- public 
o.e.a.internal.impl.EnhancedLocalRepositoryManager.find(RepositorySystemSession,
 LocalArtifactRequest)
|--- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection)
| (versionResult = versionResolver.resolveVersion( session, versionRequest 
))
|- metadataResolver.resolveMetadata( session, metadataReqs )
| private 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.read(File)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.checkArtifact(RepositorySystemSession,
 UpdateCheck): 
"{artifactFilePath}.lastUpdated"
|--- private 
o.e.a.internal.impl.DefaultArtifactResolver.gatherDownloads(RepositorySystemSession,
 ResolutionGroup)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
 ResolutionGroup)
|- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection)
|-- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.checkMetadata(RepositorySystemSession,
 UpdateCheck): 
"resolver-status.properties" sibling of {metadataFilePath}
|--- private 
o.e.a.internal.impl.DefaultMetadataResolver.resolve(RepositorySystemSession, 
Collection)
| public 
o.e.a.internal.impl.DefaultMetadataResolver.resolveMetadata(RepositorySystemSession,
 Collection): syncContext.acquire( null, metadata ) 
(write)

o.e.a.internal.impl.TrackingFileManager.update(File, Map):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.addRepo(File, 
Collection): "_remote.repositories" sibling of {artifactFilePath}
|-- private 
o.e.a.internal.impl.EnhancedLocalRepositoryManager.addArtifact(Artifact, 
Collection, boolean)
|--- public 
o.e.a.internal.impl.EnhancedLocalRepositoryManager.add(RepositorySystemSession, 
LocalArtifactRegistration)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
 ResolutionGroup)
|- private 
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
 ResolutionGroup)
|-- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection) 
|--- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
| private 
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession, 
RequestTrace, Artifact, LocalRepositoryManager, File, FileTransformer)
|- private 
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession, 
RequestTrace, Artifact)
|-- private o.e.a.internal.impl.DefaultInstaller.install(SyncContext, 
RepositorySystemSession, InstallRequest): syncContext.acquire( artifacts, 
Utils.combine( request.getMetadata(), metadatas ) )
|--- public 
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession, 
InstallRequest) (write)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection)
|- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.write(File, String, 
String, Exception)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.touchArtifact(RepositorySystemSession,
 UpdateCheck): 
"{artifactFilePath}.lastUpdated"
|--- private 
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
 ResolutionGroup)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
 ResolutionGroup)
|- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection) 
|-- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.touchMetadata(RepositorySystemSession,
 UpdateCheck): 
"resolver-status.properties" sibling of {metadataFilePath}
|--- public 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-26 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332712#comment-17332712
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 8:09 PM:


Here is the call hierarchy:
{noformat}
o.e.a.internal.impl.TrackingFileManager.read(File):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.readRepos(File): 
"_remote.repositories" sibling of {artifactFilePath}
|-- public 
o.e.a.internal.impl.EnhancedLocalRepositoryManager.find(RepositorySystemSession,
 LocalArtifactRequest)
|--- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection)
| (versionResult = versionResolver.resolveVersion( session, versionRequest 
))
|- metadataResolver.resolveMetadata( session, metadataReqs )
| private 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.read(File)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.checkArtifact(RepositorySystemSession,
 UpdateCheck): 
"{artifactFilePath}.lastUpdated"
|--- private 
o.e.a.internal.impl.DefaultArtifactResolver.gatherDownloads(RepositorySystemSession,
 ResolutionGroup)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
 ResolutionGroup)
|- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection)
|-- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.checkMetadata(RepositorySystemSession,
 UpdateCheck): 
"resolver-status.properties" sibling of {metadataFilePath}
|--- private 
o.e.a.internal.impl.DefaultMetadataResolver.resolve(RepositorySystemSession, 
Collection)
| public 
o.e.a.internal.impl.DefaultMetadataResolver.resolveMetadata(RepositorySystemSession,
 Collection): syncContext.acquire( null, metadata ) 
(write)

o.e.a.internal.impl.TrackingFileManager.update(File, Map):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.addRepo(File, 
Collection): "_remote.repositories" sibling of {artifactFilePath}
|-- private 
o.e.a.internal.impl.EnhancedLocalRepositoryManager.addArtifact(Artifact, 
Collection, boolean)
|--- public 
o.e.a.internal.impl.EnhancedLocalRepositoryManager.add(RepositorySystemSession, 
LocalArtifactRegistration)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
 ResolutionGroup)
|- private 
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
 ResolutionGroup)
|-- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection) 
|--- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
| private 
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession, 
RequestTrace, Artifact, LocalRepositoryManager, File, FileTransformer)
|- private 
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession, 
RequestTrace, Artifact)
|-- private o.e.a.internal.impl.DefaultInstaller.install(SyncContext, 
RepositorySystemSession, InstallRequest): syncContext.acquire( artifacts, 
Utils.combine( request.getMetadata(), metadatas ) )
|--- public 
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession, 
InstallRequest) (write)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection)
|- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.write(File, String, 
String, Exception)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.touchArtifact(RepositorySystemSession,
 UpdateCheck): 
"{artifactFilePath}.lastUpdated"
|--- private 
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
 ResolutionGroup)
| private 
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
 ResolutionGroup)
|- private 
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession, 
Collection) 
|-- public 
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
 Collection): syncContext.acquire( artifacts, null ) 
(write)
|-- public 
o.e.a.internal.impl.DefaultUpdateCheckManager.touchMetadata(RepositorySystemSession,
 UpdateCheck): 
"resolver-status.properties" sibling of {metadataFilePath}
|--- public 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-26 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332629#comment-17332629
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 5:37 PM:


The biggest problem is: 
{{org.eclipse.aether.internal.impl.DefaultMetadataResolver.ResolveTask.run()}} 
This resolves (downloads) metadata completely w/o any synchronization.

[~cstamas], I need to completely analyze which tracking files are written and 
check what kind of synchro they have, if any. Annoying. I don't understand why 
the {{ResolverTask}} is not subject to.


was (Author: michael-o):
The biggest problem is: 
{{org.eclipse.aether.internal.impl.DefaultMetadataResolver.ResolveTask.run()}} 
This resolves (downloads) metadata completely w/o any synchronization.

[~cstamas], I need to completely analyze with tracking files are written and 
check what kind of synchro they have, if any. Annoying. I don't understand why 
the {{ResolverTask}} is not subject to.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-04-24 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331331#comment-17331331
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 4/24/21, 10:22 PM:
-

MRESOLVER-145 has now been merged into master. I want to cut a release this 
month. [~Brand], please test as soon as possible, the snapshot tarball has been 
updated for you.


was (Author: michael-o):
[~Brand], please test as soon as possible. MRESOLVER-145 has now been merged 
into master. I want to cut a release this month.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than 
> Linux or Windows ones. After some investigations we saw that as part of 
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has 
> been 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255537#comment-17255537
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:40 AM:
--

[~Brand],
thanks for the update. The flag use makes sense.
You are right, of course, about the synchronization. That's the way it was for 
years and it was faulty. We had numerous tickets about that. As [~cstamas] 
said, we are working on it. My Redisson-based implementation does quite well, 
more to come from Tamás. You are cordially invited to review and test the PR. 
Let me make this clear, I think that synchronization in the  
{{TrackingFileManager}} is the wrong place to be. So I am grateful for your 
report and it happily proves the lack of proper synchronization.

Run this on Maven Core ITs and you see {{maven-metadata.xml}} fail quite quick:
{{rm -rf /tmp/repo* ; ~/apache-maven-4.0.0-alpha-1-SNAPSHOT/bin/mvn 
-Dmaven.repo.local=/tmp/repo4 clean install -T4C -DskipTests 
-Dorg.slf4j.simpleLogger.showThreadName=true -U -B}}.


was (Author: michael-o):
[~Brand],
thanks for the update. The flag use makes sense.
You are right, of course, about the synchronization. That's the way it was for 
years and it was faulty. We had numerous tickets about that. As [~cstamas] 
said, we are working on it. My Redisson-based implementation does quite well, 
more to come from Tamás. You are cordially invited to review and test the PR. 
Let me make this clear, I think that synchronization in the  
{{TrackingFileManager}} is the wrong place to be. So I am grateful for your 
report and it happily proves the lack of proper synchronization.

Run this on Maven Core ITs and you see {{maven-metadata.xml}} fail quite quick:
{{ rm -rf /tmp/repo* ; ~/apache-maven-4.0.0-alpha-1-SNAPSHOT/bin/mvn 
-Dmaven.repo.local=/tmp/repo4 clean install -T4C -DskipTests 
-Dorg.slf4j.simpleLogger.showThreadName=true -U -B}}.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255537#comment-17255537
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:39 AM:
--

[~Brand],
thanks for the update. The flag use makes sense.
You are right, of course, about the synchronization. That's the way it was for 
years and it was faulty. We had numerous tickets about that. As [~cstamas] 
said, we are working on it. My Redisson-based implementation does quite well, 
more to come from Tamás. You are cordially invited to review and test the PR. 
Let me make this clear, I think that synchronization in the  
{{TrackingFileManager}} is the wrong place to be. So I am grateful for your 
report and it happily proves the lack of proper synchronization.

Run this on Maven Core ITs and you see {{maven-metadata.xml}} fail quite quick:
{{ rm -rf /tmp/repo* ; ~/apache-maven-4.0.0-alpha-1-SNAPSHOT/bin/mvn 
-Dmaven.repo.local=/tmp/repo4 clean install -T4C -DskipTests 
-Dorg.slf4j.simpleLogger.showThreadName=true -U -B}}.


was (Author: michael-o):
[~Brand],
thanks for the update. The flag use makes sense.
You are right, of course, about the synchronization. That's the way it was for 
years and it was faulty. We had numerous tickets about that. As [~cstamas] 
said, we are working on it. My Redisson-based implementation does quite well, 
more to come from Tamás. You are cordially invited to review and test the PR.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255537#comment-17255537
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:36 AM:
--

[~Brand],
thanks for the update. The flag use makes sense.
You are right, of course, about the synchronization. That's the way it was for 
years and it was faulty. We had numerous tickets about that. As [~cstamas] 
said, we are working on it. My Redisson-based implementation does quite well, 
more to come from Tamás. You are cordially invited to review and test the PR.


was (Author: michael-o):
[~Brand],
thanks for the update. The flag use makes sense.
You are right, of course, about the synchronization. That's the way it was for 
years and it was faulty. We had numerous tickets about that. As [~cstamas] 
said, we are working on it. My Redisson-based implementation does quite well, 
more to come form Tamás.

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255522#comment-17255522
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:34 AM:
--

[~michael-o] Regarding

> Why do you pass {{-Daether.updateCheckManager.sessionState=false}}? What 
> happens when you leave this out?

With this flag set, the problem is reproducible more often as it will check the 
dependencies every time and doesn't store it in the session.

> Can you try {{-Daether.metadataResolver.threads=1}} for testing purposes?

I executed a run of all our integration tests and they passed. We'll then keep 
this flag set until this is fixed in a future Maven nightly version.

Regarding the synchronization: There you already discussed on how to restore 
it. My two cents on that topic are the following:

There is the concept of a {{SyncContext}} and components as the 
{{TrackingFileManager}} rely on this to implement proper synchronization. Why 
having a {{DefaultSyncContext}} in place that does no synchronization at all? 
Having this noop {{SyncContext}} could produce other errors like the one I 
reported. Therefore instead of checking if the {{DefaultSyncContext}} is used 
in the {{TrackingFileManager}}, why not just implement basic synchronization in 
the {{DefaultSyncContext}, }rely on it and on top prevent similar errors on the 
other usages of {{SyncContext}}?


was (Author: brand):
[~michael-o] Regarding

> Why do you pass {{-Daether.updateCheckManager.sessionState=false}}? What 
> happens when you leave this out?

With this flag set, the problem is reproducible more often as it will check the 
dependencies every time and doesn't store it in the session.

> Can you try {{-Daether.metadataResolver.threads=1}} for testing purposes?

I executed a run of all our integration tests and they passed. We'll then keep 
this flag set until this is fixed in a future Maven nightly version.

Regarding the synchronization: There you already discussed on how to restore 
it. My two cents on that topic are the following:

There is the concept of a {{SyncContext}} and components as the 
{{TrackingFileManager}} rely on this to implement proper synchronization. Why 
having a {{DefaultSyncContext}} in place that does no synchronization at all? 
Having this noop {{SyncContext}} could produce other errors like the one I 
reported. Therefore instead of checking if the {{DefaultSyncContext}} is used 
in the {{TrackingFileManager}}, why not just implement basic synchronization in 
the {{DefaultSyncContext, }}rely on it and on top prevent similar errors on the 
other usages of {{SyncContext}}?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255522#comment-17255522
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:34 AM:
--

[~michael-o] Regarding

> Why do you pass {{-Daether.updateCheckManager.sessionState=false}}? What 
> happens when you leave this out?

With this flag set, the problem is reproducible more often as it will check the 
dependencies every time and doesn't store it in the session.

> Can you try {{-Daether.metadataResolver.threads=1}} for testing purposes?

I executed a run of all our integration tests and they passed. We'll then keep 
this flag set until this is fixed in a future Maven nightly version.

Regarding the synchronization: There you already discussed on how to restore 
it. My two cents on that topic are the following:

There is the concept of a {{SyncContext}} and components as the 
{{TrackingFileManager}} rely on this to implement proper synchronization. Why 
having a {{DefaultSyncContext}} in place that does no synchronization at all? 
Having this noop {{SyncContext}} could produce other errors like the one I 
reported. Therefore instead of checking if the {{DefaultSyncContext}} is used 
in the {{TrackingFileManager}}, why not just implement basic synchronization in 
the {{DefaultSyncContext}}, rely on it and on top prevent similar errors on the 
other usages of {{SyncContext}}?


was (Author: brand):
[~michael-o] Regarding

> Why do you pass {{-Daether.updateCheckManager.sessionState=false}}? What 
> happens when you leave this out?

With this flag set, the problem is reproducible more often as it will check the 
dependencies every time and doesn't store it in the session.

> Can you try {{-Daether.metadataResolver.threads=1}} for testing purposes?

I executed a run of all our integration tests and they passed. We'll then keep 
this flag set until this is fixed in a future Maven nightly version.

Regarding the synchronization: There you already discussed on how to restore 
it. My two cents on that topic are the following:

There is the concept of a {{SyncContext}} and components as the 
{{TrackingFileManager}} rely on this to implement proper synchronization. Why 
having a {{DefaultSyncContext}} in place that does no synchronization at all? 
Having this noop {{SyncContext}} could produce other errors like the one I 
reported. Therefore instead of checking if the {{DefaultSyncContext}} is used 
in the {{TrackingFileManager}}, why not just implement basic synchronization in 
the {{DefaultSyncContext}, }rely on it and on top prevent similar errors on the 
other usages of {{SyncContext}}?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> 

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-24 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254535#comment-17254535
 ] 

Michael Osipov edited comment on MRESOLVER-153 at 12/24/20, 1:16 PM:
-

[~cstamas], this is an interesting case which I did not had in mind at all. 
Concurrency within one module with overlapping artifacts. I think we need to 
employ synchronization by default in Resolver. What is your opinion on the 
entire issue?

An alternative is to use custom file tracking managers depending on the sync 
context implementation.


was (Author: michael-o):
[~cstamas], this is an interesting case which I did not had in mind at all. 
Concurrency within one module with overlapping artifacts. I think we need to 
employ synchronization by default in Resolver. What is your opinion on the 
entire issue?

> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}} 
> after [this 
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
>  we face the following error:
> {code:java}
> [main] [INFO] 
> 
> [main] [INFO] BUILD FAILURE
> [main] [INFO] 
> 
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO] 
> 
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
>  at java.util.Properties.loadConvert (Properties.java:675)
>  at java.util.Properties.load0 (Properties.java:451)
>  at java.util.Properties.load (Properties.java:404)
>  at org.eclipse.aether.internal.impl.TrackingFileManager.read 
> (TrackingFileManager.java:56)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read 
> (DefaultUpdateCheckManager.java:511)
>  at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata 
> (DefaultUpdateCheckManager.java:250)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve 
> (DefaultMetadataResolver.java:302)
>  at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata 
> (DefaultMetadataResolver.java:181)
>  at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata 
> (DefaultRepositorySystem.java:277)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
>  (DefaultPluginVersionResolver.java:134)
>  at 
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve 
> (DefaultPluginVersionResolver.java:97)
>  at 
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
>  (LifecyclePluginResolver.java:67)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:104)
>  at 
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
>  (DefaultLifecycleTaskSegmentCalculator.java:86)
>  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:92)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:566)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
>