[jira] [Comment Edited] (MSHARED-480) Use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643783#comment-17643783
]
Michael Osipov edited comment on MSHARED-480 at 12/6/22 1:26 PM:
-
Here is a comparison from my project:
With Maven Site Plugin:
!screenshot-1.png!
Direct invocation after the fix:
!screenshot-2.png!
Don't mind the heading size, this needs to be fixed in Fluido. The menu is
correct since the menu is also populated by the Maven Site Plugin sans the
reports.
>From my opion the menu on the side or top is useless:
!screenshot-3.png!
>From Fluido Skin we need to internally set this:
{noformat}
34
35
36 false
37 false
38
39
{noformat}
and the result:
!screenshot-4.png!
Note: Now the context contains the information about standalone execution so we
can distinguish.
was (Author: michael-o):
Here is a comparison from my project:
With Maven Site Plugin:
!screenshot-1.png!
Direct invocation after the fix:
!screenshot-2.png!
Don't mind the heading size, this needs to be fixed in Fluido. The menu is
correct since the menu is also populated by the Maven Site Plugin.
>From my opion the menu on the side or top is useless:
!screenshot-3.png!
>From Fluido Skin we need to internally set this:
{noformat}
34
35
36 true
37 true
38
39
{noformat}
and the result:
!screenshot-4.png!
Note: Now the context contains the information about standalone execution so we
can distinguish.
> Use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHARED-480) Use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643765#comment-17643765
]
Michael Osipov edited comment on MSHARED-480 at 12/6/22 9:54 AM:
-
Here is a solution to the issue:
1. Build from
https://github.com/apache/maven-reporting-impl/compare/master...use-site.xml
and install
2. Build from
https://github.com/apache/maven-project-info-reports-plugin/compare/doxia-2.0.0...use-site.xml
and try
[~hboutemy], I am not fully happy with
https://github.com/apache/maven-project-info-reports-plugin/compare/doxia-2.0.0...use-site.xml#diff-7f69e35571e6f28056ef79ea1930349d407b4ccd405a2c75e45ba3e6e47a8430R188-R194,
maybe you have a better idea for this test config snippet.
was (Author: michael-o):
Here is a solution the issue:
1. Build from
https://github.com/apache/maven-reporting-impl/compare/master...use-site.xml
and install
2. Build from
https://github.com/apache/maven-project-info-reports-plugin/compare/doxia-2.0.0...use-site.xml
and try
[~hboutemy], I am not fully happy with
https://github.com/apache/maven-project-info-reports-plugin/compare/doxia-2.0.0...use-site.xml#diff-7f69e35571e6f28056ef79ea1930349d407b4ccd405a2c75e45ba3e6e47a8430R188-R194,
maybe you have a better idea for this test config snippet.
> Use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Minor
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHARED-480) use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561713#comment-17561713
]
Herve Boutemy edited comment on MSHARED-480 at 7/2/22 6:39 AM:
---
yes, let's stop trying to make a standalone report mojo look like if it was
done part of a site: standalone is standalone
having a standalone-oriented output will clarify many things, and finally
improve user experience
in fact, this issue should be reoriented toward defining the standalone report
look and feel
was (Author: hboutemy):
yes, let's stop trying to make a standalone report mojo look like if it was
done part of a site: standalone is standalone
having a standalone-oriented output will clarify many things, and finally
improve user experience
> use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Herve Boutemy
>Priority: Minor
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHARED-480) use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561713#comment-17561713
]
Herve Boutemy edited comment on MSHARED-480 at 7/2/22 6:39 AM:
---
yes, let's stop trying to make a standalone report mojo look like if it was
done part of a site: standalone is standalone
having a standalone-oriented output will clarify many things, and finally
improve user experience
in fact, this issue should be superceeded by another defining the standalone
report look and feel
was (Author: hboutemy):
yes, let's stop trying to make a standalone report mojo look like if it was
done part of a site: standalone is standalone
having a standalone-oriented output will clarify many things, and finally
improve user experience
in fact, this issue should be reoriented toward defining the standalone report
look and feel
> use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Herve Boutemy
>Priority: Minor
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHARED-480) use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082042#comment-15082042
]
Michael Osipov edited comment on MSHARED-480 at 1/4/16 11:54 PM:
-
I had the very same idea recently. I am not very pleased about
{{SiteContext#templateName}} nor about the {{default-site.vm}} and its
resources in {{DefaultSiteRenderer}}. I do believe that skin-related must be in
the default skin and used through decoration model only. Of course, common
stuff like the GIFs are OK to be as default resources in Doxia Site Renderer.
Shouldn't we create another issue with DOXIASITETOOLS?
was (Author: michael-o):
I had the very same idea recently. I am not very pleased about
{{SiteContext#templateName}} nor abour the {{default-site.vm}} and its
resources in {{DefaultSiteRenderer}}. I do believe that skin-related must be in
the default skin and used through decoration model only. Of cource, common
stuff like the GIFs are OK to be as default resources in Site Renderer.
Shouldn't we create another issue with DOXIASITETOOLS?
> use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Hervé Boutemy
>
> currently, maven-site-renderer default skin is always used: would be more
> consistent if using site decoration consistently with maven-site-plugin
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
