[jira] [Comment Edited] (SUREFIRE-1527) Surefire does not discover junit5 test case when testng is in the classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798115#comment-16798115
]
Ilya Serbis edited comment on SUREFIRE-1527 at 3/21/19 3:11 PM:
I think the issue should be converted to bug.
Just faced with it having my JUnit 5 tests been turned off silently.
In my case the cause was Groovy 2.5.5 It's
[POM|https://repo1.maven.org/maven2/org/codehaus/groovy/groovy-all/2.5.5/groovy-all-2.5.5.pom]
has
{code:xml}
org.codehaus.groovy
groovy-testng
2.5.5
{code}
which references {{org.testng:testng}}
The issue is still reproducible on the latest Surefire 2.22.1 (as well as on
3.0.0-M3) and JUnit 5.4.1 (see demo project
[https://github.com/energister/surefire-1527])
was (Author: serdis):
I think the issue should be converted to bug.
Just faced with it having my JUnit 5 tests been turned off silently.
In my case the cause was Groovy 2.5.5 It's
[POM|https://repo1.maven.org/maven2/org/codehaus/groovy/groovy-all/2.5.5/groovy-all-2.5.5.pom]
has
{code:xml}
org.codehaus.groovy
groovy-testng
2.5.5
{code}
which references {{org.testng:testng}}
The issue is still reproducible on the latest Surefire 2.22.1 and JUnit 5.4.1
(see demo project https://github.com/energister/surefire-1527)
> Surefire does not discover junit5 test case when testng is in the classpath
> ---
>
> Key: SUREFIRE-1527
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1527
> Project: Maven Surefire
> Issue Type: Improvement
> Components: JUnit 5.x support, TestNG support
>Affects Versions: 2.22.0
>Reporter: Dan Tran
>Priority: Major
>
> My maven module uses junit5 but also has testng in its test classpath and my
> surefire does not specify any testng.xml files
> Looks like surefire only look for testng test cases
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1527) Surefire does not discover junit5 test case when testng is in the classpath
[ https://issues.apache.org/jira/browse/SUREFIRE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529216#comment-16529216 ] Olivier Lamy (*$^¨%`£) edited comment on SUREFIRE-1527 at 7/2/18 6:45 AM: -- [~dantran] what about a pull request or branch with the fix and a test to demonstrate the fix? was (Author: olamy): [~dantran] sounds good but what about a pull request or branch with the fix and a test to demonstrate the fix? > Surefire does not discover junit5 test case when testng is in the classpath > --- > > Key: SUREFIRE-1527 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1527 > Project: Maven Surefire > Issue Type: Improvement > Components: JUnit 5.x support, TestNG support >Affects Versions: 2.22.0 >Reporter: Dan Tran >Priority: Major > > My maven module uses junit5 but also has testng in its test classpath and my > surefire does not specify any testng.xml files > Looks like surefire only look for testng test cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1527) Surefire does not discover junit5 test case when testng is in the classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529019#comment-16529019
]
Dan Tran edited comment on SUREFIRE-1527 at 7/1/18 4:51 PM:
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
Another workaround at surefire configuration to force surefire not able to
detect the present of testng
{code:java}
org.testng:testng-ignore
{code}
was (Author: dantran):
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
Another workaround to force surefire not able to detect the present of testng
{code:java}
org.testng:testng-ignore
{code}
> Surefire does not discover junit5 test case when testng is in the classpath
> ---
>
> Key: SUREFIRE-1527
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1527
> Project: Maven Surefire
> Issue Type: Improvement
> Components: JUnit 5.x support, TestNG support
>Affects Versions: 2.22.0
>Reporter: Dan Tran
>Priority: Major
>
> My maven module uses junit5 but also has testng in its test classpath and my
> surefire does not specify any testng.xml files
> Looks like surefire only look for testng test cases
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1527) Surefire does not discover junit5 test case when testng is in the classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529019#comment-16529019
]
Dan Tran edited comment on SUREFIRE-1527 at 7/1/18 9:05 AM:
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
Another workaround to force surefire not able to detect the present of testng
{code:java}
org.testng:testng-ignore
{code}
was (Author: dantran):
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
Another workaround to force surefire not able to detect the present of testng
{code:java}
org.testng:testng-ignore
{code}
> Surefire does not discover junit5 test case when testng is in the classpath
> ---
>
> Key: SUREFIRE-1527
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1527
> Project: Maven Surefire
> Issue Type: Improvement
> Components: JUnit 5.x support, TestNG support
>Affects Versions: 2.22.0
>Reporter: Dan Tran
>Priority: Major
>
> My maven module uses junit5 but also has testng in its test classpath and my
> surefire does not specify any testng.xml files
> Looks like surefire only look for testng test cases
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1527) Surefire does not discover junit5 test case when testng is in the classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529019#comment-16529019
]
Dan Tran edited comment on SUREFIRE-1527 at 7/1/18 9:04 AM:
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
Another workaround to force surefire not able to detect the present of testng
{code:java}
org.testng:testng-ignore
{code}
was (Author: dantran):
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
> Surefire does not discover junit5 test case when testng is in the classpath
> ---
>
> Key: SUREFIRE-1527
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1527
> Project: Maven Surefire
> Issue Type: Improvement
> Components: JUnit 5.x support, TestNG support
>Affects Versions: 2.22.0
>Reporter: Dan Tran
>Priority: Major
>
> My maven module uses junit5 but also has testng in its test classpath and my
> surefire does not specify any testng.xml files
> Looks like surefire only look for testng test cases
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1527) Surefire does not discover junit5 test case when testng is in the classpath
[
https://issues.apache.org/jira/browse/SUREFIRE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529019#comment-16529019
]
Dan Tran edited comment on SUREFIRE-1527 at 7/1/18 9:04 AM:
Here is proposed fix at TestNgProviderInfo
{code:java}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}{code}
was (Author: dantran):
Here is proposed fix at TestNgProviderInfo
{code}
@Override
public boolean isApplicable()
{
return testNgArtifact != null && hasSuiteXmlFiles();
}
{code>
Another workaround to force surefire not able to detect the present of testng
{code:java}
org.testng:testng-ignore
{code}
> Surefire does not discover junit5 test case when testng is in the classpath
> ---
>
> Key: SUREFIRE-1527
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1527
> Project: Maven Surefire
> Issue Type: Improvement
> Components: JUnit 5.x support, TestNG support
>Affects Versions: 2.22.0
>Reporter: Dan Tran
>Priority: Major
>
> My maven module uses junit5 but also has testng in its test classpath and my
> surefire does not specify any testng.xml files
> Looks like surefire only look for testng test cases
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
