[jira] [Commented] (DOXIA-570) Unescaped links in xml based figureGraphics elements

2018-03-20 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407363#comment-16407363
 ] 

Hervé Boutemy commented on DOXIA-570:
-

I was able to reproduce the issue simply on m-pdf-p, running {{mvn -Ppdf}}
Then I applied your Doxia change: it does not fix the previous run...

did you manage to run a fixed m-pdf-p?

> Unescaped links in xml based figureGraphics elements
> 
>
> Key: DOXIA-570
> URL: https://issues.apache.org/jira/browse/DOXIA-570
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Modules
>Affects Versions: 1.8
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> While testing newer version of maven-pdf-plugin on a Maven site, I got 
> exception
> {noformat}
> org.xml.sax.SAXParseException; systemId: 
> file:/projects/maven/trunks/site/target/pdf/apache-maven.fo; lineNumber: 
> 43059; columnNumber: 97; The reference to entity "s" must end with the ';' 
> delimiter.
> {noformat}
> for transformation from FO to PDF for team-list file: output from the 
> reporting plugin has a image link for the Gravatar profile that contains 
> "?d=mm&s=60", that is correctly escaped in the HTML site 
> https://maven.apache.org/team-list.html but not in the FO source for creating 
> the pdf
> {noformat} src="http://www.gravatar.com/avatar/d035aeb839495240c58bbb03992ceda8?d=mm&s=60";
>  content-width="scale-down-to-fit" content-height="scale-down-to-fit" 
> height="100%" width="100%"/>{noformat}
> Problem exists for all xml-based modules: FO, Docbook, XDoc, XHTML
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DOXIA-570) Unescaped links in xml based figureGraphics elements

2018-03-20 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407329#comment-16407329
 ] 

Hervé Boutemy commented on DOXIA-570:
-

I was able to reproduce the issue on Maven website, with our profiles images 
https://maven.apache.org/team-list.html

What surprises me is that the escape is already done in the HTML website: when 
you tell that the issue exists for XHTML module, there may be a workaround 
somewhere that will do the escape twice if we add one level of escaping

we need to check the impact of the fix simultaneously on m-pdf-p and on m-site-p

> Unescaped links in xml based figureGraphics elements
> 
>
> Key: DOXIA-570
> URL: https://issues.apache.org/jira/browse/DOXIA-570
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Modules
>Affects Versions: 1.8
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> While testing newer version of maven-pdf-plugin on a Maven site, I got 
> exception
> {noformat}
> org.xml.sax.SAXParseException; systemId: 
> file:/projects/maven/trunks/site/target/pdf/apache-maven.fo; lineNumber: 
> 43059; columnNumber: 97; The reference to entity "s" must end with the ';' 
> delimiter.
> {noformat}
> for transformation from FO to PDF for team-list file: output from the 
> reporting plugin has a image link for the Gravatar profile that contains 
> "?d=mm&s=60", that is correctly escaped in the HTML site 
> https://maven.apache.org/team-list.html but not in the FO source for creating 
> the pdf
> Problem exists for all xml-based modules: FO, Docbook, XDoc, XHTML
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DOXIA-570) Unescaped links in xml based figureGraphics elements

2018-03-17 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403730#comment-16403730
 ] 

Hervé Boutemy commented on DOXIA-570:
-

shouldn't also other attributes be escaped? IIUC? this affects every XML 
attributes, isn't it?

And can you share the original project you tested? where did the value come 
from?

Lastly: is this issue related to something new or did it exist previously?

> Unescaped links in xml based figureGraphics elements
> 
>
> Key: DOXIA-570
> URL: https://issues.apache.org/jira/browse/DOXIA-570
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Modules
>Affects Versions: 1.8
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> While testing newer version of maven-pdf-plugin i got exception
> {{Caused by: org.xml.sax.SAXParseException: The reference to entity "s" must 
> end with the ';' delimiter.}}
> for transformation from FO to PDF for team-list file. Output from the 
> reporting plugin has a image link for the Gravatar profile that contains 
> "?d=mm&s=60"
> Problem exists for all xml-based modules: FO, Docbook, XDoc, XHTML
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DOXIA-570) Unescaped links in xml based figureGraphics elements

2018-02-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360118#comment-16360118
 ] 

ASF GitHub Bot commented on DOXIA-570:
--

slachiewicz opened a new pull request #9: [DOXIA-570] Escape links to xml based 
figureGraphics image elements
URL: https://github.com/apache/maven-doxia/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unescaped links in xml based figureGraphics elements
> 
>
> Key: DOXIA-570
> URL: https://issues.apache.org/jira/browse/DOXIA-570
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Modules
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> While testing newer version of maven-pdf-plugin i got exception
> {{Caused by: org.xml.sax.SAXParseException: The reference to entity "s" must 
> end with the ';' delimiter.}}
> for transformation from FO to PDF for team-list file. Output from the 
> reporting plugin has a image link for the Gravatar profile that contains 
> "?d=mm&s=60"
> Problem exists for all xml-based modules: FO, Docbook, XDoc, XHTML
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)