[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646017#comment-16646017 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon commented on a change in pull request #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as… URL: https://github.com/apache/maven-assembly-plugin/pull/5#discussion_r224324138 ## File path: pom.xml ## @@ -138,7 +138,7 @@ under the License. org.codehaus.plexus plexus-archiver - 3.6.0 + 3.6.1-SNAPSHOT Review comment: Hi @spiritualops , yes of course, I'm just waiting plexus release (maybe it's already done) to change this with the correct release version And I need help to maybe add some test, and for MDO Thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645230#comment-16645230 ] ASF GitHub Bot commented on MASSEMBLY-617: -- spiritualops commented on a change in pull request #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as… URL: https://github.com/apache/maven-assembly-plugin/pull/5#discussion_r224152292 ## File path: pom.xml ## @@ -138,7 +138,7 @@ under the License. org.codehaus.plexus plexus-archiver - 3.6.0 + 3.6.1-SNAPSHOT Review comment: Please don't use SNAPSHOT versions, as this could introduce instability at any given time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560656#comment-16560656 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as… URL: https://github.com/apache/maven-assembly-plugin/pull/5#issuecomment-408590464 Hi This need certainly to add test but I don't know where :( And in MDO it"s wrong in version and again I don't know what i must do in it Thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558879#comment-16558879 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon opened a new pull request #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as… URL: https://github.com/apache/maven-assembly-plugin/pull/5 …sembly plugin new version of PR #4 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529460#comment-16529460 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon commented on issue #4: [MASSEMBLY-617] add ability to give a fileSuffix to a FileSet URL: https://github.com/apache/maven-assembly-plugin/pull/4#issuecomment-401690432 Thx for your precious help, I will try to implement this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529382#comment-16529382 ] ASF GitHub Bot commented on MASSEMBLY-617: -- plamentotev commented on issue #4: [MASSEMBLY-617] add ability to give a fileSuffix to a FileSet URL: https://github.com/apache/maven-assembly-plugin/pull/4#issuecomment-401673740 No. `InputStreamTransformer` modifies the content of the file (like changing the line ending). `FileMapper` changes the file name based on some logic (so it is actually a file name mapper). You need to make a similar change to one already did. But instead of String you need to configure an array of [`org.codehaus.plexus.components.io.filemappers.FileMapper`](https://github.com/codehaus-plexus/plexus-io/blob/master/src/main/java/org/codehaus/plexus/components/io/filemappers/FileMapper.java). And after that you need to propagate the array to `AbstractPlexusIoResourceCollection`. I don't think `BaseFileSet` accepts `FileMapper[]` so I think you need to change it as well. Hope this helps. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529235#comment-16529235 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon commented on issue #4: [MASSEMBLY-617] add ability to give a fileSuffix to a FileSet URL: https://github.com/apache/maven-assembly-plugin/pull/4#issuecomment-401633614 I don't know a lot of things in this plugin. The InputStreamTransformer is not the same of the FileMapper right ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529232#comment-16529232 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon commented on issue #4: [MASSEMBLY-617] add ability to give a fileSuffix to a FileSet URL: https://github.com/apache/maven-assembly-plugin/pull/4#issuecomment-401632485 Hi Thank for your tips @plamentotev, I will take a look at FileMapper and see if I can update this PR to use directly it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529190#comment-16529190 ] ASF GitHub Bot commented on MASSEMBLY-617: -- plamentotev commented on issue #4: [MASSEMBLY-617] add ability to give a fileSuffix to a FileSet URL: https://github.com/apache/maven-assembly-plugin/pull/4#issuecomment-401623387 The same functionality can be achieved using `FileMapper`. It would be great if you consider implementing it using file mappers as that would solve other uses cases as well (for example [MASSEMBLY-886](https://issues.apache.org/jira/projects/MASSEMBLY/issues/MASSEMBLY-886)). For example on how to implement such functionality you can take a look here - https://www.mojohaus.org/xml-maven-plugin/examples/transform-change-extension.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519098#comment-16519098 ] ASF GitHub Bot commented on MASSEMBLY-617: -- tcollignon opened a new pull request #4: [MASSEMBLY-617] add ability to give a fileSuffix to a FileSet URL: https://github.com/apache/maven-assembly-plugin/pull/4 Hi In order to fix https://issues.apache.org/jira/browse/MASSEMBLY-617, I need to add a capability to add file suffix to a FileSet This PR add this feature, but it need https://github.com/sonatype/plexus-archiver/pull/25 and https://github.com/sonatype/plexus-io/pull/7 Tell me if something goes wrong This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519091#comment-16519091 ] thomas collignon commented on MASSEMBLY-617: Thx Michael I currently open PR in different project, tell me if something miss > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519020#comment-16519020 ] thomas collignon commented on MASSEMBLY-617: PR in plexus-io : https://github.com/sonatype/plexus-io/pull/7 > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-617) Add a suffix element in fileSet (same as destName in file)
[ https://issues.apache.org/jira/browse/MASSEMBLY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518972#comment-16518972 ] thomas collignon commented on MASSEMBLY-617: Hi I wish to reopen it please, How I can do it? Thx > Add a suffix element in fileSet (same as destName in file) > -- > > Key: MASSEMBLY-617 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-617 > Project: Maven Assembly Plugin > Issue Type: Wish >Affects Versions: 2.3 >Reporter: thomas collignon >Priority: Minor > > The purpose of the wish is to add a "fileSuffix" attribute in fileSet > descriptor. This will add a suffix in all files in the fileSet. > Exemple : > test.xml with TOTO suffix => testTOTO.xml (in the zip) > This is the same as destName in file descriptor but this is for all the files > in the fileSet. > I think this need to modify this jars too : > - plexus-io > - plexus-archiver > I have already made all of this modification and if you want the source code, > I can give you. > Regards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
