[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721703#comment-17721703 ] Slawomir Jaranowski commented on MASSEMBLY-843: --- [~abrarovm] - I have a plan to release in a few days, maybe today > finalName as readonly parameter makes common usecases very complicated > -- > > Key: MASSEMBLY-843 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-843 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.0 > > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721701#comment-17721701 ] Marat Abrarov commented on MASSEMBLY-843: - Hi [~sjaranowski], Are you aware of the schedule for release of Maven Assembly Plugin 3.6.0? This fix should help us to get rid of annoying build log messages which confuse my team members. Thank you. > finalName as readonly parameter makes common usecases very complicated > -- > > Key: MASSEMBLY-843 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-843 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.0 > > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719084#comment-17719084 ] ASF GitHub Bot commented on MASSEMBLY-843: -- slawekjaranowski merged PR #139: URL: https://github.com/apache/maven-assembly-plugin/pull/139 > finalName as readonly parameter makes common usecases very complicated > -- > > Key: MASSEMBLY-843 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-843 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Priority: Major > Fix For: 3.6.0 > > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717466#comment-17717466 ] ASF GitHub Bot commented on MASSEMBLY-843: -- slawekjaranowski opened a new pull request, #139: URL: https://github.com/apache/maven-assembly-plugin/pull/139 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > finalName as readonly parameter makes common usecases very complicated > -- > > Key: MASSEMBLY-843 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-843 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Priority: Major > Fix For: 3.6.0 > > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[
https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716368#comment-17716368
]
Slawomir Jaranowski commented on MASSEMBLY-843:
---
Because {{build/finalName}} and plugin {{configuration/finalName}} have only
impact on generated items in target - I'm for relax this restrictions and
simply allow to be writable.
Given example looks for me as reasonable for it:
https://issues.apache.org/jira/browse/MASSEMBLY-845?focusedCommentId=17685939=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17685939
> finalName as readonly parameter makes common usecases very complicated
> --
>
> Key: MASSEMBLY-843
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-843
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ulf Dreyer
>Priority: Major
>
> The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient:
> We need to create an archive with one stable name (independent of e.g.
> version) so we don't have to propagate these information to a bunch of
> scripts.
> The general solution (i.e. Stack-overflow) refers exactly to the finalName:
> [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin]
> *Please change finalName back to a settable property.*
> It being settable does not hurt anyone satisfied with the default naming
> convention but makes some usecases vastly simpler (otherwise you have to
> rename the artifact using yet another plugin or propagate version info
> possibly through a chain of scripts)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[
https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696156#comment-17696156
]
Christopher Tubbs commented on MASSEMBLY-843:
-
Using Maven 3.9.0 and maven-assembly-plugin 3.5.0, I see that using
{{finalName}} is generating a warning: "Parameter 'finalName' is read-only,
must not be used in configuration". However, using {{finalName}} appears to be
the only way you can change the name of the base directory inside the assembly
tarball, as per this StackOverflow answer:
[https://stackoverflow.com/a/12182912]
This needs to be settable, preferably without a warning, so we can override the
base directory name inside the assembly. I looked for other options that might
be able to do that, and I could not find any.
To be clear, \{{}} (\{{ ${project.build.finalName}
}}) does appear to be read-only, but I'm talking about
{{}} in the assembly, which is
generating the warning, even though setting it still works, so it appears to
now be a hidden undocumented feature, that generates the warning.
> finalName as readonly parameter makes common usecases very complicated
> --
>
> Key: MASSEMBLY-843
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-843
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ulf Dreyer
>Priority: Major
>
> The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient:
> We need to create an archive with one stable name (independent of e.g.
> version) so we don't have to propagate these information to a bunch of
> scripts.
> The general solution (i.e. Stack-overflow) refers exactly to the finalName:
> [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin]
> *Please change finalName back to a settable property.*
> It being settable does not hurt anyone satisfied with the default naming
> convention but makes some usecases vastly simpler (otherwise you have to
> rename the artifact using yet another plugin or propagate version info
> possibly through a chain of scripts)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
