[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[ https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696225#comment-17696225 ] Christopher Tubbs commented on MASSEMBLY-845: - This issue seems to be a duplicate of MASSEMBLY-843. It even has identical descriptions, but only slightly different subject lines. One should be closed (typically for duplicates, the earliest one should be kept, but both have a fair number of comments in this case). > MASSEMBLY-817 makes some usecases very inconvenient > --- > > Key: MASSEMBLY-845 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-845 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Priority: Major > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[
https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685939#comment-17685939
]
Marat Abrarov commented on MASSEMBLY-845:
-
Hi [~khmarbaise], [~rfscholte-getthere] and [~afloom],
Here is my use-case of Maven Assembly Plugin, which relies on {{finalName}}
parameter:
[https://github.com/mabrarov/docker-compose-init-container/blob/master/app-image/pom.xml].
I use Maven Assembly Plugin to create multiple archives (with required
structure, directory and file permissions, directory and file timestamps, line
ending), which are later (within the same maven module) used in Dockerfile
[{{ADD}}|https://docs.docker.com/engine/reference/builder/#add] or
[{{COPY}}|https://docs.docker.com/engine/reference/builder/#copy] instructions
to place directories / files in the built (using
[docker-maven-plugin|https://github.com/fabric8io/docker-maven-plugin] and
generated Dockerfile) container image.
I also use Maven Assembly Plugin with {{finalName}} parameter to place all
packaged archives and Dockerfile (where I fill placeholders using filtering) in
a single directory which is used as Docker build context.
This way my builds on Windows host (using remote Docker engine which can be
running in a local VM with Linux) and on Linux hosts (using remote or local
Docker engine) are identical, OS independent (comparing to {{docker build}}
command) and reproducible.
Taking into account that Maven Assembly Plugin still supports
[{{outputDirectory}}|https://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#outputDirectory]
parameter (which can replace {{finalName}} parameter for my use case, but it
will complicate maven project and Dockerfile), I find deprecation of
{{finalName}} parameter (MASSEMBLY-817) meaningless.
I vote to make {{finalName}} back editable, or at least consider it editable if
{{attach}} is {{{}false{}}}.
Thank you.
> MASSEMBLY-817 makes some usecases very inconvenient
> ---
>
> Key: MASSEMBLY-845
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-845
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ulf Dreyer
>Priority: Major
>
> The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient:
> We need to create an archive with one stable name (independent of e.g.
> version) so we don't have to propagate these information to a bunch of
> scripts.
> The general solution (i.e. Stack-overflow) refers exactly to the finalName:
> [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin]
> *Please change finalName back to a settable property.*
> It being settable does not hurt anyone satisfied with the default naming
> convention but makes some usecases vastly simpler (otherwise you have to
> rename the artifact using yet another plugin or propagate version info
> possibly through a chain of scripts)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[ https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458589#comment-16458589 ] Robin Björklin commented on MASSEMBLY-845: -- I have to redact my previous statement. After a deeper dive I found the solution here: [https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html] where lines 103-112 solve my problem thanks to "destName". From my perspective this issue can be closed. > MASSEMBLY-817 makes some usecases very inconvenient > --- > > Key: MASSEMBLY-845 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-845 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Priority: Major > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[ https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426846#comment-16426846 ] Karl Heinz Marbaise commented on MASSEMBLY-845: --- Can you make an example project which shows your use case (with maven-assembly-plugin 2.6) and a little bit more description why you need to set the different names and can't cope with the default ? > MASSEMBLY-817 makes some usecases very inconvenient > --- > > Key: MASSEMBLY-845 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-845 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Priority: Major > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[ https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426841#comment-16426841 ] Robin Björklin commented on MASSEMBLY-845: -- We have this problem as well. One of our projects is creating three artifacts and not being able to set a name for each one of these has kept us on 2.6 for years now. In 2.6 we just use the execution as a name but since 3.0.0 also the files now get named like this: -.jar and we have no control over this. A fix would be much appreciated. > MASSEMBLY-817 makes some usecases very inconvenient > --- > > Key: MASSEMBLY-845 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-845 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Priority: Major > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[ https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052880#comment-16052880 ] Giedrius Noreikis commented on MASSEMBLY-845: - In our case we need to set a name of a zip assembly (without renaming a jar). > MASSEMBLY-817 makes some usecases very inconvenient > --- > > Key: MASSEMBLY-845 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-845 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MASSEMBLY-845) MASSEMBLY-817 makes some usecases very inconvenient
[
https://issues.apache.org/jira/browse/MASSEMBLY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052801#comment-16052801
]
Karl Heinz Marbaise commented on MASSEMBLY-845:
---
It is not prevented to use:
{code:xml}
ToWhatEverYouLike
...
{code}
This only changes the name of the resulting artifact in the target folder
nothing more...
To be honest I don't see a real issue here?
> MASSEMBLY-817 makes some usecases very inconvenient
> ---
>
> Key: MASSEMBLY-845
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-845
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ulf Dreyer
>
> The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient:
> We need to create an archive with one stable name (independent of e.g.
> version) so we don't have to propagate these information to a bunch of
> scripts.
> The general solution (i.e. Stack-overflow) refers exactly to the finalName:
> [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin]
> *Please change finalName back to a settable property.*
> It being settable does not hurt anyone satisfied with the default naming
> convention but makes some usecases vastly simpler (otherwise you have to
> rename the artifact using yet another plugin or propagate version info
> possibly through a chain of scripts)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
