[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391433#comment-16391433
]
Jason Cote commented on MASSEMBLY-875:
--
Seems related to MASSEMBLY-873 - turns out Stu's example dependency
({{browsermob-core}}) itself actually depends on bouncy castle, which seems to
be the culprit.
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
> Attachments: mvn_package_2.6.log, mvn_package_3.1.0.log
>
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391390#comment-16391390
]
Jason Cote commented on MASSEMBLY-875:
--
Attaching a couple profiler outputs for {{mvn package}} operation, with the
only difference being the version of {{maven-assembly-plugin}} used.
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
> Attachments: mvn_package_2.6.log, mvn_package_3.1.0.log
>
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390327#comment-16390327
]
Jason Cote commented on MASSEMBLY-875:
--
I am noticing the same poor assembly performance in one of my projects after
adding a certain dependency (Bouncycastle in this case):
{code:xml}
org.bouncycastle
bcprov-jdk15on
1.59
{code}
Now when doing a {{mvn package}} to build a fat jar using maven-assembly-plugin
3.1.0, the process takes 2+ minutes.
If downgrade to version 2.6 it only take ~12 seconds. Alternatively changing
to use the maven-shade-plugin instead can also produce the jar for me in ~10
seconds.
I can work on putting together a public repo to reproduce if needed.
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359631#comment-16359631
]
Karl Heinz Marbaise commented on MASSEMBLY-875:
---
Sorry the profiler is only available in version 0.1.0 from central (Doc
issue)...
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359052#comment-16359052
]
Stu commented on MASSEMBLY-875:
---
Tried to run with profiler, but:
{code:java}
[WARNING] Failed to read extensions descriptor
/home/stuart.smith/.mvn/extensions.xml: Plugin
com.soebes.maven.extensions:maven-buildtime-profiler:0.2.0 or one of its
dependencies could not be resolved: Could not find artifact
com.soebes.maven.extensions:maven-buildtime-profiler:jar:0.2.0 in central{code}
But you can just build it and see that almost all the time is spend on the
"Building jar.. -with-dependencies.jar" step
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359046#comment-16359046
]
Stu commented on MASSEMBLY-875:
---
Ok, narrowed it down to one dependency in our lib that seems to be tripping the
perf issues in maven 3.x.x:
{code}
net.lightbody.bmp
browsermob-core
2.1.5
{code}
So if you create an empty project like so:
{code}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.shareplaylearn
MASSEMBLY-875
1.1-SNAPSHOT
jar
MASSEMBLY-875
http://maven.apache.org
org.apache.maven.plugins
maven-compiler-plugin
3.1
1.8
1.8
maven-assembly-plugin
3.1.0
jar-with-dependencies
make-assembly
package
single
UTF-8
net.lightbody.bmp
browsermob-core
2.1.5
{code}
Maven assembly 3.1.0:
{code}
[INFO] Building jar:
/home/stuart.smith/workspace/MASSEMBLY875/target/MASSEMBLY-875-1.1-SNAPSHOT-jar-with-dependencies.jar
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 01:39 min
[INFO] Finished at: 2018-02-09T14:14:46-08:00
[INFO] Final Memory: 252M/2695M
[INFO]
{code}
maven assembly 2.6:
{code}
[INFO] --- maven-assembly-plugin:2.6:single (make-assembly) @ MASSEMBLY-875 ---
[INFO] Building jar:
/home/stuart.smith/workspace/MASSEMBLY875/target/MASSEMBLY-875-1.1-SNAPSHOT-jar-with-dependencies.jar
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 2.548 s
[INFO] Finished at: 2018-02-09T14:12:23-08:00
[INFO] Final Memory: 61M/546M
[INFO]
{code}
Also of note:
- each build was triggered with:
{code}
mvn clean && mvn package
{code}
- I ran 3.1.0, 2.6, and then 3.1.0 again. The final run of 3.1.0 is what I used.
- the above ensured dependencies were already downloaded
- the build process is visibly getting stuck on this step in 3.1.0
{code}
[INFO] Building jar:
/home/stuart.smith/workspace/MASSEMBLY875/target/MASSEMBLY-875-1.1-SNAPSHOT-jar-with-dependencies.jar
{code}
- Check out the increased memory usage in 3.1.0 !!!
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359035#comment-16359035
]
Stu commented on MASSEMBLY-875:
---
Ok, I'll get this pushed to a public repo, but for now, I created an empty
project (using maven-archetype-quickstart, and deleting the tests):
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.shareplaylearn
MASSEMBLY-875
1.1-SNAPSHOT
jar
MASSEMBLY-875
http://maven.apache.org
org.apache.maven.plugins
maven-compiler-plugin
3.1
1.8
1.8
maven-assembly-plugin
3.1.0
jar-with-dependencies
make-assembly
package
single
UTF-8
com.shareplaylearn
MASSEMBLY-875-lib
1.2-SNAPSHOT
io.netty
netty-all
{code}
I then created another dummy project (no source code) for the lib:
{code}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.shareplaylearn
MASSEMBLY-875-lib
1.2-SNAPSHOT
jar
MASSEMBLY-875-lib
http://maven.apache.org
UTF-8
org.apache.maven.plugins
maven-compiler-plugin
3.1
1.8
1.8
org.apache.maven.plugins
maven-source-plugin
3.0.1
attach-source
verify
jar-no-fork
com.google.code.gson
gson
2.8.2
net.lightbody.bmp
browsermob-core
2.1.5
junit
junit
4.12
test
org.mockito
mockito-core
2.13.0
test
{code}
I deployed the lib to a local repo, and then built the original project.
With maven assembly 3.1.0 -> over a minute to build the final
-with-dependencies jar (close to 2 min!):
{code}
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 01:42 min
[INFO] Finished at: 2018-02-09T14:05:14-08:00
[INFO] Final Memory: 211M/2644M
{code}
With maven assembly 2.6 -> a little over 2 seconds.
{code}
[INFO] Building jar:
/home/stuart.smith/workspace/MASSEMBLY875/target/MASSEMBLY-875-1.1-SNAPSHOT-jar-with-dependencies.jar
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 2.231 s
[INFO] Finished at: 2018-02-09T14:06:34-08:00
[INFO] Final Memory: 56M/408M
{code}
I'll start whittling away the dependencies in the lib, and see what happens
there.
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348102#comment-16348102
]
Hervé Boutemy commented on MASSEMBLY-875:
-
please share a test project and the result of execution of
maven-buildtime-profiler to give us more precise and reproducible case and more
precise facts
with the textual description, we see the general idea but nothing to really dig
into: help us so we can help you
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347731#comment-16347731
]
Stu commented on MASSEMBLY-875:
---
[~khmarbaise] - all your questions were already directly answered in the
description.
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-875) Maven 3.x is about 10x slower than 2.6
[
https://issues.apache.org/jira/browse/MASSEMBLY-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343977#comment-16343977
]
Karl Heinz Marbaise commented on MASSEMBLY-875:
---
I recommend to first check via
https://github.com/khmarbaise/maven-buildtime-profiler apart from that the link
you have mentioned is about 5 years old and is related to maven-assembly-plugin
2.2 furthermore which maven version are you using ? How are the memory
settings? How many modules are you building ? How long is the build time
overall ?
> Maven 3.x is about 10x slower than 2.6
> --
>
> Key: MASSEMBLY-875
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-875
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Reporter: Stu
>Priority: Minor
>
> In all our java projects, we have a fairly basic assembly configuration,
> something like this:
> {code:java}
>
> maven-assembly-plugin
> 2.6
>
>
>
> org.x.x.x
>
>
>
> jar-with-dependencies
>
>
>
>
> make-assembly
> package
>
> single
>
>
>
> {code}
> They all take about 10x longer with any 3.x.x version of the maven assembly
> plugin than the 2.6 version.
> This has been noticed by others:
> [https://stackoverflow.com/questions/9009232/what-sort-of-configuration-issues-or-problems-might-make-maven-assembly-plugin-g/24519615#24519615]
> But not reported as a bug that I could find.
> Although I could only justify "Minor" for the priority, this is really is a
> blocker for us moving to 3.x.x
> The upgrade is just not worth taking your build from < 10 sec to > 50 sec.
> (For this particular build, it went from about ~ 7 sec to ~ 57 sec.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
