[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[
https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639508#comment-17639508
]
Michael Osipov commented on MASSEMBLY-969:
--
The IT is flawed. It isn't portable:
{noformat}
[ERROR] Failed to execute goal on project massembly-969: Could not resolve
dependencies for project test:massembly-969:jar:1: The following artifacts
could not be resolved: org.openjfx:javafx-base:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-controls:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-web:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-media:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-swing:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-graphics:jar:${javafx.platform}:18.0.1: Could not find
artifact org.openjfx:javafx-base:jar:${javafx.platform}:18.0.1 in local.central
(file:///home/mosipov/.m2/repository) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
on project massembly-969: Could not resolve dependencies for project
test:massembly-969:jar:1: The following artifacts could not be resolved:
org.openjfx:javafx-base:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-controls:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-web:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-media:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-swing:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-graphics:jar:${javafx.platform}:18.0.1: Could not find
artifact org.openjfx:javafx-base:jar:${javafx.platform}:18.0.1 in local.central
(file:///home/mosipov/.m2/repository)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
(LifecycleDependencyResolver.java:269)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
(LifecycleDependencyResolver.java:147)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
(MojoExecutor.java:248)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:202)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)
Caused by: org.apache.maven.project.DependencyResolutionException: Could not
resolve dependencies for project test:massembly-969:jar:1: The following
artifacts could not be resolved:
org.openjfx:javafx-base:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-controls:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-web:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-media:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-swing:jar:${javafx.platform}:18.0.1,
org.openjfx:javafx-graphics:jar:${javafx.platform}:18.0.1: Could not find
artifact org.openjfx:javafx-base:jar:${javafx.platform}:18.0.1 in local.central
(file:///home/mosipov/.m2/repository)
at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve
(DefaultProjectDependenciesResolver.java:209)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
(LifecycleDependencyResolver.java:243)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
(LifecycleDependencyResolver.java:147)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
(MojoExecutor.java:248)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568995#comment-17568995 ] Hudson commented on MASSEMBLY-969: -- Build failed in Jenkins: Maven » Maven TLP » maven-assembly-plugin » master #25 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-assembly-plugin/job/master/25/ > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567494#comment-17567494 ] Per Nyfelt commented on MASSEMBLY-969: -- Thank you, i can confirm that switching to GATCV (and GATV where appropriate) works fine on 3.4.1 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567461#comment-17567461 ] Tamás Cservenák commented on MASSEMBLY-969: --- Summary: problem is in shared component, this fixes it: [https://github.com/apache/maven-common-artifact-filters/pull/29] Solution for m-assembly-p is update (once released) the shared component (and added IT): https://github.com/apache/maven-assembly-plugin/pull/83 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567460#comment-17567460 ] Tamás Cservenák commented on MASSEMBLY-969: --- Created IT based on supplied pom and assembly descriptor > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567455#comment-17567455 ] Tamás Cservenák commented on MASSEMBLY-969: --- Tested on provided test project, it works as expected. > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567404#comment-17567404 ] Tamás Cservenák commented on MASSEMBLY-969: --- Not full tested (end to end) but this may solve the problem: https://github.com/apache/maven-common-artifact-filters/pull/29 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[
https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567400#comment-17567400
]
Tamás Cservenák commented on MASSEMBLY-969:
---
No, it is about patterns implementation (vs documentation). The patterns are
not well defined.
For your use case would be simplest if you'd extend your excludes to 5 elements
(GATCV) by simply suffixing them with {{{}$\{javafx.version{.
You can check what happens for 5 element, 4 element, etc (so how many delimited
parts pattern have) here:
[https://github.com/apache/maven-common-artifact-filters/blob/master/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java#L356]
We had discussions about these, and definitely these patterns were never
properly defined (they were maybe even self contradicting), but latest changes
tried to add self-describing code at at least (at most probably loosing some
"well hidden" functionality).
Personally, in my projects I always try to use "most specific" GATCV or GATV
(no classifier) pattern, while you used GATC pattern, that is not same as GATV.
> Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
> -
>
> Key: MASSEMBLY-969
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-969
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: dependencySet
>Affects Versions: 3.4.1
> Environment: Apache Maven 3.8.5
> (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Java version: 17.0.3, vendor: BellSoft
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix"
>Reporter: Per Nyfelt
>Priority: Critical
> Attachments: assembly.xml, pom.xml
>
>
> In 3.3.0 i can do the following to get the java fx base jar + the platform
> specific jar into one directory (i have 3 similar dependency sets for each
> platform so I can set the module-path to that directory depending on the os):
>
> false
> runtime
> lib/linux
> false
>
> org.openjfx:javafx-base
> org.openjfx:javafx-controls
> org.openjfx:javafx-media
> org.openjfx:javafx-web
> org.openjfx:javafx-swing
> org.openjfx:javafx-graphics:jar:linux
>
>
> org.openjfx:javafx-base:jar:mac
> org.openjfx:javafx-base:jar:win
> org.openjfx:javafx-controls:jar:mac
> org.openjfx:javafx-controls:jar:win
> org.openjfx:javafx-media:jar:mac
> org.openjfx:javafx-media:jar:win
> org.openjfx:javafx-web:jar:mac
> org.openjfx:javafx-web:jar:win
> org.openjfx:javafx-swing:jar:mac
> org.openjfx:javafx-swing:jar:win
>
>
>
> in 3.3.0 this gives me the following jars:
> javafx-base-18.0.1.jar
> javafx-controls-18.0.1-linux.jar
> javafx-media-18.0.1-linux.jar
> javafx-web-18.0.1.jar
> javafx-base-18.0.1-linux.jar
> javafx-graphics-18.0.1-linux.jar
> javafx-swing-18.0.1.jar
> javafx-web-18.0.1-linux.jar
> javafx-controls-18.0.1.jar
> javafx-media-18.0.1.jar
> javafx-swing-18.0.1-linux.jar
> However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get
> ALL of the jar i.e.
> javafx-base-18.0.1.jar
> javafx-base-18.0.1-linux.jar
> javafx-base-18.0.1-mac.jar
> javafx-base-18.0.1-win.jar
> javafx-controls-18.0.1.jar
> javafx-controls-18.0.1-linux.jar
> javafx-controls-18.0.1-mac.jar
> javafx-controls-18.0.1-win.jar
> javafx-media-18.0.1.jar
> javafx-media-18.0.1-linux.jar
> javafx-media-18.0.1-mac.jar
> javafx-media-18.0.1-win.jar
> javafx-swing-18.0.1.jar
> javafx-swing-18.0.1-linux.jar
> javafx-swing-18.0.1-mac.jar
> javafx-swing-18.0.1-win.jar
> javafx-web-18.0.1.jar
> javafx-web-18.0.1-linux.jar
> javafx-web-18.0.1-mac.jar
> javafx-web-18.0.1-win.jar
>
> The assembly plugin also complains about this:
> [WARNING] The following patterns were never triggered in this artifact
> inclusion filter:
> o 'org.openjfx:javafx-graphics:jar:linux'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.openjfx:javafx-base:jar:mac'
> o 'org.openjfx:javafx-base:jar:win'
> o 'org.openjfx:javafx-controls:jar:mac'
> o 'org.openjfx:javafx-controls:jar:win'
> o 'org.openjfx:javafx-media:jar:mac'
> o 'org.openjfx:javafx-media:jar:win'
> o 'org.openjfx:javafx-web:jar:mac'
> o 'org.openjfx:javafx-web:jar:win'
> o 'org.openjfx:javafx-swing:jar:mac'
> o 'org.openjfx:javafx-swing:jar:win'
> I think that this is either a bug in the code or the documentation for how to
> combine inclusions and exclusions to get the desired effect. The full pom.xml
> and assembly.xml is attached for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567380#comment-17567380 ] Michael Osipov commented on MASSEMBLY-969: -- [~cstamas] > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
