[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753276#comment-17753276 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- slachiewicz merged PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86 > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: pull-request-available > Fix For: 1.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742769#comment-17742769 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- elharo commented on code in PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86#discussion_r1262427903 ## src/test/java/org/apache/maven/buildcache/LifecyclePhasesHelperTest.java: ## @@ -19,9 +19,9 @@ package org.apache.maven.buildcache; import java.util.ArrayList; Review Comment: Yes, it's used in a couple of unchanged lines in this class > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742657#comment-17742657 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- ferdnyc commented on PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86#issuecomment-1633517427 I'm with @elharo — I _hate_ merging my own code to a public repo, and will generally only do it if it's a non-code change or I can definitively state that merging won't impact other users. Otherwise, I figure a second pair of eyes is a sensible precaution on almost **any** code change, and when there are multiple people with commit access a good general rule is to have someone other than the PR author do the merge. I try to review others' changes as much as I can, in the hopes they'll return the favor. In that spirit, I've pitched in with an inexpert review of the changes here. > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742656#comment-17742656 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- ferdnyc commented on code in PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86#discussion_r1261953392 ## src/test/java/org/apache/maven/buildcache/LifecyclePhasesHelperTest.java: ## @@ -19,9 +19,9 @@ package org.apache.maven.buildcache; import java.util.ArrayList; Review Comment: I notice you left the `ArrayList` import here (as opposed to in the other files), is that still needed? > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733737#comment-17733737 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- elharo commented on PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86#issuecomment-1595703835 I can't agree with that. Code review is essential. If it's that trivial, then it's an easy review. If it isn't, it needs review all the more. I've certainly noticed more than one mistake in Maven when code review was skipped, both by myself and others. > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731285#comment-17731285 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- olamy commented on PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86#issuecomment-1585869287 > ping why ping? if CI is green just merge it. no need to ask review for such a minor change because it's just modifying test sources not sure you need to ping people to validate this. > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-60) Remove Guava dependency
[ https://issues.apache.org/jira/browse/MBUILDCACHE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731191#comment-17731191 ] ASF GitHub Bot commented on MBUILDCACHE-60: --- elharo commented on PR #86: URL: https://github.com/apache/maven-build-cache-extension/pull/86#issuecomment-1585620617 ping > Remove Guava dependency > --- > > Key: MBUILDCACHE-60 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-60 > Project: Maven Build Cache Extension > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
