[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776836#comment-17776836 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769070764 > > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > > > > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. > > Yes make sense. > > Can you update documentation? https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html (source in project src/site/apt/examples/delete_additional_files.apt.vm) > > We should explain such behaviors. I have added a note to the `delete_additional_files.apt.vm`. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776834#comment-17776834 ] ASF GitHub Bot commented on MCLEAN-111: --- chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769067418 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. I agree. Looks like fast delete has always required `GlobSelector` to be null, since it was added in #6. So, it has never worked for this `Fileset` parsing path, only the directory parsing path above it at: https://github.com/apache/maven-clean-plugin/blob/f9da326e1b1ad4648d24e646b51cc7bc0a1baad7/src/main/java/org/apache/maven/plugins/clean/CleanMojo.java#L250-L254 > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776830#comment-17776830 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769046065 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. Yes make sense. Can you update documentation? https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html (source in project src/site/apt/examples/delete_additional_files.apt.vm) We should explain such behaviors. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776829#comment-17776829 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364294236 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: Fixed. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776818#comment-17776818 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769003627 > So it looks like when we use includes/excludes fastDelete will not works - correct? Yes and it makes sense. The fast delete moves the entire directory. If you want to delete only some files, you cannot move the directory because the files that should stay there would not. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776816#comment-17776816 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364259343 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: should be `@project.version@` ... in other tests we need fix also - but in separate PR 😄 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + fast-delete + 1.0-SNAPSHOT + + Fast delete + Check that fast delete is invoked. + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-clean-plugin + @pom.version@ Review Comment: should be `@project.version@` ... in other tests we need fix also - but in separate PR 😄 > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776815#comment-17776815 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768998145 So it looks like when we use includes/excludes fastDelete will not works - correct? > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776773#comment-17776773 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768876305 > Is this a symptom of `GlobSelector` not working on Windows at all? Good point - it should be also checked. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776742#comment-17776742 ] ASF GitHub Bot commented on MCLEAN-111: --- chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768742507 Is this a symptom of `GlobSelector` not working on Windows at all? > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776707#comment-17776707 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363961577 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: Fixed. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776706#comment-17776706 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363956331 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: missed license header 😄 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: missed license header 😄 > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776687#comment-17776687 ] ASF GitHub Bot commented on MCLEAN-111: --- wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768492359 @slawekjaranowski I have added the test. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > Fix For: next-release > > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1777#comment-1777 ] ASF GitHub Bot commented on MCLEAN-111: --- slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768441320 @wilx thanks Is it possible to make an IT to be sure for regressions with next changes? > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > Labels: pull-request-available > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCLEAN-111) Fast clean does not work delete files in the background but in foreground.
[ https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776638#comment-17776638 ] Václav Haisman commented on MCLEAN-111: --- The linked pull request fixes the issue for me. > Fast clean does not work delete files in the background but in foreground. > -- > > Key: MCLEAN-111 > URL: https://issues.apache.org/jira/browse/MCLEAN-111 > Project: Maven Clean Plugin > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Václav Haisman >Priority: Major > > The plugin is supposed to move directories away and then delete the files in > background. That functionality is broken because an instance of GlobSelector > is always passed down to the Cleaner instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
