[jira] [Commented] (MCOMPILER-306) Incorrect `compilerArgs` example usage

2018-11-13 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685986#comment-16685986
 ] 

Hudson commented on MCOMPILER-306:
--

Build succeeded in Jenkins: Maven TLP » maven-compiler-plugin » master #78

See 
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/master/78/

> Incorrect `compilerArgs` example usage
> --
>
> Key: MCOMPILER-306
> URL: https://issues.apache.org/jira/browse/MCOMPILER-306
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Stephan Schroevers
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.8.1
>
>
> The {{compilerArgs}} property documentation 
> [contains|https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerArgs]
>  this example usage:
> {code:xml}
> 
>   -Xmaxerrs=1000
>   -Xlint
>   -J-Duser.language=en_us
> 
> {code}
> But setting {{-Xmaxerrs=1000}} causes:
> {noformat}
>   ...
> Caused by: java.lang.IllegalArgumentException: invalid flag: -Xmaxerrs=1000
>   at com.sun.tools.javac.api.JavacTool.processOptions(JavacTool.java:206)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:156)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:107)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:64)
>   at 
> org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:125)
>   ... 16 more
> {noformat}
> This does work:
> {code:xml}
> 
>   -Xmaxerrs
>   1000
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-306) Incorrect `compilerArgs` example usage

2018-11-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685977#comment-16685977
 ] 

ASF GitHub Bot commented on MCOMPILER-306:
--

olamy closed pull request #9: [MCOMPILER-306] Fix `compilerArgs` example usage
URL: https://github.com/apache/maven-compiler-plugin/pull/9
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java 
b/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
index 9295499..d898020 100644
--- a/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
+++ b/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
@@ -336,7 +336,8 @@
  * Example:
  * 
  * compilerArgs
- *   arg-Xmaxerrs=1000/arg
+ *   arg-Xmaxerrs/arg
+ *   arg1000/arg
  *   arg-Xlint/arg
  *   arg-J-Duser.language=en_us/arg
  * /compilerArgs


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incorrect `compilerArgs` example usage
> --
>
> Key: MCOMPILER-306
> URL: https://issues.apache.org/jira/browse/MCOMPILER-306
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Stephan Schroevers
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.8.1
>
>
> The {{compilerArgs}} property documentation 
> [contains|https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerArgs]
>  this example usage:
> {code:xml}
> 
>   -Xmaxerrs=1000
>   -Xlint
>   -J-Duser.language=en_us
> 
> {code}
> But setting {{-Xmaxerrs=1000}} causes:
> {noformat}
>   ...
> Caused by: java.lang.IllegalArgumentException: invalid flag: -Xmaxerrs=1000
>   at com.sun.tools.javac.api.JavacTool.processOptions(JavacTool.java:206)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:156)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:107)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:64)
>   at 
> org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:125)
>   ... 16 more
> {noformat}
> This does work:
> {code:xml}
> 
>   -Xmaxerrs
>   1000
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-306) Incorrect `compilerArgs` example usage

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682934#comment-16682934
 ] 

ASF GitHub Bot commented on MCOMPILER-306:
--

Stephan202 opened a new pull request #9: [MCOMPILER-306] Fix `compilerArgs` 
example usage
URL: https://github.com/apache/maven-compiler-plugin/pull/9
 
 
   This is a resubmission of PR apache/maven-plugins#126.
   
   I hereby declare this contribution to be licenced under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incorrect `compilerArgs` example usage
> --
>
> Key: MCOMPILER-306
> URL: https://issues.apache.org/jira/browse/MCOMPILER-306
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Stephan Schroevers
>Priority: Major
>
> The {{compilerArgs}} property documentation 
> [contains|https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerArgs]
>  this example usage:
> {code:xml}
> 
>   -Xmaxerrs=1000
>   -Xlint
>   -J-Duser.language=en_us
> 
> {code}
> But setting {{-Xmaxerrs=1000}} causes:
> {noformat}
>   ...
> Caused by: java.lang.IllegalArgumentException: invalid flag: -Xmaxerrs=1000
>   at com.sun.tools.javac.api.JavacTool.processOptions(JavacTool.java:206)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:156)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:107)
>   at com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:64)
>   at 
> org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:125)
>   ... 16 more
> {noformat}
> This does work:
> {code:xml}
> 
>   -Xmaxerrs
>   1000
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)