[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-09 Thread Falko Modler (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804814#comment-17804814
 ] 

Falko Modler commented on MCOMPILER-391:


Heads-up: m2e in Eclipse IDE  needs an adjustment to be able to cope with such 
annotationProcessorPaths without version: 
https://github.com/eclipse-m2e/m2e-core/issues/1644

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803228#comment-17803228
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

psiroky commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1877354179

   Ah, I see. In that case you are right, the relocation message should be 
there. I'll see if I can find some time to take a look at this.




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803209#comment-17803209
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

famod commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1877280262

   > I think the missing relocation warning has the same cause - the plugin (or 
more precisely the dependency resolution mechanism the plugin uses) simply does 
not know that the artifact was relocated, because without version, it cannot 
fetch the relocation config.
   > 
   > I believe the relocation warning gets printed in case you depend on the 
old artifact, but the version must be known, explicitly or via depMgmt: e.g:
   > 
   > ```
   > 
   >   org.hibernate
   >   hibernate-jpamodelgen
   >   6.0.0
   > ```
   > 
   > In that case, the POM is fetched, relocation config found and the warning 
can be printed.
   
   I guess I should have been more precise:
   
   I had exactly that (only a version property instead of the version literal, 
but that shouldn't make any difference) and still no warning. Maven 3.9.6, btw.




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803199#comment-17803199
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

psiroky commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-187725

   Yeah, there could possibly be some sort of heuristics to try to detect these 
relocations. Not sure if this would be something that should be done directly 
in the plugin or rather left to the dependency resolver.
   
   I think the missing relocation warning has the same cause - the plugin (or 
more precisely the dependency resolution mechanism the plugin uses) simply does 
not know that the artifact was relocated, because without version, it cannot 
fetch the relocation config.
   
   I believe the relocation warning gets printed in case you depend on the old 
artifact, but the version must be known, explicitly or via depMgmt: e.g:
   ```
   
 org.hibernate
 hibernate-jpamodelgen
 6.0.0
   ```
   In that case, the POM is fetched, relocation config found and the warning 
can be printed.




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803175#comment-17803175
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

famod commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1877127524

   @psiroky 
   
   Yeah, I think you have a very valid point: There is no explicit version for 
that old groupId and so there is no precise way to find the exact pom with the 
relocation info (=> new groupId).
   As a human you could just check the latest version for the old groupId and 
get the relocation info from that but I doubt there is a nice way of finding 
the latest version via Maven builtin features (?).
   Not worth the hassle.
   
   For extra user-friendliness this plugin could check (if no version is found) 
for _similar_ deps, e.g. same artifactId but differen groupId and print put all 
those candidates, but relocations are not limited to groupIds (AFAIK), so...
   
   It probably boils down to the question why there are/were no relocations 
warnings like you get for "normal" dependencies. For general plugin 
dependencies that's clearly something that Maven should cover.
   `annotationProcessorPaths` is probably a different story.




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803039#comment-17803039
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

psiroky commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1876984635

   @famod thanks. In this case, I am not quite sure this is supported from 
Maven itself.
   
   I assume there is no version anywhere in the project depMgmt for 
`org.hibernate:hibernate-jpamodelgen` and so there is also no information which 
could map it to the new artifact `org.hibernate.orm:hibernate-jpamodelgen`. 
That mapping information is part of the old / original POM, but since the 
plugin does not have the version for this old artifact, it cannot lookup the 
POM with the relocation config.
   
   Does that make sense? Or am I overlooking something in the setup?
   
   Or this perhaps something that is working for you outside of the compiler 
plugin configuration with standard project dependencies?




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802972#comment-17802972
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

famod commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1876946809

   @psiroky sure:
   > Are you relying on the new dependency management
   
   Yes, that's what I tried and this doesn't work (old groupId):
   ```xml
   
   
   
   org.hibernate
   hibernate-jpamodelgen
   
   ```
   but this does work (new, relocated groupId):
   ```
   
   ```
   
   
   
   org.hibernate.orm
   hibernate-jpamodelgen
   
   ```
   The Quarkus BOM I'm importing has this entry (new groupId only!):
   
https://github.com/quarkusio/quarkus/blob/3.6.4/bom/application/pom.xml#L5012-L5014




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802947#comment-17802947
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

psiroky commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1876936773

   @famod could you please provide a bit more details, maybe with an example 
configuration of the plugin? Are you relying on the new dependency management, 
or specifying the version manually as before?




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2024-01-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802911#comment-17802911
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

famod commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1876921475

   Just a heads up: This implementation does not seem to respect relocations, 
e.g. I was still using 
https://mvnrepository.com/artifact/org.hibernate/hibernate-jpamodelgen in my 
plugin config but the Quarkus BOM contains (only) the new and proper group id 
`org.hibernate.orm` and not the old one ``org.hibernate.` and so the annotation 
processor path version lookup logic didn't find it. Took me a while to figure 
out.




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Slawomir Jaranowski
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2023-06-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729478#comment-17729478
 ] 

ASF GitHub Bot commented on MCOMPILER-391:
--

slawekjaranowski merged PR #180:
URL: https://github.com/apache/maven-compiler-plugin/pull/180




> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.12.0
>
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2023-03-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696485#comment-17696485
 ] 

Petr Široký commented on MCOMPILER-391:
---

https://github.com/apache/maven-compiler-plugin/pull/180 is now ready for 
review. Any feedback / comments would be more than welcome.

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2023-02-13 Thread Jira


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687896#comment-17687896
 ] 

Petr Široký commented on MCOMPILER-391:
---

Exclusions for {{annotationProcessorPaths}} will be supported in version 3.11.0 
(not sure about the release date though), see 
https://issues.apache.org/jira/browse/MCOMPILER-395 for more details.

Now, I would like to take a look at the other main part of this issue -- using 
the {{dependencyManagament}} for annotation processor dependencies

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2022-10-18 Thread Max Rydahl Andersen (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619628#comment-17619628
 ] 

Max Rydahl Andersen commented on MCOMPILER-391:
---

[~alvaro.sanchez] if you show up with a PR etc. i'm sure this would be looked 
at seriously - I just realized today that AP entries ignored dependency 
management and it caused problems when updating.

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2022-04-01 Thread Alvaro Sanchez-Mariscal (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515766#comment-17515766
 ] 

Alvaro Sanchez-Mariscal commented on MCOMPILER-391:
---

Is the Maven team still interested in fixing this issue? If so, I could help to 
put together a PR, test it, or whatever else that is needed.
 

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2021-10-06 Thread Robert Scholte (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424927#comment-17424927
 ] 

Robert Scholte commented on MCOMPILER-391:
--

[~jameshowe] worth checking

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2021-10-06 Thread James Howe (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424916#comment-17424916
 ] 

James Howe commented on MCOMPILER-391:
--

[~rfscholte] is the NPE MSHARED-998?

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2021-09-05 Thread Robert Scholte (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410202#comment-17410202
 ] 

Robert Scholte commented on MCOMPILER-391:
--

Fix should be something like this (using the dependency resolver of 
maven-artifact-transfer), but I'm getting an NPE
{code}
private List resolveProcessorPathEntries()
throws MojoExecutionException
{
if ( annotationProcessorPaths == null || 
annotationProcessorPaths.isEmpty() )
{
return null;
}

try
{
Set elements = new LinkedHashSet<>();

ProjectBuildingRequest buildingRequest = new 
DefaultProjectBuildingRequest( session.getProjectBuildingRequest() );

final List managedDependencies;
if ( project.getDependencyManagement()  == null )
{
managedDependencies = Collections.emptyList();
}
else
{
managedDependencies = 
project.getDependencyManagement().getDependencies();
}

Iterable artifacts = 
dependencyResolver.resolveDependencies( buildingRequest,

 annotationProcessorPaths,

 managedDependencies,

 null);

for ( ArtifactResult artifactResult : artifacts )
{
elements.add( 
artifactResult.getArtifact().getFile().getAbsolutePath() );
}

return new ArrayList<>( elements );
}
catch ( Exception e )
{
throw new MojoExecutionException( "Resolution of 
annotationProcessorPath dependencies failed: "
+ e.getLocalizedMessage(), e );
}
}
{code}

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2021-05-25 Thread Dan Berindei (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1735#comment-1735
 ] 

Dan Berindei commented on MCOMPILER-391:


[~rfscholte] what about using the versions from dependency management, is the 
fix the same?

We have an annotation processor brought in as a transitive dependency via a BOM.

Some annotation processors (e.g. MapStruct) do not have auto-detection, so 
their documentation tells the users to add their AP to 
{{}}. Because that disables auto-detection for all 
APs, it means users now have to add our AP there as well, and we'd very much 
like to avoid spelling out the AP version (which is definitely not the same as 
the BOM version) in the user's POM and in our documentation.

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2019-06-21 Thread Robert Scholte (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869500#comment-16869500
 ] 

Robert Scholte commented on MCOMPILER-391:
--

I see. The exclusions aren't respected. This is what I believe should fix it: 
org.apache.maven.plugin.compiler.AbstractCompilerMojo.resolveProcessorPathEntries()
 should make use of maven-artifact-transfer instead of repositorySystem. With 
https://maven.apache.org/shared/maven-artifact-transfer/apidocs/org/apache/maven/shared/transfer/dependencies/resolve/DependencyResolver.html#resolveDependencies-org.apache.maven.project.ProjectBuildingRequest-java.util.Collection-java.util.Collection-org.apache.maven.shared.artifact.filter.resolve.TransformableFilter-
 the exclusions of dependencyManagement should be respected.



> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2019-06-21 Thread Stanislav Spiridonov (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869426#comment-16869426
 ] 

Stanislav Spiridonov commented on MCOMPILER-391:


And I can't find any workaround how to exclude it for the annotation processor

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2019-06-21 Thread Stanislav Spiridonov (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869425#comment-16869425
 ] 

Stanislav Spiridonov commented on MCOMPILER-391:


mvn install

dependancy org.gwtproject.safehtml:gwt-safehtml:jar:1.0-SNAPSHOT is excluded in 
dependencyManagement 

 

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
> Attachments: MCOMPILER-391.zip
>
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2019-06-21 Thread Stanislav Spiridonov (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869420#comment-16869420
 ] 

Stanislav Spiridonov commented on MCOMPILER-391:


[INFO] Scanning for projects...
[INFO]
[INFO] ---< org.jresearch.error:org.jresearch.error.MCOMPILER_391 >
[INFO] Building org.jresearch.error.MCOMPILER_391 1.0.0-SHAPSHOT
[INFO] [ jar ]-
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
org.jresearch.error.MCOMPILER_391 ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, 
i.e. build is platform dependent!
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
org.jresearch.error.MCOMPILER_391 ---
[WARNING] Missing POM for org.gwtproject.safehtml:gwt-safehtml:jar:1.0-SNAPSHOT
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 1.467 s
[INFO] Finished at: 2019-06-21T13:56:40+02:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) 
on project org.jresearch.error.MCOMPILER_391: Resolution of 
annotationProcessorPath dependencies failed: Missing:
[ERROR] --
[ERROR] 1) org.gwtproject.safehtml:gwt-safehtml:jar:1.0-SNAPSHOT
[ERROR]
[ERROR] Try downloading the file manually from the project website.
[ERROR]
[ERROR] Then, install it using the command:
[ERROR] mvn install:install-file -DgroupId=org.gwtproject.safehtml 
-DartifactId=gwt-safehtml -Dversion=1.0-SNAPSHOT -Dpackaging=jar 
-Dfile=/path/to/file
[ERROR]
[ERROR] Alternatively, if you host your own repository you can deploy the file 
there:
[ERROR] mvn deploy:deploy-file -DgroupId=org.gwtproject.safehtml 
-DartifactId=gwt-safehtml -Dversion=1.0-SNAPSHOT -Dpackaging=jar 
-Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
[ERROR]
[ERROR] Path to dependency:
[ERROR] 1) org.jboss.gwt.elemento:elemento-template-processor:jar:0.8.7
[ERROR] 2) org.jboss.gwt.elemento:elemento-core:jar:0.8.7
[ERROR] 3) org.gwtproject.safehtml:gwt-safehtml:jar:1.0-SNAPSHOT
[ERROR]
[ERROR] --
[ERROR] 1 required artifact is missing.
[ERROR]
[ERROR] for artifact:
[ERROR] org.jboss.gwt.elemento:elemento-template-processor:jar:0.8.7
[ERROR]
[ERROR] from the specified remote repositories:
[ERROR] lnexus (http://localhost:8081/repository/public, releases=true, 
snapshots=true)
[ERROR] Path to dependency:
[ERROR] 1) org.jboss.gwt.elemento:elemento-template-processor:jar:0.8.7
[ERROR]
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules

2019-06-21 Thread Robert Scholte (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869264#comment-16869264
 ] 

Robert Scholte commented on MCOMPILER-391:
--

This is not enough info to fix the issue. If it is a blocker for you, you 
should at least provide a minimal project to reproduce the issue.


> annotationProcessorPaths have to follow dependencyManagement rules
> --
>
> Key: MCOMPILER-391
> URL: https://issues.apache.org/jira/browse/MCOMPILER-391
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Stanislav Spiridonov
>Priority: Blocker
>
> # Use the version from dependency management
>  # Respect the exclude (blocker for me)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)