[jira] [Commented] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible
[
https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733771#comment-17733771
]
ASF GitHub Bot commented on MCOMPILER-397:
--
ebourg commented on PR #193:
URL:
https://github.com/apache/maven-compiler-plugin/pull/193#issuecomment-1595767468
This is incomplete, the path separators have to be normalized too.
> Use relative paths in jpms.args to make the builds reproducible
> ---
>
> Key: MCOMPILER-397
> URL: https://issues.apache.org/jira/browse/MCOMPILER-397
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.8.1
>Reporter: Emmanuel Bourg
>Priority: Major
> Labels: reproducibility
>
> The {{jpms.args}} file generated since the version 3.7 contains absolute
> paths, for example here is the file generated for jaxb-core:
> {code}
> --add-modules
> java.xml.bind
> --upgrade-module-path
> /home/ebourg/jaxb/jaxb-ri/core/target/endorsed
> {code}
> The absolute path affects the reproducibility of the builds. Someone else
> rebuilding the project is unlikely to have the same base path and will not
> get a byte identical artifact. I suggest using a relative path instead
> (starting at the root of the project or at the root of the module) and
> normalizing the path separators (such that builds on Windows and Unix
> generate the same file).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible
[
https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733760#comment-17733760
]
Emmanuel Bourg commented on MCOMPILER-397:
--
I've opened a PR with the patch currently applied to maven-compiler-plugin in
Debian.
> Use relative paths in jpms.args to make the builds reproducible
> ---
>
> Key: MCOMPILER-397
> URL: https://issues.apache.org/jira/browse/MCOMPILER-397
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.8.1
>Reporter: Emmanuel Bourg
>Priority: Major
> Labels: reproducibility
>
> The {{jpms.args}} file generated since the version 3.7 contains absolute
> paths, for example here is the file generated for jaxb-core:
> {code}
> --add-modules
> java.xml.bind
> --upgrade-module-path
> /home/ebourg/jaxb/jaxb-ri/core/target/endorsed
> {code}
> The absolute path affects the reproducibility of the builds. Someone else
> rebuilding the project is unlikely to have the same base path and will not
> get a byte identical artifact. I suggest using a relative path instead
> (starting at the root of the project or at the root of the module) and
> normalizing the path separators (such that builds on Windows and Unix
> generate the same file).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible
[
https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733759#comment-17733759
]
ASF GitHub Bot commented on MCOMPILER-397:
--
ebourg opened a new pull request, #193:
URL: https://github.com/apache/maven-compiler-plugin/pull/193
PR for https://issues.apache.org/jira/browse/MCOMPILER-397
> Use relative paths in jpms.args to make the builds reproducible
> ---
>
> Key: MCOMPILER-397
> URL: https://issues.apache.org/jira/browse/MCOMPILER-397
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.8.1
>Reporter: Emmanuel Bourg
>Priority: Major
> Labels: reproducibility
>
> The {{jpms.args}} file generated since the version 3.7 contains absolute
> paths, for example here is the file generated for jaxb-core:
> {code}
> --add-modules
> java.xml.bind
> --upgrade-module-path
> /home/ebourg/jaxb/jaxb-ri/core/target/endorsed
> {code}
> The absolute path affects the reproducibility of the builds. Someone else
> rebuilding the project is unlikely to have the same base path and will not
> get a byte identical artifact. I suggest using a relative path instead
> (starting at the root of the project or at the root of the module) and
> normalizing the path separators (such that builds on Windows and Unix
> generate the same file).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible
[
https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733758#comment-17733758
]
Emmanuel Bourg commented on MCOMPILER-397:
--
> I understand the request, but if we change it, then the solution should be
> usable at runtime as well
I'm not sure to understand, how an absolute path from the developer computer
building the artifact could have any impact at runtime on someone else system?
> Use relative paths in jpms.args to make the builds reproducible
> ---
>
> Key: MCOMPILER-397
> URL: https://issues.apache.org/jira/browse/MCOMPILER-397
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.8.1
>Reporter: Emmanuel Bourg
>Priority: Major
> Labels: reproducibility
>
> The {{jpms.args}} file generated since the version 3.7 contains absolute
> paths, for example here is the file generated for jaxb-core:
> {code}
> --add-modules
> java.xml.bind
> --upgrade-module-path
> /home/ebourg/jaxb/jaxb-ri/core/target/endorsed
> {code}
> The absolute path affects the reproducibility of the builds. Someone else
> rebuilding the project is unlikely to have the same base path and will not
> get a byte identical artifact. I suggest using a relative path instead
> (starting at the root of the project or at the root of the module) and
> normalizing the path separators (such that builds on Windows and Unix
> generate the same file).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-397) Use relative paths in jpms.args to make the builds reproducible
[
https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926785#comment-16926785
]
Robert Scholte commented on MCOMPILER-397:
--
The {{jpms.args}} was introduced because these are arguments used at compile
you likely need at runtime as well.
The {{-add-modules}} works well because it refers to a module name.
But what about {{upgrade-module-path}}? Changing it to a relative path doesn't
seem to help either.
I understand the request, but if we change it, then the solution should be
usable at runtime as well.
> Use relative paths in jpms.args to make the builds reproducible
> ---
>
> Key: MCOMPILER-397
> URL: https://issues.apache.org/jira/browse/MCOMPILER-397
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.8.1
>Reporter: Emmanuel Bourg
>Priority: Major
> Labels: reproducibility
>
> The {{jpms.args}} file generated since the version 3.7 contains absolute
> paths, for example here is the file generated for jaxb-core:
> {code}
> --add-modules
> java.xml.bind
> --upgrade-module-path
> /home/ebourg/jaxb/jaxb-ri/core/target/endorsed
> {code}
> The absolute path affects the reproducibility of the builds. Someone else
> rebuilding the project is unlikely to have the same base path and will not
> get a byte identical artifact. I suggest using a relative path instead
> (starting at the root of the project or at the root of the module) and
> normalizing the path separators (such that builds on Windows and Unix
> generate the same file).
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
