[jira] [Commented] (MDEP-541) Allow for a space character as a pathSeparator in dependency:build-classpath

[dinwath (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016050#comment-16016050
 ] 

dinwath commented on MDEP-541:
--

Another use Case: I'm dealing with an application that uses ATG Dynamo 
framework and thus I need to build an EAR manifest which contains an entry with 
an "ATG-Class-Path" key (instead of "Class-Path"), so right now I'm using the 
same workaround suggested by opener:
{code:xml}
<...>

org.apache.maven.plugins
maven-dependency-plugin


get-classpath-for-manifest
generate-sources

build-classpath



atg-classpath 
@_@
/
${lib-path}
war






org.codehaus.mojo
build-helper-maven-plugin
${plugin.build-helper-maven-plugin.version}


fix-classpath-for-manifest
generate-sources

regex-property


atg-classpath
${atg-classpath}
@_@

false






org.apache.maven.plugins
maven-ear-plugin



DAS

${war.artifactId}-${war.version}.war

${maven.build.timestamp}
classes 
${atg-classpath}


${lib-path}
true


my.group.id

${war.artifactId}
/




<...>
{code}

> Allow for a space character as a pathSeparator in dependency:build-classpath
> 
>
> Key: MDEP-541
> URL: https://issues.apache.org/jira/browse/MDEP-541
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: build-classpath
>Reporter: Giedrius Noreikis
>
> Currently, the {{dependency:build-classpath}} goal does not allow a space 
> character to be specified as a {{pathSeparator}}, which is necessary to 
> generate {{Class-Path}} values for manifests.
> Because of a check {{isPathSepSet = StringUtils.isNotEmpty( pathSeparator )}} 
> in {{BuildClasspathMojo.java}}, the parameter gets ignored in this case, and 
> the classpath is built with a default separator.
> The possible workaround is to fix the path with 
> {{build-helper:regex-property}}:
> {code:xml}
>   
> org.codehaus.mojo
> build-helper-maven-plugin
> 
>   
> fix-classpath-for-manifest
> prepare-package
> regex-property
> 
>   appClasspath
>   ${appClasspath}
>   ;
>
>   false
> 
>   
> 
>   
> {code}
> but a fix would allow for a more straightforward solution.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-541) Allow for a space character as a pathSeparator in dependency:build-classpath

[James Phillpotts (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811557#comment-15811557
 ] 

James Phillpotts commented on MDEP-541:
---

Another use-case - setting the {{Class-Path}} manifest entries when creating an 
executable jar with reduced dependencies using the maven shade plugin.

> Allow for a space character as a pathSeparator in dependency:build-classpath
> 
>
> Key: MDEP-541
> URL: https://issues.apache.org/jira/browse/MDEP-541
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: build-classpath
>Reporter: Giedrius Noreikis
>
> Currently, the {{dependency:build-classpath}} goal does not allow a space 
> character to be specified as a {{pathSeparator}}, which is necessary to 
> generate {{Class-Path}} values for manifests.
> Because of a check {{isPathSepSet = StringUtils.isNotEmpty( pathSeparator )}} 
> in {{BuildClasspathMojo.java}}, the parameter gets ignored in this case, and 
> the classpath is built with a default separator.
> The possible workaround is to fix the path with 
> {{build-helper:regex-property}}:
> {code:xml}
>   
> org.codehaus.mojo
> build-helper-maven-plugin
> 
>   
> fix-classpath-for-manifest
> prepare-package
> regex-property
> 
>   appClasspath
>   ${appClasspath}
>   ;
>
>   false
> 
>   
> 
>   
> {code}
> but a fix would allow for a more straightforward solution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MDEP-541) Allow for a space character as a pathSeparator in dependency:build-classpath

[Giedrius Noreikis (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576607#comment-15576607
 ] 

Giedrius Noreikis commented on MDEP-541:


We need more flexibility, and {{maven-archiver}} does not allow (at least I 
couldn't find a way) to exclude some dependencies from the {{Class-Path}}, 
which is necessary in our case as we repackage some jars from dependencies into 
the final jar (with a help of {{proguard-maven-plugin}}).

> Allow for a space character as a pathSeparator in dependency:build-classpath
> 
>
> Key: MDEP-541
> URL: https://issues.apache.org/jira/browse/MDEP-541
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: build-classpath
>Reporter: Giedrius Noreikis
>
> Currently, the {{dependency:build-classpath}} goal does not allow a space 
> character to be specified as a {{pathSeparator}}, which is necessary to 
> generate {{Class-Path}} values for manifests.
> Because of a check {{isPathSepSet = StringUtils.isNotEmpty( pathSeparator )}} 
> in {{BuildClasspathMojo.java}}, the parameter gets ignored in this case, and 
> the classpath is built with a default separator.
> The possible workaround is to fix the path with 
> {{build-helper:regex-property}}:
> {code:xml}
>   
> org.codehaus.mojo
> build-helper-maven-plugin
> 
>   
> fix-classpath-for-manifest
> prepare-package
> regex-property
> 
>   appClasspath
>   ${appClasspath}
>   ;
>
>   false
> 
>   
> 
>   
> {code}
> but a fix would allow for a more straightforward solution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MDEP-541) Allow for a space character as a pathSeparator in dependency:build-classpath

[JIRA]

[ 
https://issues.apache.org/jira/browse/MDEP-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575952#comment-15575952
 ] 

Guillaume Boué commented on MDEP-541:
-

Can you explain what is your use-case? {{dependency:build-classpath}} is mainly 
used to generate the classpath so that it can be used as argument for {{java 
-cp}}. 
[{{pathSeparator}}|http://maven.apache.org/plugins/maven-dependency-plugin/build-classpath-mojo.html#pathSeparator]
 represents the system specific separator between paths.

The {{Class-Path}} entry inside the Manifest is normally generated by 
{{maven-archiver}}, that for example [the {{maven-jar-plugin}} 
uses|https://maven.apache.org/shared/maven-archiver/examples/classpath.html].

> Allow for a space character as a pathSeparator in dependency:build-classpath
> 
>
> Key: MDEP-541
> URL: https://issues.apache.org/jira/browse/MDEP-541
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: build-classpath
>Reporter: Giedrius Noreikis
>
> Currently, the {{dependency:build-classpath}} goal does not allow a space 
> character to be specified as a {{pathSeparator}}, which is necessary to 
> generate {{Class-Path}} values for manifests.
> Because of a check {{isPathSepSet = StringUtils.isNotEmpty( pathSeparator )}} 
> in {{BuildClasspathMojo.java}}, the parameter gets ignored in this case, and 
> the classpath is built with a default separator.
> The possible workaround is to fix the path with 
> {{build-helper:regex-property}}:
> {code:xml}
>   
> org.codehaus.mojo
> build-helper-maven-plugin
> 
>   
> fix-classpath-for-manifest
> prepare-package
> regex-property
> 
>   appClasspath
>   ${appClasspath}
>   ;
>
>   false
> 
>   
> 
>   
> {code}
> but a fix would allow for a more straightforward solution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)