[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2022-08-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17586081#comment-17586081
 ] 

Hudson commented on MDEP-714:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-plugin » 
master #41

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master/41/

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-12-18 Thread Thorsten Glaser (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461944#comment-17461944
 ] 

Thorsten Glaser commented on MDEP-714:
--

[~lars-sh] good point!

I guess we cannot “simply” add a new scope to Maven, nor annotate the 
{{dependency}} tags themselves. So adding a documented one-liner override like 
[here|https://github.com/tarent/rfc822/blob/db4b50e7ac16619ef75779b6489cddf9b410d2b6/pom.xml#L226-L227]
 seems like the best solution for this kind of {{testRuntime}} dependency.

In old projects, with many reported unused dependencies once this plugin is 
turned on, it can be challenging to figure out which is which, though… but 
that’s neither here nor there.

It *might* make sense for MDEP to add a hardcoded list of a couple of overrides 
(specifically, test-scoped {{testRuntime}} dependencies). But once this is 
added, everyone will add bugreports asking why the thing _they_ use isn’t on 
the list, so it might be wise to not do it, from a maintenance PoV.

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-12-18 Thread Lars Knickrehm (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461936#comment-17461936
 ] 

Lars Knickrehm commented on MDEP-714:
-

[~mirabilos], in general it makes sense to analyze the test scoped 
dependencies, as it's likely they are used within the test classes. Instead 
runtime scoped dependencies are most likely dependencies, which are not 
referenced directly, but loaded aside.

In the case of the JUnit engine it'd be cool to have some kind of test-runtime 
scope, which does not seem to exist. Therefore I'm simply ignoring those 
dependencies the way you described in my projects, too.

If you find a better solution, I'd be interested, too.

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-12-13 Thread Thorsten Glaser (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458599#comment-17458599
 ] 

Thorsten Glaser commented on MDEP-714:
--

I’m having the same problem, but with {{{}test{}}}-scoped dependencies.

{{}}
{{org.junit.jupiter:junit-jupiter-engine}}

… and…

{{}}
{{        org.junit.jupiter}}
{{        junit-jupiter-engine}}
{{        ${junit.version}}}
{{        test}}
{{}}

I’m not sure generally ignoring them all is the way to go, though…

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-04-11 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318862#comment-17318862
 ] 

Michael Osipov commented on MDEP-714:
-

I hope this will happen before 2021, but if it won't before summer, feel free 
to ping me by June.

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.3
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-04-11 Thread Lars Knickrehm (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318854#comment-17318854
 ] 

Lars Knickrehm commented on MDEP-714:
-

We can work around this for now by ignoring those dependencies, therefore a 
release unteil 2022 would be helpful, but this is not a blocking thing.

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.3
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-04-11 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318776#comment-17318776
 ] 

Michael Osipov commented on MDEP-714:
-

There is no real plan because a release solely depends on the motivation of a 
release manager. Is this change paritucalairy important for you? If yes, how?

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.3
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-04-11 Thread Lars Knickrehm (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318762#comment-17318762
 ] 

Lars Knickrehm commented on MDEP-714:
-

[~michael-o], thanks for your support and integrating the request.

One last question: Is there any release plan, that allows me to plan the 
availability of this change?

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.3
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"

2021-04-11 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318722#comment-17318722
 ] 

Hudson commented on MDEP-714:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-plugin » 
master #54

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master/54/

> Add analyze parameter "ignoreUnusedRuntime"
> ---
>
> Key: MDEP-714
> URL: https://issues.apache.org/jira/browse/MDEP-714
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.3
>
>
> Typical output when analyzing the maven-archetype-plugin:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime
> However since this is needed at runtime, possibly via reflection, it seems 
> likely that it is used but the dependency analyzer can't figure this out.
> Confirm and consider whether the plugin should simply never report runtime 
> dependencies as unused. 
> This is tricky because it's certainly possible that a runtime dependency is 
> unused, but in practice it seems more likely than not to be a false positive.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)