[jira] [Commented] (MEAR-249) Maven EAR plugin - two libraries with a same ArtifactId
[ https://issues.apache.org/jira/browse/MEAR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169352#comment-16169352 ] Karl Heinz Marbaise commented on MEAR-249: -- Hi, first thanks for your feedback. yes this was right and the wrong result was generated which is based on the previous wrong implementation. The thing is if a user decided to define a different mapping (which is now no problem with the new implementation) which would clash in names (same file name) there should be an error cause otherwise it would not being fixed and would produce wrong results in the resulting EAR file...(which means overwriting of existing files!).. > Maven EAR plugin - two libraries with a same ArtifactId > --- > > Key: MEAR-249 > URL: https://issues.apache.org/jira/browse/MEAR-249 > Project: Maven Ear Plugin > Issue Type: Bug >Affects Versions: waiting-for-feedback >Reporter: Tomas Tulka > > When an EAR module has two (or more) dependencies with a same artifactId, > Maven copy those into the /lib directory and one rewrites the other. In the > end there is only one library in the EAR. > This is not what I would expect, because it is correct to have such > dependencies. The plugin should deal with it or print a warning (it's a > tricky issue when it is about transitive dependencies). > > com.group1 > same-artifact > > > com.group2 > same-artifact > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MEAR-249) Maven EAR plugin - two libraries with a same ArtifactId
[ https://issues.apache.org/jira/browse/MEAR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169345#comment-16169345 ] Tomas Tulka commented on MEAR-249: -- This solution is okay for me, I was just wandering if it wouldn't be possible to generate the full name mapping automatically in this case, or to create an indexing for the same artifact files, something like `same-artifact.jar` and `same-artifact (1).jar` in the example above. The point here is, there is nothing wrong with the artifacts, everything is valid and a wrong result is generated. It means ERROR is inappropriate here. But the WARNING with the hint is probably sufficient enough. Thank you! > Maven EAR plugin - two libraries with a same ArtifactId > --- > > Key: MEAR-249 > URL: https://issues.apache.org/jira/browse/MEAR-249 > Project: Maven Ear Plugin > Issue Type: Bug >Affects Versions: waiting-for-feedback >Reporter: Tomas Tulka > > When an EAR module has two (or more) dependencies with a same artifactId, > Maven copy those into the /lib directory and one rewrites the other. In the > end there is only one library in the EAR. > This is not what I would expect, because it is correct to have such > dependencies. The plugin should deal with it or print a warning (it's a > tricky issue when it is about transitive dependencies). > > com.group1 > same-artifact > > > com.group2 > same-artifact > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MEAR-249) Maven EAR plugin - two libraries with a same ArtifactId
[
https://issues.apache.org/jira/browse/MEAR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169029#comment-16169029
]
Karl Heinz Marbaise commented on MEAR-249:
--
After implementing [MEAR-171] which supports full name mapping...this should
not be a problem anymore...cause based on this the artifacts will be named by
default
@{groupId}@-@{artifactId}@-@{version}@@{dashClassifier?}@.@{extension}@
which means you will get: {{com.group1-same-artifact.jar}} and
{{com.group2-same-artifact.jar}}.
> Maven EAR plugin - two libraries with a same ArtifactId
> ---
>
> Key: MEAR-249
> URL: https://issues.apache.org/jira/browse/MEAR-249
> Project: Maven Ear Plugin
> Issue Type: Bug
>Affects Versions: waiting-for-feedback
>Reporter: Tomas Tulka
>
> When an EAR module has two (or more) dependencies with a same artifactId,
> Maven copy those into the /lib directory and one rewrites the other. In the
> end there is only one library in the EAR.
> This is not what I would expect, because it is correct to have such
> dependencies. The plugin should deal with it or print a warning (it's a
> tricky issue when it is about transitive dependencies).
>
> com.group1
> same-artifact
>
>
> com.group2
> same-artifact
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MEAR-249) Maven EAR plugin - two libraries with a same ArtifactId
[
https://issues.apache.org/jira/browse/MEAR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143089#comment-16143089
]
Karl Heinz Marbaise commented on MEAR-249:
--
After rechecking this with version 2.10.1 which already produces WARNING's in
such cases:
{code}
[INFO] --- maven-ear-plugin:2.10.1:ear (default-ear) @ app ---
[WARNING] The artifactId service:3.4.6-SNAPSHOT exists more than once in the
modules list.
[WARNING] --> com.soebes.examples.j2ee:service:ejb:3.4.6-SNAPSHOT (ejb)
[WARNING] --> com.soebes.examples:service:ejb:3.4.6-SNAPSHOT (ejb)
[WARNING] HINT: This can be simply solved by using the
full
{code}
Based on the published date of maven-ear-plugin:2.10.1 (2015-06-27) I assume
this is related to the last released version...
The question is: Printing out a warning is done...What do you have in mind by
"The plugin should deal with it..."?
I think it's a good time to make this WARNING into an error, cause the result
can't be correct in the end. This means changing the behaviour to fail the
build in such cases.
> Maven EAR plugin - two libraries with a same ArtifactId
> ---
>
> Key: MEAR-249
> URL: https://issues.apache.org/jira/browse/MEAR-249
> Project: Maven Ear Plugin
> Issue Type: Bug
>Reporter: Tomas Tulka
>
> When an EAR module has two (or more) dependencies with a same artifactId,
> Maven copy those into the /lib directory and one rewrites the other. In the
> end there is only one library in the EAR.
> This is not what I would expect, because it is correct to have such
> dependencies. The plugin should deal with it or print a warning (it's a
> tricky issue when it is about transitive dependencies).
>
> com.group1
> same-artifact
>
>
> com.group2
> same-artifact
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
