[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory
[
https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474525#comment-17474525
]
Marat Abrarov commented on MEAR-307:
Hi [~asbachb],
Regarding [your
note|https://issues.apache.org/jira/browse/MEAR-307?focusedCommentId=17474463=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17474463]
{quote}
I'd expect that the war should behave somehow similar to other modules where I
don't need to define the dependencies manually.
{quote}
{{war}} packaging / artifact type (as well as {{ear}} packaging and some other
packing types) "contains all of its dependencies" in terms of Maven, so these
dependencies are not visible (do not come as transitive dependencies) to EARs
which depend on WARs.
> skinny modules war libs are not put into shared lib directory
> -
>
> Key: MEAR-307
> URL: https://issues.apache.org/jira/browse/MEAR-307
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Benjamin Asbach
>Priority: Major
> Attachments: MEAR-307_fixed_example.zip, ear-war-skinny-bug-ear.zip
>
>
> {code:xml}
>
>
>
> maven-ear-plugin
> 3.2.0
>
> 8
> libs/
> true
>
>
>
>
>
>
> org.jenkins-ci.main
> jenkins-war
> 2.328
> war
>
>
> {code}
> With the current configuration the libs of war application are not placed
> into libs directory.
> This causes problems when you add an ejb module: The ejb dependencies are
> placed in libs and the META-INF/MANIFEST-MF classpath entry of the war is set
> with the libs classpath.
> This causes problems with classloading in JBoss EAP.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory
[
https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474516#comment-17474516
]
Benjamin Asbach commented on MEAR-307:
--
Actually I'm unable to close the issue. Feel free to close it.
> skinny modules war libs are not put into shared lib directory
> -
>
> Key: MEAR-307
> URL: https://issues.apache.org/jira/browse/MEAR-307
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Benjamin Asbach
>Priority: Major
> Attachments: MEAR-307_fixed_example.zip, ear-war-skinny-bug-ear.zip
>
>
> {code:xml}
>
>
>
> maven-ear-plugin
> 3.2.0
>
> 8
> libs/
> true
>
>
>
>
>
>
> org.jenkins-ci.main
> jenkins-war
> 2.328
> war
>
>
> {code}
> With the current configuration the libs of war application are not placed
> into libs directory.
> This causes problems when you add an ejb module: The ejb dependencies are
> placed in libs and the META-INF/MANIFEST-MF classpath entry of the war is set
> with the libs classpath.
> This causes problems with classloading in JBoss EAP.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory
[
https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474515#comment-17474515
]
Benjamin Asbach commented on MEAR-307:
--
[~abrarovm] thanks for your support. The solution referencing the pom seems to
work for me as well.
> skinny modules war libs are not put into shared lib directory
> -
>
> Key: MEAR-307
> URL: https://issues.apache.org/jira/browse/MEAR-307
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Benjamin Asbach
>Priority: Major
> Attachments: MEAR-307_fixed_example.zip, ear-war-skinny-bug-ear.zip
>
>
> {code:xml}
>
>
>
> maven-ear-plugin
> 3.2.0
>
> 8
> libs/
> true
>
>
>
>
>
>
> org.jenkins-ci.main
> jenkins-war
> 2.328
> war
>
>
> {code}
> With the current configuration the libs of war application are not placed
> into libs directory.
> This causes problems when you add an ejb module: The ejb dependencies are
> placed in libs and the META-INF/MANIFEST-MF classpath entry of the war is set
> with the libs classpath.
> This causes problems with classloading in JBoss EAP.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory
[
https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474469#comment-17474469
]
Marat Abrarov commented on MEAR-307:
[~asbachb],
I'm not the author of this approach, but I believe it's by design - this way
users have fine-grained control over what JARs / WARs / etc to move into shared
folder and what keep as is. I was ensured that the trick I shared in
[^MEAR-307_fixed_example.zip] is widely used and is simple to implement.
Refer to https://github.com/apache/maven-ear-plugin/pull/24. There are rare
cases (e.g. some Spring Web libraries, JSF libraries) when you need to keep JAR
inside WAR even if this JAR is located in multiple web modules of the same EAR
(otherwise JAR doesn't work as expected).
> skinny modules war libs are not put into shared lib directory
> -
>
> Key: MEAR-307
> URL: https://issues.apache.org/jira/browse/MEAR-307
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Benjamin Asbach
>Priority: Major
> Attachments: MEAR-307_fixed_example.zip, ear-war-skinny-bug-ear.zip
>
>
> {code:xml}
>
>
>
> maven-ear-plugin
> 3.2.0
>
> 8
> libs/
> true
>
>
>
>
>
>
> org.jenkins-ci.main
> jenkins-war
> 2.328
> war
>
>
> {code}
> With the current configuration the libs of war application are not placed
> into libs directory.
> This causes problems when you add an ejb module: The ejb dependencies are
> placed in libs and the META-INF/MANIFEST-MF classpath entry of the war is set
> with the libs classpath.
> This causes problems with classloading in JBoss EAP.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory
[
https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474463#comment-17474463
]
Benjamin Asbach commented on MEAR-307:
--
[~abrarovm], thansk for your fast response. I wonder if this is a technical
limitation?
I'd expect that the war should behave somehow similar to other modules where I
don't need to define the dependencies manually.
For my use case (1war + 2ejb) I also end up with doubled dependencies: Some
war dependencies are present in libs and in war/WEB-INF/lib.
> skinny modules war libs are not put into shared lib directory
> -
>
> Key: MEAR-307
> URL: https://issues.apache.org/jira/browse/MEAR-307
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Benjamin Asbach
>Priority: Major
> Attachments: MEAR-307_fixed_example.zip, ear-war-skinny-bug-ear.zip
>
>
> {code:xml}
>
>
>
> maven-ear-plugin
> 3.2.0
>
> 8
> libs/
> true
>
>
>
>
>
>
> org.jenkins-ci.main
> jenkins-war
> 2.328
> war
>
>
> {code}
> With the current configuration the libs of war application are not placed
> into libs directory.
> This causes problems when you add an ejb module: The ejb dependencies are
> placed in libs and the META-INF/MANIFEST-MF classpath entry of the war is set
> with the libs classpath.
> This causes problems with classloading in JBoss EAP.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
