[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Robert Scholte (Jira)


[ 
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622799#comment-17622799
 ] 

Robert Scholte commented on MEAR-322:
-

Everybody can report a bug, but due to a huge amount of spam, they are first 
validated before being moved to a JDK- issue. People that have proven their 
value sometimes get direct access, I'm one of the few.
The easiest way is to say what you want to be added, I'll copy/paste when I 
agree. 
I'm not going to ask for backports if it is already fixed in a newer version. 
So if this is a JDK11 issue, better to provide a backport patch on that branch.

> Module repackaged as invalid archive
> 
>
> Key: MEAR-322
> URL: https://issues.apache.org/jira/browse/MEAR-322
> Project: Maven EAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Piotr Zygielo
>Priority: Major
> Fix For: more-investigation
>
>
> After m-ear-p upgrade from 3.2.0 to 3.3.0, ear produced by plugin contains 
> invalid entry. That causes jar tool to error with
> {quote}java.util.zip.ZipException: only DEFLATED entries can have EXT 
> descriptor
>   at java.base/java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:313)
>   at 
> java.base/java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:125)
>   at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1360)
>   at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
>   at jdk.jartool/sun.tools.jar.Main.main(Main.java:1680)
> {quote}
> Seems to be connected to setting {{archive/compress=false}} in the original 
> jar project (original project - valid at its origin, becomes invalid part of 
> ear).
> This happens for original project with {{packaging=clojure}} in my case.
> 07a84983809b4ec416b1330412bbd83844a88a44 is the first bad commit
>  
>  
> Reproducer: [https://github.com/pzrep/MEAR-322]
> and its failure: [https://github.com/pzrep/MEAR-322/actions/runs/3306348660]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622786#comment-17622786
 ] 

Slawomir Jaranowski commented on MEAR-322:
--

By the way issues on JDK should be refreshed or created a new one. 

Does anybody have experience for reporting JDK issues?

> Module repackaged as invalid archive
> 
>
> Key: MEAR-322
> URL: https://issues.apache.org/jira/browse/MEAR-322
> Project: Maven EAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Piotr Zygielo
>Priority: Major
> Fix For: more-investigation
>
>
> After m-ear-p upgrade from 3.2.0 to 3.3.0, ear produced by plugin contains 
> invalid entry. That causes jar tool to error with
> {quote}java.util.zip.ZipException: only DEFLATED entries can have EXT 
> descriptor
>   at java.base/java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:313)
>   at 
> java.base/java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:125)
>   at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1360)
>   at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
>   at jdk.jartool/sun.tools.jar.Main.main(Main.java:1680)
> {quote}
> Seems to be connected to setting {{archive/compress=false}} in the original 
> jar project (original project - valid at its origin, becomes invalid part of 
> ear).
> This happens for original project with {{packaging=clojure}} in my case.
> 07a84983809b4ec416b1330412bbd83844a88a44 is the first bad commit
>  
>  
> Reproducer: [https://github.com/pzrep/MEAR-322]
> and its failure: [https://github.com/pzrep/MEAR-322/actions/runs/3306348660]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Piotr Zygielo (Jira)


[ 
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622785#comment-17622785
 ] 

Piotr Zygielo commented on MEAR-322:


Thanks for checking more JDKs and providing links.

I confirm that compressing original module solves the problem, and using JDK 8 
or 19 also helps.

Please close this issue, as I have no power to do so and I accept proposed 
workarounds.

> Module repackaged as invalid archive
> 
>
> Key: MEAR-322
> URL: https://issues.apache.org/jira/browse/MEAR-322
> Project: Maven EAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Piotr Zygielo
>Priority: Major
> Fix For: more-investigation
>
>
> After m-ear-p upgrade from 3.2.0 to 3.3.0, ear produced by plugin contains 
> invalid entry. That causes jar tool to error with
> {quote}java.util.zip.ZipException: only DEFLATED entries can have EXT 
> descriptor
>   at java.base/java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:313)
>   at 
> java.base/java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:125)
>   at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1360)
>   at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
>   at jdk.jartool/sun.tools.jar.Main.main(Main.java:1680)
> {quote}
> Seems to be connected to setting {{archive/compress=false}} in the original 
> jar project (original project - valid at its origin, becomes invalid part of 
> ear).
> This happens for original project with {{packaging=clojure}} in my case.
> 07a84983809b4ec416b1330412bbd83844a88a44 is the first bad commit
>  
>  
> Reproducer: [https://github.com/pzrep/MEAR-322]
> and its failure: [https://github.com/pzrep/MEAR-322/actions/runs/3306348660]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622780#comment-17622780
 ] 

Slawomir Jaranowski commented on MEAR-322:
--

Such issue occurs only on JDK 11 when module is created with STORE compressions.

I see workaround don't use STORE on JDK 11.

Finally bug is in JDK not EAR plugin.

My tests: https://github.com/slawekjaranowski/MEAR-322/actions/runs/3306589721

Similar issue in JDK https://bugs.openjdk.org/browse/JDK-8229887
and this: https://bugs.openjdk.org/browse/JDK-8143613

> Module repackaged as invalid archive
> 
>
> Key: MEAR-322
> URL: https://issues.apache.org/jira/browse/MEAR-322
> Project: Maven EAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Piotr Zygielo
>Priority: Major
>
> After m-ear-p upgrade from 3.2.0 to 3.3.0, ear produced by plugin contains 
> invalid entry. That causes jar tool to error with
> {quote}java.util.zip.ZipException: only DEFLATED entries can have EXT 
> descriptor
>   at java.base/java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:313)
>   at 
> java.base/java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:125)
>   at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1360)
>   at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
>   at jdk.jartool/sun.tools.jar.Main.main(Main.java:1680)
> {quote}
> Seems to be connected to setting {{archive/compress=false}} in the original 
> jar project (original project - valid at its origin, becomes invalid part of 
> ear).
> This happens for original project with {{packaging=clojure}} in my case.
> 07a84983809b4ec416b1330412bbd83844a88a44 is the first bad commit
>  
>  
> Reproducer: [https://github.com/pzrep/MEAR-322]
> and its failure: [https://github.com/pzrep/MEAR-322/actions/runs/3306348660]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)