[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759536#comment-16759536
]
Hudson commented on MENFORCER-314:
--
Build succeeded in Jenkins: Maven TLP » maven-enforcer » master #67
See https://builds.apache.org/job/maven-box/job/maven-enforcer/job/master/67/
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Assignee: Enrico Olivelli
>Priority: Major
> Fix For: 3.0.0
>
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741971#comment-16741971
]
Falko Modler commented on MENFORCER-314:
After running some weeks with a custom build of the plugin incorporating PR
#44, the problem finally struck and the output now reveals the underlying cause:
{noformat}
11:13:47 [WARNING] Rule 4:
org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
11:13:47 org.apache.maven.enforcer.rule.api.EnforcerRuleException
11:13:47at
org.apache.maven.plugins.enforcer.DependencyConvergence.execute(DependencyConvergence.java:132)
11:13:47at
org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:204)
11:13:47at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
11:13:47at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
11:13:47at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
11:13:47at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
11:13:47at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
11:13:47at
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:185)
11:13:47at
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:181)
11:13:47at java.util.concurrent.FutureTask.run(FutureTask.java:266)
11:13:47at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
11:13:47at java.util.concurrent.FutureTask.run(FutureTask.java:266)
11:13:47at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
11:13:47at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
11:13:47at java.lang.Thread.run(Thread.java:748)
11:13:47 Caused by: java.lang.NullPointerException
11:13:47at java.util.Hashtable.put(Hashtable.java:460)
11:13:47at
org.apache.maven.properties.internal.SystemProperties.addSystemProperties(SystemProperties.java:38)
11:13:47at
org.apache.maven.project.artifact.MavenMetadataSource.getSystemProperties(MavenMetadataSource.java:756)
11:13:47at
org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:574)
11:13:47at
org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:190)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:532)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:584)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:584)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:584)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:584)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:584)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:144)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:100)
11:13:47at
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:782)
11:13:47at
org.apache.maven.shared.dependency.tree.DefaultDependencyTreeBuilder.buildDependencyTree(DefaultDependencyTreeBuilder.java:118)
11:13:47at
org.apache.maven.plugins.enforcer.DependencyConvergence.getNode(DependencyConvergence.java:86)
11:13:47at
org.apache.maven.plugins.enforcer.DependencyConvergence.execute(DependencyConvergence.java:114)
11:13:47... 14 more
{noformat}
So in this case it was MNG-6105 (we are still on Maven 3.3.9).
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
>
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668424#comment-16668424
]
Falko Modler commented on MENFORCER-314:
[~khmarbaise] Any chance to have one of the PRs integrated into 3.0.0? :)
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1141#comment-1141
]
ASF GitHub Bot commented on MENFORCER-314:
--
famod edited a comment on issue #43: [MENFORCER-314] - Warn if
EnforcerRuleException has no message
URL: https://github.com/apache/maven-enforcer/pull/43#issuecomment-433630878
I pushed an alternative approach because I couldn't really decide which one
is better: #44
Please merge whichever PR you like best. I'd probably go with #44.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1140#comment-1140
]
ASF GitHub Bot commented on MENFORCER-314:
--
famod edited a comment on issue #44: [MENFORCER-314] - Include entire exception
if message is missing
URL: https://github.com/apache/maven-enforcer/pull/44#issuecomment-433630747
Alternative approach to #43 . I like this one better but I am not sure.
Please merge whichever PR you like best.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1137#comment-1137
]
Falko Modler commented on MENFORCER-314:
I've sent to PRs to improve output for such a case to figure out what is going
on.
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1134#comment-1134
]
ASF GitHub Bot commented on MENFORCER-314:
--
famod commented on issue #43: [MENFORCER-314] - Warn if EnforcerRuleException
has no message
URL: https://github.com/apache/maven-enforcer/pull/43#issuecomment-433630878
I pushed an alternative approach because I couldn't really decide which one
is better: #44
Please merge whichever PR you like best.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1132#comment-1132
]
ASF GitHub Bot commented on MENFORCER-314:
--
famod commented on issue #44: [MENFORCER-314] - Include entire exception if
message is missing
URL: https://github.com/apache/maven-enforcer/pull/44#issuecomment-433630747
Alternative approach to #43 which I actually like better but I am not sure.
Please merge whichever PR you like best.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1129#comment-1129
]
ASF GitHub Bot commented on MENFORCER-314:
--
famod opened a new pull request #44: [MENFORCER-314] - Include entire exception
if message is missing
URL: https://github.com/apache/maven-enforcer/pull/44
This should help to find out why DependencyConvergence
sometimes fails without providing a message.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-314) DependencyConvergence fails sporadically with a null message
[
https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1121#comment-1121
]
ASF GitHub Bot commented on MENFORCER-314:
--
famod opened a new pull request #43: [MENFORCER-314] - Warn if
EnforcerRuleException has no message
URL: https://github.com/apache/maven-enforcer/pull/43
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DependencyConvergence fails sporadically with a null message
>
>
> Key: MENFORCER-314
> URL: https://issues.apache.org/jira/browse/MENFORCER-314
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Java version: 1.8.0_162, vendor: Oracle Corporation
>Reporter: Falko Modler
>Priority: Major
>
> Our Jenkins builds fail sporadically without providing a message:
> {noformat}
> 17:08:28 [WARNING] Rule 4:
> org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
> 17:08:28 null
> {noformat}
> Looking at the code, I suspect that this can happen [on line 132 of the
> rule|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java#L132]
> when some underlying exception is caught which itself does not provide a
> (localized) message.
> As the plugin [does not include the
> cause|https://github.com/apache/maven-enforcer/blob/enforcer-3.0.0-M2/maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java#L212]
> (unless {{failFast}} is set), you will just see a null message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
