[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648875#comment-17648875
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
I have a question: as pointed out by [~kwin], I should not modify
{{AbstractBanDependencies}} as it might be an API some other custom rules may
depend on. I thought that custom rules should only depend on the API defined in
{{enforcer-api}}, like I did for {{versions-maven-plugin}}.
Apparently I was wrong.
Therefore, my question is: am I allowed to modify the interface of other
classes, like e.g. DependencyVersionMap -- I'd like to apply a
{{DependencySelector}} to filter out excludes and includes already at the
dependency node retrieval stage.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648871#comment-17648871
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
Looks like this PR also resolves MENFORCER-434.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648639#comment-17648639
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
https://github.com/apache/maven-enforcer/pull/198
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648336#comment-17648336
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
Update: replaced maven-compat and dendency-tree cruft with resolver. All
current unit and integration tests are green. Now polishing and adding
traceability (parent) information where it's not present, so that no additional
use of the dependency tree plugin is needed to track the packages causing
validation errors.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645818#comment-17645818
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
Oh I didn't know you were working on it. Anyway, since the required maven
version is 3.2.5, it's safe to assume that we can use the new Resolver API and
thus remove maven-compat cruft altogether. Here's my attempt from today:
https://github.com/apache/maven-enforcer/compare/master...ajarmoniuk:maven-enforcer:MENFORCER-435?expand=1
If you don't mind, I'll gladly continue your job.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645811#comment-17645811
]
Konrad Windszus commented on MENFORCER-435:
---
I have a WIP version which I now pushed to
https://github.com/apache/maven-enforcer/tree/feature/remove-m-dependency-tree/enforcer-rules.
I am currently not working on this, so feel free to continue the branch. It is
not that easy as we need to stay backwards compatible, so probably it is not
really about getting rid of it in the first place, but only using the new
Resolver API in the first place. Only with a major version bump, we can finally
get rid of the m-dependency-tree dependency and all related code.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645809#comment-17645809
]
Slawomir Jaranowski commented on MENFORCER-435:
---
Good luck [~ajarmoniuk]
Assigned to me for tracking purpose
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-435) Get rid of maven-dependency-tree dependency
[
https://issues.apache.org/jira/browse/MENFORCER-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645803#comment-17645803
]
Andrzej Jarmoniuk commented on MENFORCER-435:
-
Is anyone working on this one already? If not, I'd gladly take it.
> Get rid of maven-dependency-tree dependency
> ---
>
> Key: MENFORCER-435
> URL: https://issues.apache.org/jira/browse/MENFORCER-435
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> As the m-enforcer-p depends on Maven 3.2.5 (since MENFORCER-419) all
> dependency resolutions should be done with Aether API directly instead of
> leveraging https://maven.apache.org/shared/maven-dependency-tree/. At the
> same time the error message should print the full path to the affected
> dependency instead of forcing users to use a dedicated call of {{mvn
> dependency:tree}} to locate the dependency
> (https://github.com/apache/maven-enforcer/blob/a06b47ba079b342d69a49d3cbad0fb546000f734/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java#L111)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
