[jira] [Commented] (MGPG-75) Creates a signature with the wrong name if a classifier is defined
[ https://issues.apache.org/jira/browse/MGPG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284622#comment-17284622 ] Łukasz Dywicki commented on MGPG-75: Exact problem is when the primary project artifact specifies an classifier. Then gpg mojo generates signature file but *without* classifier in its name. You end up with below files: * abcdef-1.0.0-SNAPSHOT-*features*.xml * abcdef-1.0.0-SNAPSHOT.asc This is not critical, but when release is made it does not pass upload principles for maven central. > Creates a signature with the wrong name if a classifier is defined > -- > > Key: MGPG-75 > URL: https://issues.apache.org/jira/browse/MGPG-75 > Project: Maven GPG Plugin > Issue Type: Bug >Reporter: Mike Hummel >Assignee: Robert Scholte >Priority: Major > > See pull request > [https://github.com/apache/maven-gpg-plugin/pull/2#event-2847163553] > > The main file of a feature project is a xml file and has a classifier. The > plugin ignores the classifier and creates a signature with wrong name. > > The feature is created by the apache karaf maven plugin. > > The fix also use the classifier to create the correct signature file. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MGPG-75) Creates a signature with the wrong name if a classifier is defined
[ https://issues.apache.org/jira/browse/MGPG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284582#comment-17284582 ] Mike Hummel commented on MGPG-75: - Sorry for bother you: What exactly is the problem if a 'feature' is the main artifact? It seems to be valide if the hole package is feature package that the main artifact IS the feature xml file. And maybe therefor the rule is NOT documented, because it's no a rule. (But I'm not in it to discuss in deep) > Creates a signature with the wrong name if a classifier is defined > -- > > Key: MGPG-75 > URL: https://issues.apache.org/jira/browse/MGPG-75 > Project: Maven GPG Plugin > Issue Type: Bug >Reporter: Mike Hummel >Assignee: Robert Scholte >Priority: Major > > See pull request > [https://github.com/apache/maven-gpg-plugin/pull/2#event-2847163553] > > The main file of a feature project is a xml file and has a classifier. The > plugin ignores the classifier and creates a signature with wrong name. > > The feature is created by the apache karaf maven plugin. > > The fix also use the classifier to create the correct signature file. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MGPG-75) Creates a signature with the wrong name if a classifier is defined
[
https://issues.apache.org/jira/browse/MGPG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266252#comment-17266252
]
Łukasz Dywicki commented on MGPG-75:
It is not. Not in case of custom packaging which Karaf made. In case of
"features" packaging main artifact can be a XML file with features classifier.
I was asking about documentation for what you said about primary artifact
because existing api permit to set build artifact with classifier
({{MavenProject.setArtifact}}).
If its not permitted then core API should refuse such artifact straight a way.
A rule, even undocumented, without enforcement is not a rule. It is a bug. ;)
> Creates a signature with the wrong name if a classifier is defined
> --
>
> Key: MGPG-75
> URL: https://issues.apache.org/jira/browse/MGPG-75
> Project: Maven GPG Plugin
> Issue Type: Bug
>Reporter: Mike Hummel
>Assignee: Robert Scholte
>Priority: Major
>
> See pull request
> [https://github.com/apache/maven-gpg-plugin/pull/2#event-2847163553]
>
> The main file of a feature project is a xml file and has a classifier. The
> plugin ignores the classifier and creates a signature with wrong name.
>
> The feature is created by the apache karaf maven plugin.
>
> The fix also use the classifier to create the correct signature file.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MGPG-75) Creates a signature with the wrong name if a classifier is defined
[ https://issues.apache.org/jira/browse/MGPG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265816#comment-17265816 ] Robert Scholte commented on MGPG-75: In that case the pom itself is the main artifact and all other artifacts are the classified subartifacts. > Creates a signature with the wrong name if a classifier is defined > -- > > Key: MGPG-75 > URL: https://issues.apache.org/jira/browse/MGPG-75 > Project: Maven GPG Plugin > Issue Type: Bug >Reporter: Mike Hummel >Assignee: Robert Scholte >Priority: Major > > See pull request > [https://github.com/apache/maven-gpg-plugin/pull/2#event-2847163553] > > The main file of a feature project is a xml file and has a classifier. The > plugin ignores the classifier and creates a signature with wrong name. > > The feature is created by the apache karaf maven plugin. > > The fix also use the classifier to create the correct signature file. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MGPG-75) Creates a signature with the wrong name if a classifier is defined
[ https://issues.apache.org/jira/browse/MGPG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265565#comment-17265565 ] Łukasz Dywicki commented on MGPG-75: [~rfscholte] can you please refer place where constraint you talk about is defined? The "it is not allowed that main artifacts have classifiers" seems pretty limiting. Given that some builds might produce platform specific artifacts (think of native builds) having classifiers for main artifacts shouldn't be prohibited. Its pretty sad that I was caught by this issue 19 months after PR solving it was submitted. > Creates a signature with the wrong name if a classifier is defined > -- > > Key: MGPG-75 > URL: https://issues.apache.org/jira/browse/MGPG-75 > Project: Maven GPG Plugin > Issue Type: Bug >Reporter: Mike Hummel >Assignee: Robert Scholte >Priority: Major > > See pull request > [https://github.com/apache/maven-gpg-plugin/pull/2#event-2847163553] > > The main file of a feature project is a xml file and has a classifier. The > plugin ignores the classifier and creates a signature with wrong name. > > The feature is created by the apache karaf maven plugin. > > The fix also use the classifier to create the correct signature file. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
