[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843424#comment-17843424 ] ASF GitHub Bot commented on MINVOKER-364: - slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235 > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843207#comment-17843207 ] ASF GitHub Bot commented on MINVOKER-364: - michael-o commented on PR #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235#issuecomment-2092931481 > not sure I understand this naming change, At the end of the day, those properties will be system properties used to fork the Maven invocation. So they are the system properties of the Maven invocation you want to run. you are confusing with Maven core naming but for an end user POV they are system properties. Those one you set using `-D...` when using the command line. This has been a mess created long time ago. We need to clean up. Maven should use for itself user props only. If the JVM requires sys props they need to be set *before* Maven invocation. `System.setProperty()` cannot guarantee that the actual property is picked up by the receiver. Some read only at startup. > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843200#comment-17843200 ] ASF GitHub Bot commented on MINVOKER-364: - slawekjaranowski commented on PR #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235#issuecomment-2092890200 exactly it are a `user properties` passed by `-D` Maven argument we have: ``` MAVEN_OPTS='-DsysProperty=xxx' mvn ... -DuserProperty=xxx ``` so `userProperty` it is a user property pass to Maven as cli argument We cen set a system property by `MAVEN_OPTS` environment variable > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843191#comment-17843191 ] ASF GitHub Bot commented on MINVOKER-364: - slawekjaranowski opened a new pull request, #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235 https://issues.apache.org/jira/browse/MINVOKER-364 > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[
https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843187#comment-17843187
]
Slawomir Jaranowski commented on MINVOKER-364:
--
{quote}
System properties are/will be handled separately?
{quote}
We have MAVEN_OPTS
> Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
> -
>
> Key: MINVOKER-364
> URL: https://issues.apache.org/jira/browse/MINVOKER-364
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.2
>
>
> Old property will be deprecated
> It are user properties added to cli - not a system properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843181#comment-17843181 ] Michael Osipov commented on MINVOKER-364: - System properties are/will be handled separately? > Rename invoker.systemPropertiesFile to invoker.userPropertiesFile > - > > Key: MINVOKER-364 > URL: https://issues.apache.org/jira/browse/MINVOKER-364 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.2 > > > Old property will be deprecated > It are user properties added to cli - not a system properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
