[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782716#comment-17782716 ] ASF GitHub Bot commented on MJAVADOC-713: - asfgit merged PR #246: URL: https://github.com/apache/maven-javadoc-plugin/pull/246 > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: next-release > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782715#comment-17782715 ] ASF GitHub Bot commented on MJAVADOC-713: - asfgit closed pull request #246: [MJAVADOC-713] Skipping Javadoc reportset leaves empty Javadoc link i… URL: https://github.com/apache/maven-javadoc-plugin/pull/246 > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: next-release > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780780#comment-17780780 ] ASF GitHub Bot commented on MJAVADOC-713: - michael-o opened a new pull request, #246: URL: https://github.com/apache/maven-javadoc-plugin/pull/246 …n site This closes #246 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: next-release > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780779#comment-17780779 ] Michael Osipov commented on MJAVADOC-713: - This plugin is a mess...preparing a PR. > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: next-release > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637601#comment-17637601 ] Slawomir Jaranowski commented on MJAVADOC-713: -- I confirm it. It is not possible to skip report generating in child projects in correct way, JavaDocs are not generate but empty directory and menu item is added. > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Priority: Major > Fix For: waiting-for-feedback > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534903#comment-17534903 ] Joshua commented on MJAVADOC-713: - [~michael-o] Any updates here? It says waiting for feedback and I have already provided a sample project. > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Priority: Major > Fix For: waiting-for-feedback > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523671#comment-17523671 ] Joshua commented on MJAVADOC-713: - Added. Just run mvn clean verify site. I included the target folder in case you didn't want to run "mvn clean verify site" To simplify the example I didn't use the parent pom. In my use case a parent pom is involved but I can reproduce the same issue without it. > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Priority: Major > Fix For: waiting-for-feedback > > Attachments: image-2022-04-15-17-47-49-771.png, sampleproject.zip > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MJAVADOC-713) Skipping Javadoc reportset leaves empty Javadoc link in site
[ https://issues.apache.org/jira/browse/MJAVADOC-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523090#comment-17523090 ] Michael Osipov commented on MJAVADOC-713: - Provide a sample project. > Skipping Javadoc reportset leaves empty Javadoc link in site > > > Key: MJAVADOC-713 > URL: https://issues.apache.org/jira/browse/MJAVADOC-713 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Joshua >Priority: Major > Attachments: image-2022-04-15-17-47-49-771.png > > > I am trying to skip a reportset that is inherited from a parent pom > This is what the report plugin looks like in the parent pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > javadoc-no-fork > > javadoc-no-fork > > > > test-javadoc-no-fork > > test-javadoc-no-fork > > > package > > > > > I don't want the test-javadoc-no-fork report in my project > > If I do this in my pom > > org.apache.maven.plugins > maven-javadoc-plugin > > > test-javadoc-no-fork > > true > > > > > > It will skip the Javadoc generation but still adds a link to site and when > you click on the link you get a 404 since the test Javadoc wasn't inherited. > !image-2022-04-15-17-47-49-771.png! > I logged this as a defect because I would think skip would prevent the > Javadoc generation and NOT add a link to the site for a report set that > wasn't generated. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
