[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-04-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527101#comment-17527101
 ] 

Hudson commented on MNG-5180:
-

Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-03-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510851#comment-17510851
 ] 

Hudson commented on MNG-5180:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7276 #4

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7276/4/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498638#comment-17498638
 ] 

Hudson commented on MNG-5180:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » PR-509 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-509/2/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498629#comment-17498629
 ] 

Hudson commented on MNG-5180:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » PR-394 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-394/2/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498624#comment-17498624
 ] 

Hudson commented on MNG-5180:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-600 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-600/2/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498610#comment-17498610
 ] 

Hudson commented on MNG-5180:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-661 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-661/2/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498601#comment-17498601
 ] 

Hudson commented on MNG-5180:
-

Build failed in Jenkins: Maven » Maven TLP » maven » PR-635 #3

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-635/3/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498575#comment-17498575
 ] 

Hudson commented on MNG-5180:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/3/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498576#comment-17498576
 ] 

Hudson commented on MNG-5180:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » master #3

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/3/

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-23 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496869#comment-17496869
 ] 

Konrad Windszus commented on MNG-5180:
--

In the PR there are more details now, actually {{snapshot->timestamp}} and 
{{snapshotVersions->updated}} are different formats. I also clarified that in 
the mdo. Also the metadata file is only containing info about the most recent 
artifacts (not all old ones with the same SNAPSHOT version).

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-23 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496868#comment-17496868
 ] 

Michael Osipov commented on MNG-5180:
-

{quote}
How to calculate versioning->snapshot->buildNumber when merging modified the 
snapshot versions? Probably we just take over during merge without touching.
{quote}

Increment?

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-23 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496866#comment-17496866
 ] 

Michael Osipov commented on MNG-5180:
-

{quote}
Is {{versioning->snapshot->timestamp}} the same date format as 
{{{}versioning->snapshotVersions->updated{}}}?
{quote}
I would assume so.

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-23 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496863#comment-17496863
 ] 

Michael Osipov commented on MNG-5180:
-

{quote}The {{versioning->snapshot}} should always contain the most recent item, 
i.e. the one with the more recent {{{}versioning->snapshot->timestamp{}}}.
[~michael-o] WDYT?
{quote}

Correct.

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-22 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496202#comment-17496202
 ] 

Konrad Windszus commented on MNG-5180:
--

Actually even 
https://repository.apache.org/content/repositories/snapshots/org/apache/maven/maven-core/4.0.0-alpha-1-SNAPSHOT/maven-metadata.xml
 seems to be broken, as although I see 4 different version for both "jar" and 
"pom" only one version is listed in the snapshotVersions.

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-22 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496164#comment-17496164
 ] 

Michael Osipov commented on MNG-5180:
-

No, as far as I know only these two. 

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-22 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496160#comment-17496160
 ] 

Konrad Windszus commented on MNG-5180:
--

The idea is, that this merging is agnostic of the resolver provider impl, but I 
will check that the one in Maven behaves the same. Are there any other Resolver 
provider impls to consider?

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-22 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496156#comment-17496156
 ] 

Michael Osipov commented on MNG-5180:
-

[~kwin], before going through your comment, I remember that Resolver handles 
this as well. So both logics (here an Resolver) should be consistent. Please 
have a look there before we continue discussion.

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2022-02-21 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495909#comment-17495909
 ] 

Konrad Windszus commented on MNG-5180:
--

I think the logic for merging {{versioning->snapshotVersions}} should be as 
follows according to 
https://maven.apache.org/ref/3.8.3/maven-repository-metadata/repository-metadata.html:

# classifier, extension and value act as key in the list
# every item in the list must have a unique key
# if an item with the same key is already in the list, the merged {{updated}} 
value should be used in the resulting item

The {{versioning->snapshotVersion}} should always contain the most recent item, 
i.e. the one from the {{snapshotVersions}} list with the most recent updated 
timestamp.
[~michael-o] WDYT?

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Assignee: Michael Osipov
>Priority: Major
>  Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2020-10-04 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207735#comment-17207735
 ] 

Michael Osipov commented on MNG-5180:
-

[~patope], looking at this. As far as I undertand, the plugin's goal does not 
work correctly because of this bug? Can you provide an example or an IT with 
shows this issue?

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2020-09-07 Thread Tomi Pakarinen (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191669#comment-17191669
 ] 

Tomi Pakarinen commented on MNG-5180:
-

I made PR [https://github.com/apache/maven/pull/371]
This replaces snapshots versions during merge if version is new, timestamp or 
build number have changed.

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2020-09-01 Thread Tomi Pakarinen (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188449#comment-17188449
 ] 

Tomi Pakarinen commented on MNG-5180:
-

This is still valid issue. Wagon plugin's 'merge-maven-repos' task do not 
update metadata correctly on snapshots because of this

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2019-07-24 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892166#comment-16892166
 ] 

Michael Osipov commented on MNG-5180:
-

Does this one still apply?

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2018-11-14 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687031#comment-16687031
 ] 

ASF GitHub Bot commented on MNG-5180:
-

fuss86 closed pull request #191: [MNG-5180] - Versioning's snapshot version 
list is not included in metadata merge 
URL: https://github.com/apache/maven/pull/191
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-repository-metadata/src/main/mdo/metadata.mdo 
b/maven-repository-metadata/src/main/mdo/metadata.mdo
index e2d0753397..82f3cc1575 100644
--- a/maven-repository-metadata/src/main/mdo/metadata.mdo
+++ b/maven-repository-metadata/src/main/mdo/metadata.mdo
@@ -202,6 +202,30 @@ under the License.
 changed = true;
 }
 }
+
+for ( SnapshotVersion snapshotVersion : 
versioning.getSnapshotVersions() )
+{
+boolean exists = false;
+
+for ( SnapshotVersion sv : v.getSnapshotVersions() )
+{
+if ( java.util.Objects.equals( 
snapshotVersion.getClassifier(), sv.getClassifier() ) &&
+ java.util.Objects.equals( 
snapshotVersion.getExtension(), sv.getExtension() ) &&
+ java.util.Objects.equals( 
snapshotVersion.getUpdated(), sv.getUpdated() ) &&
+ java.util.Objects.equals( 
snapshotVersion.getVersion(), sv.getVersion() ) )
+{
+exists = true;
+break;
+}
+}
+
+if (!exists)
+{
+changed = true;
+v.getSnapshotVersions().add( snapshotVersion );
+}
+}
+
 }
 }
 return changed;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2018-11-14 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687030#comment-16687030
 ] 

ASF GitHub Bot commented on MNG-5180:
-

fuss86 commented on issue #191: [MNG-5180] - Versioning's snapshot version list 
is not included in metadata merge 
URL: https://github.com/apache/maven/pull/191#issuecomment-438792816
 
 
   Based on 
http://maven.apache.org/ref/3.6.0/maven-repository-metadata/repository-metadata.html
   
   > Versioning information for a sub-artifact of the current snapshot artifact.
   
   this fix is wrong


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2018-11-12 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683518#comment-16683518
 ] 

Przemysław Fusik commented on MNG-5180:
---

https://github.com/apache/maven/pull/191

> Versioning's snapshot version list is not included in metadata merge  
> --
>
> Key: MNG-5180
> URL: https://issues.apache.org/jira/browse/MNG-5180
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.0.3
>Reporter: Noam Y. Tenne
>Priority: Major
> Attachments: MavenMetadataSnapshotVersionsMergeTest.java
>
>
> Versioning#snapshotVersions is not being merged when using Metadata#merge.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)