[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851786#comment-17851786
]
Elliotte Rusty Harold commented on MNG-5693:
should be fixed at head which I think is 4.x. If we want this in 3.9, the fix
will need to be backported.
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed. For users this is very confusing. Even when they finally see a link,
> it's quite frustrating for them that they still don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851785#comment-17851785
]
ASF GitHub Bot commented on MNG-5693:
-
elharo merged PR #1545:
URL: https://github.com/apache/maven/pull/1545
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed. For users this is very confusing. Even when they finally see a link,
> it's quite frustrating for them that they still don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851738#comment-17851738
]
ASF GitHub Bot commented on MNG-5693:
-
slawekjaranowski commented on PR #1545:
URL: https://github.com/apache/maven/pull/1545#issuecomment-2145746912
For master branch we have: #1550 after merge build should pass
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed. For users this is very confusing. Even when they finally see a link,
> it's quite frustrating for them that they still don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851705#comment-17851705
]
ASF GitHub Bot commented on MNG-5693:
-
gnodet commented on PR #1545:
URL: https://github.com/apache/maven/pull/1545#issuecomment-2145550737
> Is the MacOS CI borked?
yes, see https://github.com/apache/maven/pull/1548
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed. For users this is very confusing. Even when they finally see a link,
> it's quite frustrating for them that they still don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851067#comment-17851067
]
ASF GitHub Bot commented on MNG-5693:
-
elharo commented on PR #1545:
URL: https://github.com/apache/maven/pull/1545#issuecomment-2142050136
Is the MacOS CI borked?
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed. For users this is very confusing. Even when they finally see a link,
> it's quite frustrating for them that they still don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851058#comment-17851058
]
ASF GitHub Bot commented on MNG-5693:
-
elharo commented on PR #1545:
URL: https://github.com/apache/maven/pull/1545#issuecomment-2141909545
Error: Failures:
Error:
MavenITmng5482AetherNotFoundTest.testPluginDependency:47->check:82->AbstractMavenIntegrationTestCase.assertTrue:359
Url to ClassNotFoundAether was not found in output. ==> expected: but
was:
Error:
MavenITmng5482AetherNotFoundTest.testPluginSite:52->check:82->AbstractMavenIntegrationTestCase.assertTrue:359
Url to ClassNotFoundAether was not found in output. ==> expected: but
was:
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed. For users this is very confusing. Even when they finally see a link,
> it's quite frustrating for them that they still don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851048#comment-17851048
]
ASF GitHub Bot commented on MNG-5693:
-
elharo opened a new pull request, #1545:
URL: https://github.com/apache/maven/pull/1545
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851047#comment-17851047
]
Elliotte Rusty Harold commented on MNG-5693:
Fixable here:
https://github.com/apache/maven/blob/dd9679450e00d08caf4f042d92c22acd38585bd5/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L994
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841240#comment-17841240
]
Juul Hobert commented on MNG-5693:
--
[~rfscholte] I think it's a really good idea to give plugins the ability to
provide additional information to be logged to console. I see that there has
been an attempt in the past. Would it still make sense to work on this ticket?
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216332#comment-17216332
]
Michael Osipov commented on MNG-5693:
-
Classes to be touched:
* org.apache.maven.exception.DefaultExceptionHandler
* org.apache.maven.exception.ExceptionSummary
* org.apache.maven.exception.DefaultExceptionHandlerTest
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.7.0-candidate
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735012#comment-16735012
]
Hudson commented on MNG-5693:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658257#comment-16658257
]
Hudson commented on MNG-5693:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-5693 #2
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/2/
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.0-candidate
>
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648428#comment-16648428
]
Robert Scholte commented on MNG-5693:
-
Not sure if this should be solved with the same commit, but it often happens
that Maven is blamed for plugin exceptions. In general I would expect that
RuntimeExceptions when executing a mojo are plugin issues. We might add logging
with this: the problematic plugin and the Issue Management URL to search and
register this issue.
This should improve the quality is created issues.
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.0-candidate
>
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952059#comment-14952059
]
Robert Scholte commented on MNG-5693:
-
I don't know how this part of the code looks like, but these messages should be
removed. There are probably more wiki-references which can be removed, maybe
worth trying to track those too.
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952009#comment-14952009
]
Michael Osipov commented on MNG-5693:
-
Robert, I absolutely support that. The reference to the wiki is absolutely
useless. I would like to create a sub task and remove those messages as a first
step. What do you think?
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
