[jira] [Commented] (MNG-5909) Activating a profile based on the existence of multiple files is not possible

[Robert Scholte (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314882#comment-17314882
 ] 

Robert Scholte commented on MNG-5909:
-

I don't think we should do anything about this in Maven 4. The list of wishes 
regarding profile activation is exploding so I think we need to take the time 
to review new opportunities in Maven 5.
IIRC some people already extended profile activation with Maven Extensions, 
e.g. https://github.com/random-maven/profile-activator-extension, so that is 
always a possible way to support it.


> Activating a profile based on the existence of multiple files is not possible
> -
>
> Key: MNG-5909
> URL: https://issues.apache.org/jira/browse/MNG-5909
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.3.3
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently each type of activation (os, jdk, file, property) can only be used 
> once for activating a single profile.
> Therefore it is not possible to activate a profile in case two different 
> files are existing, although since Maven 3.2.2 (MNG-4565) it is possible to 
> combine multiple activations of different types.
> Multiple  {{file}} or {{property}} should therefore be supported to allow to 
> express something like:
> Enable {{profileA}} in case both {{fileA}} and {{fileB}} do exists
> For {{jdk}} and {{os}} this is less relevant because all conditions are 
> combined with AND.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-5909) Activating a profile based on the existence of multiple files is not possible

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314806#comment-17314806
 ] 

Michael Osipov commented on MNG-5909:
-

I don't have any storng opinion about this, but I understand that people need 
more flexibility. [~rfscholte], [~hboutemy], is this something we'd like to 
support in 4?

> Activating a profile based on the existence of multiple files is not possible
> -
>
> Key: MNG-5909
> URL: https://issues.apache.org/jira/browse/MNG-5909
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.3.3
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently each type of activation (os, jdk, file, property) can only be used 
> once for activating a single profile.
> Therefore it is not possible to activate a profile in case two different 
> files are existing, although since Maven 3.2.2 (MNG-4565) it is possible to 
> combine multiple activations of different types.
> Multiple  {{file}} or {{property}} should therefore be supported to allow to 
> express something like:
> Enable {{profileA}} in case both {{fileA}} and {{fileB}} do exists
> For {{jdk}} and {{os}} this is less relevant because all conditions are 
> combined with AND.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-5909) Activating a profile based on the existence of multiple files is not possible

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560396#comment-16560396
 ] 

ASF GitHub Bot commented on MNG-5909:
-

lbndev commented on issue #92: MNG-5909 : Add combined expression evaluator to 
file activation property
URL: https://github.com/apache/maven/pull/92#issuecomment-408550574
 
 
   Hello @kwin,
   
   Wow, resurrecting an old request !
   I rebased my change on branch "pre-reset-master" (see branch 
MNG-5909-oldmaster), then I cherry-picked in on top of the new master, fixing 
conflicts.
   
   It used to work on the initial version of this PR (almost 2 years ago), but 
I should take time to build & test this new version just to make sure it plays 
nicely with all the other changes in maven over the last 2 years. Maybe I'll 
find time during the weekend.
   
   Thanks for your interrest in this PR
   
   Loïc


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Activating a profile based on the existence of multiple files is not possible
> -
>
> Key: MNG-5909
> URL: https://issues.apache.org/jira/browse/MNG-5909
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.3.3
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently each type of activation (os, jdk, file, property) can only be used 
> once for activating a single profile.
> Therefore it is not possible to activate a profile in case two different 
> files are existing, although since Maven 3.2.2 (MNG-4565) it is possible to 
> combine multiple activations of different types.
> Multiple  {{file}} or {{property}} should therefore be supported to allow to 
> express something like:
> Enable {{profileA}} in case both {{fileA}} and {{fileB}} do exists
> For {{jdk}} and {{os}} this is less relevant because all conditions are 
> combined with AND.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-5909) Activating a profile based on the existence of multiple files is not possible

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527370#comment-16527370
 ] 

ASF GitHub Bot commented on MNG-5909:
-

kwin commented on issue #92: MNG-5909 : Add combined expression evaluator to 
file activation property
URL: https://github.com/apache/maven/pull/92#issuecomment-401308116
 
 
   @lbndev Can you redo the PR only containing the actual change (IIUC this is 
only commit 
https://github.com/apache/maven/pull/92/commits/2efe3d2d3b92685d83c2598a7f85c39ebdd59ebc).
 Otherwise it is impossible to review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Activating a profile based on the existence of multiple files is not possible
> -
>
> Key: MNG-5909
> URL: https://issues.apache.org/jira/browse/MNG-5909
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.3.3
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently each type of activation (os, jdk, file, property) can only be used 
> once for activating a single profile.
> Therefore it is not possible to activate a profile in case two different 
> files are existing, although since Maven 3.2.2 (MNG-4565) it is possible to 
> combine multiple activations of different types.
> Multiple  {{file}} or {{property}} should therefore be supported to allow to 
> express something like:
> Enable {{profileA}} in case both {{fileA}} and {{fileB}} do exists
> For {{jdk}} and {{os}} this is less relevant because all conditions are 
> combined with AND.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-5909) Activating a profile based on the existence of multiple files is not possible

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527367#comment-16527367
 ] 

Konrad Windszus commented on MNG-5909:
--

As the PR from above is somehow not showing the changes, the relevant commit id 
is: 
https://github.com/apache/maven/pull/92/commits/2efe3d2d3b92685d83c2598a7f85c39ebdd59ebc

> Activating a profile based on the existence of multiple files is not possible
> -
>
> Key: MNG-5909
> URL: https://issues.apache.org/jira/browse/MNG-5909
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.3.3
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently each type of activation (os, jdk, file, property) can only be used 
> once for activating a single profile.
> Therefore it is not possible to activate a profile in case two different 
> files are existing, although since Maven 3.2.2 (MNG-4565) it is possible to 
> combine multiple activations of different types.
> Multiple  {{file}} or {{property}} should therefore be supported to allow to 
> express something like:
> Enable {{profileA}} in case both {{fileA}} and {{fileB}} do exists
> For {{jdk}} and {{os}} this is less relevant because all conditions are 
> combined with AND.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-5909) Activating a profile based on the existence of multiple files is not possible

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425449#comment-15425449
 ] 

ASF GitHub Bot commented on MNG-5909:
-

GitHub user lbndev opened a pull request:

https://github.com/apache/maven/pull/92

MNG-5909 : Add combined expression evaluator to file activation property

Suggested solution for MNG-5909 : the file activation element will 
understand basic boolean expressions such as and(file1,file2) or(file3,!file4) 
etc... Please see added unit test for expression examples.
If you think this could benefit to other activators (property, os, ...) 
please say so and I will happily modify them too.
I will also post a message on maven dev mailing list.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lbndev/maven MNG-5909

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #92


commit 2efe3d2d3b92685d83c2598a7f85c39ebdd59ebc
Author: Loïc B 
Date:   2016-08-16T09:21:52Z

Add combined expression evaluator to file activation property




> Activating a profile based on the existence of multiple files is not possible
> -
>
> Key: MNG-5909
> URL: https://issues.apache.org/jira/browse/MNG-5909
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.3.3
>Reporter: Konrad Windszus
>
> Currently each type of activation (os, jdk, file, property) can only be used 
> once for activating a single profile.
> Therefore it is not possible to activate a profile in case two different 
> files are existing, although since Maven 3.2.2 (MNG-4565) it is possible to 
> combine multiple activations of different types.
> Multiple  {{file}} or {{property}} should therefore be supported to allow to 
> express something like:
> Enable {{profileA}} in case both {{fileA}} and {{fileB}} do exists
> For {{jdk}} and {{os}} this is less relevant because all conditions are 
> combined with AND.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)