[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429462#comment-16429462 ] ASF GitHub Bot commented on MNG-6389: - rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379483074 This is an important line in the javadoc: > This is a hand-crafted prototype of the default model merger that should eventually be generated by Modello So in the end the merger should be generated based on the `.mdo` file. This means that `MavenToolchainMerger` indeed belongs to the maven-toolchain artifact. In the end there should be no manual code in this artifact, only generated code, hence my original comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429463#comment-16429463 ] ASF GitHub Bot commented on MNG-6389: - rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379483074 This is an important line in the javadoc: > This is a hand-crafted prototype of the default model merger that should eventually be generated by Modello So in the end the merger should be generated based on the `.mdo` file. This means that `MavenToolchainMerger` indeed belongs to the maven-toolchain artifact. In the end there should be no manual code in this artifact, only generated code, hence my original comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429437#comment-16429437 ] ASF GitHub Bot commented on MNG-6389: - gastaldi commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379480155 >I don't think the MavenToolchainMerger belongs there Are you sure about that? The `maven-model` project has a merger too: https://github.com/apache/maven/blob/master/maven-model/src/main/java/org/apache/maven/model/merge/ModelMerger.java This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428773#comment-16428773 ] ASF GitHub Bot commented on MNG-6389: - gastaldi commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379342643 Ok let me know what those are or feel free to push directly to my branch as a new commit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428761#comment-16428761 ] ASF GitHub Bot commented on MNG-6389: - rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379341185 I have to look closely if all required actions are done. E.g. new modules also means updating `maven/src/site/xdoc/maven-deps.odg`. Not sure if this is the only doc that needs to be updated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426411#comment-16426411 ] ASF GitHub Bot commented on MNG-6389: - gastaldi commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-378801064 @rfscholte I created the maven-toolchain-builder module with the matching packages, see if that works for you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426146#comment-16426146 ] ASF GitHub Bot commented on MNG-6389: - rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-378739685 I don't think the MavenToolchainMerger belongs there. If you take a look at https://maven.apache.org/ref/3.5.3/ I would say we should also introduce a maven-toolchain-builder and move all matching packages to that artifact. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > Fix For: 3.5.4-candidate > > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425978#comment-16425978 ] ASF GitHub Bot commented on MNG-6389: - gastaldi commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-378700225 @rfscholte can you review and merge when possible? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425967#comment-16425967 ] George Gastaldi commented on MNG-6389: -- Created a PR generating this artifact back with the same coordinates https://github.com/apache/maven/pull/162 > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425963#comment-16425963 ] ASF GitHub Bot commented on MNG-6389: - gastaldi opened a new pull request #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6389) Move the toolchains model to a separate artifactId
[ https://issues.apache.org/jira/browse/MNG-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425830#comment-16425830 ] Robert Scholte commented on MNG-6389: - There used to be a separate [maven-toolchain|http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.apache.maven%22%20AND%20a%3A%22maven-toolchain%22] artifact, don't know why it was dropped. I agree that it makes sense to have a separate artifact for the toolchain model. > Move the toolchains model to a separate artifactId > -- > > Key: MNG-6389 > URL: https://issues.apache.org/jira/browse/MNG-6389 > Project: Maven > Issue Type: Improvement > Components: Toolchains >Affects Versions: 3.5.3 >Reporter: George Gastaldi >Priority: Major > > Just as maven-model and maven-settings, it would be nice to have a > maven-toolchains artifactId containing only the model. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
