[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-08-23 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757875#comment-17757875
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet merged PR #1194:
URL: https://github.com/apache/maven/pull/1194




> Support proxy port interpolation in settings.xml
> 
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: New Feature
>  Components: Bootstrap & Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 4.0.0-alpha-8
>
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740264#comment-17740264
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1253281717


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+
+  
+
+
+  2.0.0+
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740263#comment-17740263
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1253281717


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+
+  
+
+
+  2.0.0+
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740260#comment-17740260
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1253270018


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+
+  
+
+
+  2.0.0+
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740258#comment-17740258
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1253270018


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+
+  
+
+
+  2.0.0+
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740254#comment-17740254
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1253258499


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739901#comment-17739901
 ] 

ASF GitHub Bot commented on MNG-6401:
-

elharo commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251925120


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+
+  
+
+
+  2.0.0+
+  
+
   
-
-  active
+
+  activeString
   1.0.0+
   false
   true
   
 

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739750#comment-17739750
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251331770


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -459,17 +459,19 @@
 The  element contains informations required 
to a proxy settings.
 ]]>
   
-
-  active
+
+  activeString
   1.0.0+
   false
   true
   
 

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739749#comment-17739749
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251332842


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+
+  
+
+
+  2.0.0+
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739747#comment-17739747
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251331770


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -459,17 +459,19 @@
 The  element contains informations required 
to a proxy settings.
 ]]>
   
-
-  active
+
+  activeString
   1.0.0+
   false
   true
   
 

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739746#comment-17739746
 ] 

ASF GitHub Bot commented on MNG-6401:
-

gnodet commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251330034


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -535,6 +539,62 @@
   String
 
   
+  
+
+  1.0.0/1.3.0
+  
+

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739736#comment-17739736
 ] 

ASF GitHub Bot commented on MNG-6401:
-

elharo commented on code in PR #1194:
URL: https://github.com/apache/maven/pull/1194#discussion_r1251298102


##
api/maven-api-settings/src/main/mdo/settings.mdo:
##
@@ -459,17 +459,19 @@
 The  element contains informations required 
to a proxy settings.
 ]]>
   
-
-  active
+
+  activeString
   1.0.0+
   false
   true
   
 
+  
+
+
+  2.0.0+
+  
+
+  
+
+
+  2.0.0+
+  
+