[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876187#comment-16876187
]
Hudson commented on MNG-6432:
-
Build succeeded in Jenkins: Maven TLP » maven-site » master #84
See https://builds.apache.org/job/maven-box/job/maven-site/job/master/84/
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
> Fix For: wontfix-candidate
>
> Attachments: Possible list of hits.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876060#comment-16876060
]
Elias Elmqvist Wulcan commented on MNG-6432:
I finally found some time and have created a PR for maven-site now, [~michael-o]
[https://github.com/apache/maven-site/pull/90]
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
> Fix For: wontfix-candidate
>
> Attachments: Possible list of hits.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861840#comment-16861840
]
Elias Elmqvist Wulcan commented on MNG-6432:
I cannot right now but I will try to find time to learn how to and then provide
a PR. Thank you again for your time.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
> Fix For: wontfix-candidate
>
> Attachments: Possible list of hits.png
>
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861828#comment-16861828
]
Michael Osipov commented on MNG-6432:
-
Again, validation shall be applied to all splitters were this can happen. Not
only mirrors. Can you provide a PR for the doc update what would reflect the
pitfall?
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
> Fix For: wontfix-candidate
>
> Attachments: Possible list of hits.png
>
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861799#comment-16861799
]
Elias Elmqvist Wulcan commented on MNG-6432:
Have you considered adding a validation step to the parsed ids instead of
automatically trimming whitespace? Even if it is impossible to know which ids
are defined, it should be possible to immediately deny ids with leading or
trailing whitespace as such ids would be hard or impossible to define in an xml
file.
If validation is impossible too, then please add a warning to the
documentation. Using a repository even when developer has tried to block it is
a potential security issue.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
> Fix For: wontfix-candidate
>
> Attachments: Possible list of hits.png
>
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861090#comment-16861090
]
Michael Osipov commented on MNG-6432:
-
I'd like to close this because the parsing won't change in 3.x. All docs say
"comma separated". Whitespace trimming isn't mentioned.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
> Fix For: wontfix-candidate
>
> Attachments: Possible list of hits.png
>
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522547#comment-16522547
]
Michael Osipov commented on MNG-6432:
-
Just checked profiles and project list. Both apply the same logic. I'd like to
keep it consistent. At best, we would alter the docs and transform this request
into: Ignore leading and trailing whitespace around comma-separated args.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522540#comment-16522540
]
Michael Osipov commented on MNG-6432:
-
I understand your issue. First of all, this is a shortcoming of our docs not
clearly depicting the format. Moreover, the syntax is simply applied with a
{{split}} on comma. No space magic. I do not know how other comma-separated
parts are parsed (e.g., profiles and projects via CLI), but I'd like to keep it
consistent.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521940#comment-16521940
]
Elias Elmqvist Wulcan commented on MNG-6432:
Thank you for looking in to this, [~michael-o]. I have not had the time to read
the source code but I did read that documentation and it did not help me avoid
this trap.
The intended semantic of my example is that all repositories except my-repo
should be disabled.
What I expected was that a single space after a comma would not change the
interpretation of the configuration, or that an error message would be thrown
about bad syntax.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520726#comment-16520726
]
Michael Osipov commented on MNG-6432:
-
I do not really see a bug here. The documentation says
bq. The position of wildcards within a comma separated list of repository
identifiers is not important as the wildcards defer to further processing and
explicit includes or excludes stop the processing, overruling any wildcard
match.
Nothing about leading or trailing whitespace.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Priority: Minor
> Labels: newbie
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
