[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684737#comment-17684737 ] ASF GitHub Bot commented on MNG-6609: - kwin commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1419229957 Already tracked in https://issues.apache.org/jira/browse/MNGSITE-502, will prepare a PR for that. > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-3, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684672#comment-17684672 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1419071474 @delanym you mean the original issue? (as this PR was "just" a fire extinguish/fix for original one). Seems we missed it, @kwin ? Created https://issues.apache.org/jira/browse/MSITE-923 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-3, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684669#comment-17684669 ] ASF GitHub Bot commented on MNG-6609: - delanym commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1419057631 @cstamas where is this documented? I don't see any change to https://maven.apache.org/guides/introduction/introduction-to-profiles.html > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-3, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642479#comment-17642479 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #92 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/92/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642180#comment-17642180 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #141 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/141/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641913#comment-17641913 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #140 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/140/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641878#comment-17641878 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #91 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/91/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641859#comment-17641859 ] ASF GitHub Bot commented on MNG-6609: - cstamas merged PR #883: URL: https://github.com/apache/maven/pull/883 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641815#comment-17641815 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1333554347 IT fixed https://github.com/apache/maven-integration-testing/pull/214#pullrequestreview-1200730814 So am to merge this PR. > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641218#comment-17641218 ] ASF GitHub Bot commented on MNG-6609: - kwin commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1331933054 I could no longer bring it to fail with my original approach from https://github.com/apache/maven/pull/849 (i.e. it always succeeds) > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641214#comment-17641214 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1331930222 @kwin so does the new IT work? you mentioned something it does not fail with your commit? > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640186#comment-17640186 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1329563048 Jut wanted to quickly "publish" my findings about the cause, but around same time moved to something else :smile: feel free to reuse (no need to keep my user ID, after all this is your change set with my one line removal). Or, I can pick it up later. > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1764#comment-1764 ] ASF GitHub Bot commented on MNG-6609: - cstamas opened a new pull request, #883: URL: https://github.com/apache/maven/pull/883 In short: do NOT set request.setRawModel as NOTHING sets it. The Maven4 vs Maven3 is different, in Maven 3 NOTHING calls request.setRawModel --- https://issues.apache.org/jira/browse/MNG-6609 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639915#comment-17639915 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #90 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/90/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639872#comment-17639872 ] Hudson commented on MNG-6609: - Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #89 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/89/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639855#comment-17639855 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328688104 Reverted https://github.com/apache/maven/commit/36ff9a65e637cc9054c0ed04814305a0493b701b > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639856#comment-17639856 ] ASF GitHub Bot commented on MNG-6609: - marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328688509 Thank you! > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639852#comment-17639852 ] ASF GitHub Bot commented on MNG-6609: - marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328681091 Sounds like a good idea! Would it be possible to revert the merge and reopen the original Jira issue? > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639851#comment-17639851 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328676497 I think @marcphilipp example above should be added as IT, as obviously this commit slipped and was not noticed by IT suite. > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639850#comment-17639850 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328675042 Spotted yesterday, created https://issues.apache.org/jira/browse/MNG-7606 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639848#comment-17639848 ] ASF GitHub Bot commented on MNG-6609: - marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328673965 @kwin Merging this PR broke simple use cases such as: ```xml http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> 4.0.0 com.example some-project 0.1-SNAPSHOT org.springframework.boot spring-boot-starter-parent 2.7.2 org.junit.jupiter junit-jupiter-engine test ``` Build Output: ```console $ mvn clean verify [INFO] Scanning for projects... [ERROR] [ERROR] Some problems were encountered while processing the POMs: [ERROR] 'dependencies.dependency.version' for org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 18, column 21 @ [ERROR] The build could not read 1 project -> [Help 1] [ERROR] [ERROR] The project com.example:some-project:0.1-SNAPSHOT (/Users/marc/Desktop/mvn-reproducer/pom.xml) has 1 error [ERROR] 'dependencies.dependency.version' for org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 18, column 21 [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException ``` > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639677#comment-17639677 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #88 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/88/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639674#comment-17639674 ] ASF GitHub Bot commented on MNG-6609: - kwin merged PR #849: URL: https://github.com/apache/maven/pull/849 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634975#comment-17634975 ] Hudson commented on MNG-6609: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-833 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-833/2/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626115#comment-17626115 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #77 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/77/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625904#comment-17625904 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-810 #7 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-810/7/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625331#comment-17625331 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-847 #5 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-847/5/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624766#comment-17624766 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #116 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/116/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624021#comment-17624021 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-823 #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-823/4/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624004#comment-17624004 ] Hudson commented on MNG-6609: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-847 #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-847/4/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623140#comment-17623140 ] Hudson commented on MNG-6609: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-849 #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-849/4/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623133#comment-17623133 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #115 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/115/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623118#comment-17623118 ] ASF GitHub Bot commented on MNG-6609: - kwin opened a new pull request, #849: URL: https://github.com/apache/maven/pull/849 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623109#comment-17623109 ] ASF GitHub Bot commented on MNG-6609: - kwin merged PR #835: URL: https://github.com/apache/maven/pull/835 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622159#comment-17622159
]
ASF GitHub Bot commented on MNG-6609:
-
kwin commented on code in PR #835:
URL: https://github.com/apache/maven/pull/835#discussion_r1001597973
##
maven-model-builder/src/main/java/org/apache/maven/model/profile/ProfileActivationContext.java:
##
@@ -30,6 +30,12 @@
*/
public interface ProfileActivationContext
{
+/**
+ * Key of the property containing the project's packaging.
+ * Available in {@link #getUserProperties()}.
+ * @since 4.0
+ */
+String PROPERTY_NAME_PACKAGING = "project.packaging";
Review Comment:
Good point, will change that
> Profile activation by packaging
>
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622155#comment-17622155
]
ASF GitHub Bot commented on MNG-6609:
-
gnodet commented on code in PR #835:
URL: https://github.com/apache/maven/pull/835#discussion_r1001591928
##
maven-model-builder/src/main/java/org/apache/maven/model/profile/ProfileActivationContext.java:
##
@@ -30,6 +30,12 @@
*/
public interface ProfileActivationContext
{
+/**
+ * Key of the property containing the project's packaging.
+ * Available in {@link #getUserProperties()}.
+ * @since 4.0
+ */
+String PROPERTY_NAME_PACKAGING = "project.packaging";
Review Comment:
Shouldn't that be `packaging` to align with
https://github.com/apache/maven/blob/2a9f39336cec1d8e52d30cc48503d51ed8672536/maven-model-builder/src/main/java/org/apache/maven/model/path/ProfileActivationFilePathInterpolator.java#L75-L82
I think the same reasoning apply, we don't support all `project.*`
properties...
> Profile activation by packaging
>
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622137#comment-17622137 ] ASF GitHub Bot commented on MNG-6609: - kwin commented on PR #835: URL: https://github.com/apache/maven/pull/835#issuecomment-1286667062 Agreed, it is kind of a workaround, but given that I think it is consensus to stick with POM 4.0 for Maven 4 this is the only near term solution I could come up with. > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622135#comment-17622135 ] ASF GitHub Bot commented on MNG-6609: - gnodet commented on PR #835: URL: https://github.com/apache/maven/pull/835#issuecomment-1286665218 That really looks like a hack to avoid defining a new activation type to me. Shouldn't we extend the model to add a packaging based activation ? > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620018#comment-17620018 ] ASF GitHub Bot commented on MNG-6609: - kwin opened a new pull request, #835: URL: https://github.com/apache/maven/pull/835 This can be used for packaging specific profiles with the property activator. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ IT PR in https://github.com/apache/maven-integration-testing/pull/206 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619760#comment-17619760
]
Casper Roubos commented on MNG-6609:
I would hereby ask for your attention for this improvement (or perhaps bug,
since it's normal project property):
I would like to have this working as profile activation:
{code:java}
eclipse-test-pluginProfile
project.packaging
eclipse-test-plugin
...
{code}
Thanks in advance for your effort and time. This would be a big improvement in
simplifying our parent poms.
> Profile activation by packaging
>
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810799#comment-16810799 ] Konrad Windszus commented on MNG-6609: -- [~rfscholte] Got the idea, I somehow thought that this would already work in Maven, but you are basically just proposing on how to fix that in the future... > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809988#comment-16809988
]
Robert Scholte commented on MNG-6609:
-
* {{true}} means it is inherited by all
* {{false}} means it is inherited by none (only
effective on current pom)
* {{jar}} would mean it is only inherited by projects
with packaging:jar. This will be a responsibility of Maven and requires an
explicit version. Once implemented and you're trying to run thi with an older
version of Maven, it'll complain for an invalid value for inherited.
regarding the docs, the idea is documented somewhere, I would expected this
(huge) page, but I might be wrong.
> Profile activation by packaging
>
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809573#comment-16809573
]
Konrad Windszus commented on MNG-6609:
--
[~rfscholte] Thanks for your input, but I haven't really understood how you can
use {{inherited}} to only inherit to modules of a specific packaging but not to
the other. Setting {{jar}} on the common parent pom is
clear, but how do I make sure that those plugin settings are really used by
"jar" packaging only?
Also in
https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 I
haven't found this mentioned...
> Profile activation by packaging
>
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808895#comment-16808895
]
Robert Scholte commented on MNG-6609:
-
The issue is known, but in general profiles is never the solution. In general I
consider profiles evil as they are too strong and too often used for the wrong
reasons. It would also require a change to the pom 4.0.0 model, which is not
that simple.
What's missing is a more finegrained inheritence strategy. Right now a
[Plugin|https://maven.apache.org/ref/3.6.0/maven-model/maven.html#class_plugin]
has the {{inherited}} option, which is simply true or false. However, it is a
String, which opens possibilities within the current pom version. You could
think of {{jar}} to define that this plugin
configuration should only apply to jar-modules.
IIRC there's a paragraph about it on
https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0
> Profile activation by packaging
>
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808602#comment-16808602 ] Konrad Windszus commented on MNG-6609: -- One example would be one common parent pom for modules of packaging "jar" and "content-package" (supported via http://jackrabbit.apache.org/filevault-package-maven-plugin/index.html). While it makes sense to e.g. configure certain (custom) maven-enforcer-rules for "jars", I certainly don't want those to be executed for "content-packages" (as in general content-packages are not supposed to contain e.g. java classes, therefore executing rules which refer to java classes won't make sense for "content-packages"). Therefore I would like to configure the maven-enforcer rule custom goal execution in a package-specific profile (which is only active for "jar"). > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806247#comment-16806247 ] Karl Heinz Marbaise commented on MNG-6609: -- Can you provide an example project which shows the problem? > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Priority: Major > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
