[jira] [Commented] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Jira 


[ 
https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911390#comment-16911390
 ] 

Christoph Läubrich commented on MNG-6742:
-

okay, sorry for confusion, I opened 
https://github.com/takari/polyglot-maven/issues/192

> org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files 
> ending in.xml
> ---
>
> Key: MNG-6742
> URL: https://issues.apache.org/jira/browse/MNG-6742
> Project: Maven
>  Issue Type: Bug
>Reporter: Christoph Läubrich
>Assignee: Robert Scholte
>Priority: Blocker
>
> in org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) there is 
> the following code:
> {code:java}
>  File pomFile = manager.locatePom(dir);
> if (pomFile != null && !pomFile.getName().endsWith(".pom") && 
> !pomFile.getName().endsWith(".xml")) {
>  ...
> }
> {code}
> This makes it impossible to return any file with xml ending as alternative to 
> pom.xml, in my case data is stored in a file named category.xml and i can't 
> use ist because then my Mapping is never called.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Mickael Istria (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911308#comment-16911308
 ] 

Mickael Istria commented on MNG-6742:
-

Shouldn't it be reported to https://github.com/takari/polyglot-maven/issues 
instead?

> org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files 
> ending in.xml
> ---
>
> Key: MNG-6742
> URL: https://issues.apache.org/jira/browse/MNG-6742
> Project: Maven
>  Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Blocker
>
> in org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) there is 
> the following code:
> {code:java}
>  File pomFile = manager.locatePom(dir);
> if (pomFile != null && !pomFile.getName().endsWith(".pom") && 
> !pomFile.getName().endsWith(".xml")) {
>  ...
> }
> {code}
> This makes it impossible to return any file with xml ending as alternative to 
> pom.xml, in my case data is stored in a file named category.xml and i can't 
> use ist because then my Mapping is never called.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Mickael Istria (Jira) 


[ 
https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911283#comment-16911283
 ] 

Mickael Istria commented on MNG-6742:
-

This is blocking https://bugs.eclipse.org/bugs/show_bug.cgi?id=490886.
Tycho hacked this for feature.xml by assuming there is always a 
build.properties file with it, but it's a hack and cannot be relied upon for 
some other types.
I suggest we just fix it in Maven by refining the condition.

> org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files 
> ending in.xml
> ---
>
> Key: MNG-6742
> URL: https://issues.apache.org/jira/browse/MNG-6742
> Project: Maven
>  Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Blocker
>
> in org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) there is 
> the following code:
> {code:java}
>  File pomFile = manager.locatePom(dir);
> if (pomFile != null && !pomFile.getName().endsWith(".pom") && 
> !pomFile.getName().endsWith(".xml")) {
>  ...
> }
> {code}
> This makes it impossible to return any file with xml ending as alternative to 
> pom.xml, in my case data is stored in a file named category.xml and i can't 
> use ist because then my Mapping is never called.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)