[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462283#comment-17462283 ] Michael Osipov commented on MNG-6949: - No version required, this goes online directly. > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228234#comment-17228234 ] Hudson commented on MNG-6949: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6551 #14 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6551/14/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228166#comment-17228166 ] Hudson commented on MNG-6949: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6556 #14 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6556/14/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228109#comment-17228109 ] Hudson commented on MNG-6949: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6555 #14 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/14/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228052#comment-17228052 ] Hudson commented on MNG-6949: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6553 #14 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/14/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206853#comment-17206853 ] Hudson commented on MNG-6949: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6965/15/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205793#comment-17205793 ] Hudson commented on MNG-6949: - Build succeeded in Jenkins: Maven » Maven TLP » maven » mng-6118-submodule-invocation #2 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/mng-6118-submodule-invocation/2/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200770#comment-17200770 ] Hudson commented on MNG-6949: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #26 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/26/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6949) As a developer on Maven Core I would like to verify my build before merge
[ https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158113#comment-17158113 ] Hudson commented on MNG-6949: - Build succeeded in Jenkins: Maven TLP » maven » master #445 See https://builds.apache.org/job/maven-box/job/maven/job/master/445/ > As a developer on Maven Core I would like to verify my build before merge > - > > Key: MNG-6949 > URL: https://issues.apache.org/jira/browse/MNG-6949 > Project: Maven > Issue Type: Improvement >Reporter: Martin Kanters >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.7.0 > > > One of the requirements before providing a pull request to Maven is that you > have to run `mvn verify` and the integration tests. This is to ensure that > the PR that is delivered is of good quality. I do not disagree with this > approach, but it can be easy to forget to run this, especially in the case of > processing (small) review comments. > For me it already happened a couple of times that a failing test was found at > the time when the pull request was getting merged in master. By utilizing > GitHub Actions we can ensure that the PR's requirements are fulfilled. This > is meant as an addition on top of local tests and the CI job on Jenkins tests > that commiters execute during merger, not a replacement. > > I have implemented this last weekend and would like to propose this. It is > based on another Maven project's GitHub Action workflow, but has been > extended. It features the following: > # mvn verify on Ubuntu, Windows and MacOS machines, with Java 8, 11, 14. > # integration tests against the new Maven build (from step 1). > By default it will run against the latest master version of > apache/maven-integration-testing. > However, if the developer has a branch with the same name as the maven PR on > a forked maven-integration-testing project, it will check that out instead. > Link to the pull request: [https://github.com/apache/maven/pull/365]. > Currently the action is not running on the PR itself, I guess that is due to > settings in the apache/maven project. > It is running on the branch of our fork, though: > [https://github.com/infosupport/maven/actions/runs/150771674]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
