[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1907#comment-1907
]
Michael Osipov commented on MNG-7046:
-
I need to get the bits and pieces together. The topic was quite complex in
MNG-6772.
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1777#comment-1777
]
Michael Osipov commented on MNG-7046:
-
This might be wrong: at no time the client should be able to inject an
incomplete repository which can lead to various side effects. If my revert
would have been complete that would not be possible.
At the end the source of the repo should not matter and the behavior has to be
consistent.
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1763#comment-1763
]
Guillaume Nodet commented on MNG-7046:
--
If you're using the resolver, or if you programmatically build a model and ask
to resolve it, I don't think we should put any restriction here. Not sure to
understand what use case you have in mind.
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1733#comment-1733
]
Michael Osipov commented on MNG-7046:
-
But this applies to validation. What if the classes are used as an API from
client code?
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1712#comment-1712
]
Guillaume Nodet commented on MNG-7046:
--
With master we have the following:
{code}
[INFO] Scanning for projects...
[ERROR] Some problems were encountered while processing the POMs
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project com.ming:maven-failing-import-pom-example:1.0.0-SNAPSHOT
(/Users/gnodet/Downloads/pom-4.xml) has 1 error
[ERROR]
'profiles.profile[repo-will-fail].repositories.repository.[spring-milestones].url'
contains an expression but should be a constant. @ line 39, column 21
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the '-e'
switch
[ERROR] Re-run Maven using the '-X' switch to enable verbose output
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
{code}
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1706#comment-1706
]
Michael Osipov commented on MNG-7046:
-
[~gnodet], can you explain what the outcome is now? I have lost track. Do we
now -- after the revert -- support expressions for string which should be
static actually?
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740666#comment-17740666
]
ASF GitHub Bot commented on MNG-7046:
-
gnodet closed pull request #509: [MNG-7046] Revert MNG-5639 and make repo
config static only
URL: https://github.com/apache/maven/pull/509
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
> Labels: must-be-in-4.0.0-alpha-2
> Fix For: 4.0.x-candidate, 4.0.0
>
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740658#comment-17740658
]
ASF GitHub Bot commented on MNG-7046:
-
michael-o commented on PR #509:
URL: https://github.com/apache/maven/pull/509#issuecomment-1623860750
@gnodet Is this superseded?
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
> Labels: must-be-in-4.0.0-alpha-2
> Fix For: 4.0.x-candidate, 4.0.0
>
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
