[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573135#comment-17573135
]
Hudson commented on MNG-7504:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #34
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/34/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570808#comment-17570808
]
Hudson commented on MNG-7504:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7451 #6
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7451/6/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569661#comment-17569661
]
Hudson commented on MNG-7504:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-394 #18
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-394/18/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568096#comment-17568096
]
Hudson commented on MNG-7504:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #53
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/53/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565477#comment-17565477
]
Hudson commented on MNG-7504:
-
Build failed in Jenkins: Maven » Maven TLP » maven » master #66
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/66/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561903#comment-17561903
]
Hudson commented on MNG-7504:
-
Build failed in Jenkins: Maven » Maven TLP » maven » PR-757 #2
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-757/2/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558892#comment-17558892
]
Hudson commented on MNG-7504:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-756 #7
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-756/7/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0
>
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556571#comment-17556571
]
ASF GitHub Bot commented on MNG-7504:
-
slawekjaranowski merged PR #759:
URL: https://github.com/apache/maven/pull/759
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556570#comment-17556570
]
Hudson commented on MNG-7504:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #47
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/47/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556565#comment-17556565
]
ASF GitHub Bot commented on MNG-7504:
-
slawekjaranowski opened a new pull request, #759:
URL: https://github.com/apache/maven/pull/759
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556561#comment-17556561
]
ASF GitHub Bot commented on MNG-7504:
-
slawekjaranowski closed pull request #758: [MNG-7504] Don't print warning
unsupported reportPlugins for m-site-p
URL: https://github.com/apache/maven/pull/758
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556476#comment-17556476
]
ASF GitHub Bot commented on MNG-7504:
-
michael-o commented on code in PR #758:
URL: https://github.com/apache/maven/pull/758#discussion_r901879826
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -151,28 +151,42 @@ private void checkUnknownMojoConfigurationParameters(
MojoExecution mojoExecutio
unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
-unknownParameters.forEach(
-name ->
-{
-MessageBuilder messageBuilder = MessageUtils.buffer()
-.warning( "Parameter '" )
-.warning( name )
-.warning( "' is unknown for plugin '" )
-.warning( mojoExecution.getArtifactId() ).warning( ":" )
-.warning( mojoExecution.getVersion() ).warning( ":" )
-.warning( mojoExecution.getGoal() );
-
-if ( mojoExecution.getExecutionId() != null )
+unknownParameters.stream()
+.filter( parameterName -> isNotReportPluginsForMavenSite(
parameterName, mojoExecution ) )
+.forEach(
+name ->
{
-messageBuilder.warning( " (" );
-messageBuilder.warning( mojoExecution.getExecutionId() );
-messageBuilder.warning( ")" );
-}
-
-messageBuilder.warning( "'" );
+MessageBuilder messageBuilder = MessageUtils.buffer()
+.warning( "Parameter '" )
+.warning( name )
+.warning( "' is unknown for plugin '" )
+.warning( mojoExecution.getArtifactId() ).warning( ":"
)
+.warning( mojoExecution.getVersion() ).warning( ":" )
+.warning( mojoExecution.getGoal() );
+
+if ( mojoExecution.getExecutionId() != null )
+{
+messageBuilder.warning( " (" );
+messageBuilder.warning( mojoExecution.getExecutionId()
);
+messageBuilder.warning( ")" );
+}
+
+messageBuilder.warning( "'" );
+
+logger.warn( messageBuilder.toString() );
+} );
+}
-logger.warn( messageBuilder.toString() );
-} );
+/**
+ * Method can be removed after {@link
org.apache.maven.model.plugin.ReportingConverter} will be removed or disabled
Review Comment:
I agree.
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556451#comment-17556451
]
ASF GitHub Bot commented on MNG-7504:
-
slawekjaranowski commented on code in PR #758:
URL: https://github.com/apache/maven/pull/758#discussion_r901838788
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -151,28 +151,42 @@ private void checkUnknownMojoConfigurationParameters(
MojoExecution mojoExecutio
unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
-unknownParameters.forEach(
-name ->
-{
-MessageBuilder messageBuilder = MessageUtils.buffer()
-.warning( "Parameter '" )
-.warning( name )
-.warning( "' is unknown for plugin '" )
-.warning( mojoExecution.getArtifactId() ).warning( ":" )
-.warning( mojoExecution.getVersion() ).warning( ":" )
-.warning( mojoExecution.getGoal() );
-
-if ( mojoExecution.getExecutionId() != null )
+unknownParameters.stream()
+.filter( parameterName -> isNotReportPluginsForMavenSite(
parameterName, mojoExecution ) )
+.forEach(
+name ->
{
-messageBuilder.warning( " (" );
-messageBuilder.warning( mojoExecution.getExecutionId() );
-messageBuilder.warning( ")" );
-}
-
-messageBuilder.warning( "'" );
+MessageBuilder messageBuilder = MessageUtils.buffer()
+.warning( "Parameter '" )
+.warning( name )
+.warning( "' is unknown for plugin '" )
+.warning( mojoExecution.getArtifactId() ).warning( ":"
)
+.warning( mojoExecution.getVersion() ).warning( ":" )
+.warning( mojoExecution.getGoal() );
+
+if ( mojoExecution.getExecutionId() != null )
+{
+messageBuilder.warning( " (" );
+messageBuilder.warning( mojoExecution.getExecutionId()
);
+messageBuilder.warning( ")" );
+}
+
+messageBuilder.warning( "'" );
+
+logger.warn( messageBuilder.toString() );
+} );
+}
-logger.warn( messageBuilder.toString() );
-} );
+/**
+ * Method can be removed after {@link
org.apache.maven.model.plugin.ReportingConverter} will be removed or disabled
Review Comment:
Not yet.
Now - I think that this commit can be for 3.9.x
And in 4.x we can drop ReportingConverter - with new issue.
What do you think?
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556363#comment-17556363
]
ASF GitHub Bot commented on MNG-7504:
-
michael-o commented on code in PR #758:
URL: https://github.com/apache/maven/pull/758#discussion_r901635390
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -151,28 +151,42 @@ private void checkUnknownMojoConfigurationParameters(
MojoExecution mojoExecutio
unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
-unknownParameters.forEach(
-name ->
-{
-MessageBuilder messageBuilder = MessageUtils.buffer()
-.warning( "Parameter '" )
-.warning( name )
-.warning( "' is unknown for plugin '" )
-.warning( mojoExecution.getArtifactId() ).warning( ":" )
-.warning( mojoExecution.getVersion() ).warning( ":" )
-.warning( mojoExecution.getGoal() );
-
-if ( mojoExecution.getExecutionId() != null )
+unknownParameters.stream()
+.filter( parameterName -> isNotReportPluginsForMavenSite(
parameterName, mojoExecution ) )
+.forEach(
Review Comment:
Insane! I love lambdas!
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556364#comment-17556364
]
ASF GitHub Bot commented on MNG-7504:
-
michael-o commented on code in PR #758:
URL: https://github.com/apache/maven/pull/758#discussion_r901635603
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -151,28 +151,42 @@ private void checkUnknownMojoConfigurationParameters(
MojoExecution mojoExecutio
unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
-unknownParameters.forEach(
-name ->
-{
-MessageBuilder messageBuilder = MessageUtils.buffer()
-.warning( "Parameter '" )
-.warning( name )
-.warning( "' is unknown for plugin '" )
-.warning( mojoExecution.getArtifactId() ).warning( ":" )
-.warning( mojoExecution.getVersion() ).warning( ":" )
-.warning( mojoExecution.getGoal() );
-
-if ( mojoExecution.getExecutionId() != null )
+unknownParameters.stream()
+.filter( parameterName -> isNotReportPluginsForMavenSite(
parameterName, mojoExecution ) )
+.forEach(
+name ->
{
-messageBuilder.warning( " (" );
-messageBuilder.warning( mojoExecution.getExecutionId() );
-messageBuilder.warning( ")" );
-}
-
-messageBuilder.warning( "'" );
+MessageBuilder messageBuilder = MessageUtils.buffer()
+.warning( "Parameter '" )
+.warning( name )
+.warning( "' is unknown for plugin '" )
+.warning( mojoExecution.getArtifactId() ).warning( ":"
)
+.warning( mojoExecution.getVersion() ).warning( ":" )
+.warning( mojoExecution.getGoal() );
+
+if ( mojoExecution.getExecutionId() != null )
+{
+messageBuilder.warning( " (" );
+messageBuilder.warning( mojoExecution.getExecutionId()
);
+messageBuilder.warning( ")" );
+}
+
+messageBuilder.warning( "'" );
+
+logger.warn( messageBuilder.toString() );
+} );
+}
-logger.warn( messageBuilder.toString() );
-} );
+/**
+ * Method can be removed after {@link
org.apache.maven.model.plugin.ReportingConverter} will be removed or disabled
Review Comment:
Do we already have a ticket for that comment?
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556136#comment-17556136
]
ASF GitHub Bot commented on MNG-7504:
-
slawekjaranowski opened a new pull request, #758:
URL: https://github.com/apache/maven/pull/758
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555990#comment-17555990
]
Michael Osipov commented on MNG-7504:
-
Nice :-D
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555988#comment-17555988
]
Herve Boutemy commented on MNG-7504:
notice that if a user explicitely configured reportPlugins parameter, he'll get
a warning because MNG-6189 checks
then adding a workaround in MNG-7468 linking to this specific parameter check
is IMHO valid (surprisingly)
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555985#comment-17555985
]
Michael Osipov commented on MNG-7504:
-
OK, this I understand. That is why we should remove it, no? As far as I
understand the provisioned idea to remove the reporting section by moving it
into the plugin has been burried.
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555983#comment-17555983
]
Slawomir Jaranowski commented on MNG-7504:
--
Maven in {{DefaultReportingConverter}} prepare configuration for {{m-site-p}}
by setting {{reportPlugins}} parameters ...
but this parameters is not present in {{m-site-p}} >= 3.7 so warning is printed.
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555978#comment-17555978
]
Michael Osipov commented on MNG-7504:
-
We have agreed not to change versions in bindings in 3.x anymore for good
reasons. We do now issue a warning about this. Those who don't care about
warnings and still stick and 3.3 and doomed anyway and I wouldn't even bother.
An upgrade takes less than 5 min.
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555976#comment-17555976
]
Slawomir Jaranowski commented on MNG-7504:
--
Deprecating will not mitigate warning about unsupported parameter ...
The most download m-site-p by version for May 2022
|| version || % ||
|3.3 | 80,50% |
|3.7.1| 6,48% |
|3.8.2 | 2,48% |
|3.12.0 | 1,94% |
|3.9.1 | 1,63% |
|3.6 | 1,42% |
|3.5.1 | 1,22% |
of course version binding in Maven is the most popular
So changing version in binding and drop special configuration should not have
big impact.
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7504) Warning about unknown reportPlugins parameters for m-site-p are always generated
[
https://issues.apache.org/jira/browse/MNG-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555952#comment-17555952
]
Michael Osipov commented on MNG-7504:
-
Deprecate in Maven 3.9.0, drop it in 4.0.0.
> Warning about unknown reportPlugins parameters for m-site-p are always
> generated
>
>
> Key: MNG-7504
> URL: https://issues.apache.org/jira/browse/MNG-7504
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.9.0, 4.0.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{m-site-p 3.7}} configuration parameter {{reportPlugins}} was removed
> MSITE-792
> After MNG-7468 unknown parameter is detected and warning is generated.
> We have service {{org.apache.maven.model.plugin.DefaultReportingConverter}}
> which always add configuration for m-site-p with unsupported parameter
> {{reportPlugins}}.
> Configuration is added when project contains reporting sections.
> Possible solution
> - drop service - easy to implement but with impact on m-site-p < 3.7
> - detect m-site-p version in project - complicated
> - don't print warning about {{reportPlugins}} for {{m-site-p}} - easy but
> workaround
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
