[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776239#comment-17776239
]
Konrad Windszus commented on MNG-7587:
--
[~cstamas] [~gnodet] I am still in favour of backporting this to Maven 3.9.x
given the discussion at
https://lists.apache.org/thread/6wxrhlkrqsl7wgr730xd50h55t7ff0vy. I am not sure
what are really the regressions faced here and whether there is an easy
workaround fix we can just document.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-7, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728798#comment-17728798
]
Marc Philipp commented on MNG-7587:
---
[~gnodet] Why's that?
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728748#comment-17728748
]
Guillaume Nodet commented on MNG-7587:
--
I've reverted the change to 3.9.3.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728594#comment-17728594
]
Marc Philipp commented on MNG-7587:
---
Please add to the release notes for 3.9.3 that the Sisu update might break
certain extensions (e.g. the Gradle Enterprise one) and requires updating
affected extensions.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727840#comment-17727840
]
ASF GitHub Bot commented on MNG-7587:
-
gnodet merged PR #1119:
URL: https://github.com/apache/maven/pull/1119
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727838#comment-17727838
]
ASF GitHub Bot commented on MNG-7587:
-
gnodet merged PR #1121:
URL: https://github.com/apache/maven/pull/1121
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725748#comment-17725748
]
Sylwester Lachiewicz commented on MNG-7587:
---
Few updates
* maven-plugin-plugin from 3.6.0 to 3.9.0
* disable (for a while) unit test - leave only integration test
* use Maven from this PR [https://github.com/apache/maven/pull/1121] - because
we need updated Eclipse Sisu
then mvn clean verify -Drunning-java-release-version=20 -Prun-its just works.
for unit tests to work - we may need more time as in demo project
maven-plugin-testing-harness may need more investigation
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725743#comment-17725743
]
Konrad Windszus commented on MNG-7587:
--
bq. Sisu 0.3.5 supports bytecode up to Java 11, good.
Actually up to Java 14 :-), but the important bit is: Java 17 bytecode is not
yet working!
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725736#comment-17725736
]
Tamas Cservenak commented on MNG-7587:
--
{quote}By the way this makes the -V flag quite useless if it do print a
different maven than actually used...
{quote}
Am now completely lost here... what are you talking about?
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725735#comment-17725735
]
Tamas Cservenak commented on MNG-7587:
--
Ok, so you got to the conclusion we told you about (and this issue is about):
Sisu 0.3.5 supports bytecode up to Java 11, good.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725733#comment-17725733
]
Christoph Läubrich commented on MNG-7587:
-
> but your project depends (and executes) with maven 3.3.9... what does it do
> with maven version you build with?
Don't understand this as given above I only have maven 3.8.6 used, no idea what
maven is performing under the hood but even
{code:java}
/opt/maven/3.9.0/bin/mvn clean verify -Drunning-java-release-version=11 -V
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
Maven home: /opt/maven/3.9.0
Java version: 17.0.6, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-17-oracle
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "4.19.0-17-amd64", arch: "amd64", family:
"unix"{code}
fails the same way ... so it seem to magically using an older maven actually?
So I removed 3.3.9 then Java 11 works, but Java
17 still fails.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725727#comment-17725727
]
Tamas Cservenak commented on MNG-7587:
--
but your project depends (and executes) with maven 3.3.9... what does it do
with maven version you build with?
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725726#comment-17725726
]
Christoph Läubrich commented on MNG-7587:
-
Well I'm using what given by this
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Java version: 17.0.6, vendor: Oracle Corporation, runtime
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "4.19.0-17-amd64", arch: "amd64", family: "unix"
and then following
[https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#mojo-archetype]
so don't shoot the messenger ;)
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725724#comment-17725724
]
Tamas Cservenak commented on MNG-7587:
--
Totally totally wrong conclusion.
It works just fine with Java11, but not with ancient Maven version 3.3.9 (that
includes even older sisu 0.3.2, not 0.3.5 we talked about). Just edit your POM
to contain this:
{noformat}
3.8.8 {noformat}
And Java11 will work just fine.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725705#comment-17725705
]
Christoph Läubrich commented on MNG-7587:
-
I added an example that a more skilled person might easily transform into an
integration test I have generated it with the maven plugin archetype and
publish it under the Apache License 2 or any other that you like as it does not
really contain anything more than empty classes and generated code.
Run it with
* mvn clean verify -Drunning-java-release-version=1.8 -->
{color:#57d9a3}*BUILD SUCCESS*{color}
* mvn clean verify -Drunning-java-release-version=11 --> {color:#FF}*BUILD
FAILURE*{color} No implementation for sample.plugin.MyService was bound
* mvn clean verify -Drunning-java-release-version=17 --> {color:#de350b}*BUILD
FAILURE*{color} Unsupported class file major version 61
[~cstamas] I hope this illustrates why JSR330 is currently not really an
option for any plugin wanting to use Java > 8 ...
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725675#comment-17725675
]
Tamas Cservenak commented on MNG-7587:
--
Btw, 0.9.0.M2 is out that supports bytecode up to Java21.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725667#comment-17725667
]
Tamas Cservenak commented on MNG-7587:
--
[~slachiewicz] nope, as sisu does "mild class gleaning" at runtime using ASM,
and will fail to scan classes not supported by its embedded ASM. Sisu 0.3.5
goes up to Java11 but nothing beyond. This is not guice but sisu issue.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721053#comment-17721053
]
Sylwester Lachiewicz commented on MNG-7587:
---
we can also upgrade Guice to 6 - same effect.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.x-candidate, 4.0.x-candidate
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708015#comment-17708015
]
Tamas Cservenak commented on MNG-7587:
--
I want 3.9.2 ASAP, so we may punt on this, make it 3.9.3 or so...
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.2, 4.0.x-candidate
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635492#comment-17635492
]
Konrad Windszus commented on MNG-7587:
--
Sisu has been updated to ASM 9.4 in
https://github.com/eclipse/sisu.inject/commit/6fa4bc1a635f1e8ec91e438bcb059f414d713f70
supporting up to Java 20.
> Update sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.0-candidate
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
